MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

PY-90741 [debugger]: modify redirection parameter in pydevd_io

Browse Source 
The issue with duplicated output in REPL is solved if we remove the output stream duplication during stream redirection in pydevd_io. All REPL messages will now be routed through JSON-RPC and not kept forwarded through stdout. This path is only used by REPL, so other messages (regular output, etc.) are not affected and may go either through JSON-RPC or through stdout

Issue Explanation: In integratedTerminal mode, two independent paths deliver stdout to the
IDE during Debug Console (REPL) evaluation:

1. forwardStream in PythonDapClient reads the process stdout pipe and
   sends DAP output events.
2. pydevd temporarily redirects sys.stdout via IORedirector during REPL
   evaluation (when redirectOutput is false). IORedirector.write() writes
   to both the original pipe and RedirectToPyDBIoMessages, which sends a
   second DAP output event through JSON-RPC.

Both events flow through the same output channel, causing print() output
to appear twice.

Also fix a secondary bug in formatAndPrintOutput where IMPORTANT-category
events were printed twice (once as SYSTEM, once as STDERR) due to a
missing return statement.

Test: add testDebugConsolePrintNotDuplicated to PyDebugConsoleTest that
asserts print() output appears exactly once.


Merge-request: IJ-MR-212126
Merged-by: Maxim Popov <maxim.popov@jetbrains.com>

(cherry picked from commit e1965de20e80c118e16872116fb14f45dc82b83b)

IJ-MR-212126

GitOrigin-RevId: 53228ff3a861e293e2095a81b37ed3e36262a12e
This commit is contained in:
Maxim Popov
2026-07-08 22:14:25 +00:00
committed by intellij-monorepo-bot
parent ca3197d1c3
commit 1538b26b46
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/helpers/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_io.py
+7 -3
View File
@@ -201,10 +201,14 @@ def end_redirect(std="stdout"):
setattr(sys, std, redirect_info.original)
def redirect_stream_to_pydb_io_messages(std):
def redirect_stream_to_pydb_io_messages(std, keep_original_redirection=True):
"""
:param std:
'stdout' or 'stderr'
:param keep_original_redirection:
If True (default), wraps sys.stdout/stderr with IORedirector that fans out to both the
original stream and RedirectToPyDBIoMessages. If False, replaces sys.stdout/stderr entirely
with RedirectToPyDBIoMessages (output goes only through JSON-RPC).
"""
with _RedirectionsHolder._lock:
redirect_to_name = "_pydevd_%s_redirect_" % (std,)
@@ -213,7 +217,7 @@ def redirect_stream_to_pydb_io_messages(std):
original = getattr(sys, std)
redirect_to = RedirectToPyDBIoMessages(1 if std == "stdout" else 2, original, wrap_buffer)
start_redirect(keep_original_redirection=True, std=std, redirect_to=redirect_to)
start_redirect(keep_original_redirection=keep_original_redirection, std=std, redirect_to=redirect_to)
stack = getattr(_RedirectionsHolder, "_stack_%s" % std)
setattr(_RedirectionsHolder, redirect_to_name, stack[-1])
@@ -246,7 +250,7 @@ def redirect_stream_to_pydb_io_messages_context():
with _RedirectionsHolder._lock:
redirecting = []
for std in ("stdout", "stderr"):
if redirect_stream_to_pydb_io_messages(std):
if redirect_stream_to_pydb_io_messages(std, keep_original_redirection=False):
redirecting.append(std)
try: