MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

^174 "from my point of view it would be better to make inner MyFullValueEvaluator class static and change constructor signature to accept Value instead of int actualLength."

Browse Source
This commit is contained in:
Vladimir Krivosheev
2014-04-07 11:33:40 +02:00
parent 7371df17bd
commit 141fa22c23
1 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/script-debugger/debugger-ui/src/org/jetbrains/debugger/VariableView.java
+11 -11
View File
@@ -183,14 +183,10 @@ public final class VariableView extends XNamedValue implements VariableContext {
case STRING: {
node.setPresentation(getIcon(), new XStringValuePresentation(valueString), false);
if (value instanceof StringValue) {
StringValue stringValue = (StringValue)value;
if (stringValue.isTruncated() || valueString.length() > XValueNode.MAX_VALUE_LENGTH) {
node.setFullValueEvaluator(new MyFullValueEvaluator(stringValue.getLength()));
}
}
else if (valueString.length() > XValueNode.MAX_VALUE_LENGTH) {
node.setFullValueEvaluator(new MyFullValueEvaluator(valueString.length()));
// isTruncated in terms of debugger backend, not in our terms (i.e. sometimes we cannot control truncation),
// so, even in case of StringValue, we check value string length
if ((value instanceof StringValue && ((StringValue)value).isTruncated()) || valueString.length() > XValueNode.MAX_VALUE_LENGTH) {
node.setFullValueEvaluator(new MyFullValueEvaluator(value));
}
}
break;
@@ -447,9 +443,13 @@ public final class VariableView extends XNamedValue implements VariableContext {
return context.getDebugProcess().propertyNamesToString(list, false);
}
private class MyFullValueEvaluator extends XFullValueEvaluator {
public MyFullValueEvaluator(int actualLength) {
super(actualLength);
private static class MyFullValueEvaluator extends XFullValueEvaluator {
private final Value value;
public MyFullValueEvaluator(@NotNull Value value) {
super(value instanceof StringValue ? ((StringValue)value).getLength() : value.getValueString().length());
this.value = value;
}
@Override