MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

IDEA-62987 IDEA is "Reading maven projects" to halt when editing POM files

Browse Source 
Optimizate MavenProjectsStructure.BaseDependenciesNode.updateChildren()
This commit is contained in:
Sergey Evdokimov
2013-03-01 16:18:42 +04:00
parent 002773c8d6
commit 13ddca1564
1 changed files with 39 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/maven/src/main/java/org/jetbrains/idea/maven/navigator/MavenProjectsStructure.java
+39 -6
View File
@@ -949,7 +949,7 @@ public class MavenProjectsStructure extends SimpleTreeStructure {
public void updatePlugins(MavenProject mavenProject) {
List<MavenPlugin> plugins = mavenProject.getDeclaredPlugins();
for (PluginNode each : new ArrayList<PluginNode>(myPluginNodes)) {
for (PluginNode each : myPluginNodes.toArray(new PluginNode[myPluginNodes.size()])) {
if (plugins.contains(each.getPlugin())) {
each.updatePlugin();
}
@@ -1058,22 +1058,55 @@ public class MavenProjectsStructure extends SimpleTreeStructure {
}
protected void updateChildren(List<MavenArtifactNode> children, MavenProject mavenProject) {
List<DependencyNode> newNodes = new ArrayList<DependencyNode>(children.size());
List<DependencyNode> newNodes = null;
int validChildCount = 0;
for (MavenArtifactNode each : children) {
if (each.getState() != MavenArtifactState.ADDED) continue;
DependencyNode newNode = findOrCreateNodeFor(each, mavenProject);
if (newNodes == null) {
if (validChildCount < myChildren.size()) {
DependencyNode currentValidNode = myChildren.get(validChildCount);
if (currentValidNode.myArtifact.equals(each.getArtifact())) {
currentValidNode.updateChildren(each.getDependencies(), mavenProject);
currentValidNode.updateDependency();
validChildCount++;
continue;
}
}
newNodes = new ArrayList<DependencyNode>(children.size());
newNodes.addAll(myChildren.subList(0, validChildCount));
}
DependencyNode newNode = findOrCreateNodeFor(each, mavenProject, validChildCount);
newNodes.add(newNode);
newNode.updateChildren(each.getDependencies(), mavenProject);
newNode.updateDependency();
}
if (newNodes == null) {
if (validChildCount == myChildren.size()) {
return; // All nodes are valid, child did not changed.
}
assert validChildCount < myChildren.size();
newNodes = new ArrayList<DependencyNode>(myChildren.subList(0, validChildCount));
}
myChildren = newNodes;
childrenChanged();
}
private DependencyNode findOrCreateNodeFor(MavenArtifactNode artifact, MavenProject mavenProject) {
for (DependencyNode each : myChildren) {
if (each.myArtifact.equals(artifact.getArtifact())) return each;
private DependencyNode findOrCreateNodeFor(MavenArtifactNode artifact, MavenProject mavenProject, int from) {
for (int i = from; i < myChildren.size(); i++) {
DependencyNode node = myChildren.get(i);
if (node.myArtifact.equals(artifact.getArtifact())) {
return node;
}
}
return new DependencyNode(this, artifact, mavenProject);
}