MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

MissingOverrideAnnotationInspection: don't run for non-overrideable methods, filter candidates by parameter count

Browse Source
This commit is contained in:
peter
2019-04-15 20:05:12 +02:00
parent 437874516c
commit 13b829d222
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/InspectionGadgets/src/com/siyeh/ig/inheritance/MissingOverrideAnnotationInspection.java
+5 -1
View File
@@ -156,12 +156,16 @@ public class MissingOverrideAnnotationInspection extends AbstractBaseJavaLocalIn
// 3) only one annotation with short name 'Override' exists: it's 'java.lang.Override'
private void checkMissingOverrideInOverriders(@NotNull PsiMethod method,
@NotNull InspectionResult result) {
if (!PsiUtil.canBeOverridden(method)) return;
Project project = method.getProject();
LanguageLevel minimal = Objects.requireNonNull(method.getContainingClass()).isInterface() ? LanguageLevel.JDK_1_6 : LanguageLevel.JDK_1_5;
GlobalSearchScope scope = getLanguageLevelScope(minimal, project);
if (scope == null) return;
Predicate<PsiMethod> preFilter = m -> !JavaOverridingMethodUtil.containsAnnotationWithName(m, OVERRIDE_SHORT_NAME);
int paramCount = method.getParameterList().getParametersCount();
Predicate<PsiMethod> preFilter = m -> m.getParameterList().getParametersCount() == paramCount &&
!JavaOverridingMethodUtil.containsAnnotationWithName(m, OVERRIDE_SHORT_NAME);
Stream<PsiMethod> overridingMethods = JavaOverridingMethodUtil.getOverridingMethodsIfCheapEnough(method, scope, preFilter);
if (overridingMethods == null) return;
result.hierarchyAnnotated = ThreeState.fromBoolean(!overridingMethods.findAny().isPresent());