[log] simplify

Remove onSuccess, just make sure loading indicator is hidden after
setting up new table model.
This commit is contained in:
Kirill Likhodedov
2013-12-21 17:14:58 +04:00
parent 4d55fdde0d
commit 12fd8d45ad
3 changed files with 3 additions and 8 deletions
@@ -90,13 +90,12 @@ public class VcsLogFilterer {
});
}
public void requestVcs(@NotNull Collection<VcsLogFilter> filters, final Runnable onSuccess) {
public void requestVcs(@NotNull Collection<VcsLogFilter> filters) {
myLogDataHolder.getFilteredDetailsFromTheVcs(filters, new Consumer<List<VcsFullCommitDetails>>() {
@Override
public void consume(List<VcsFullCommitDetails> details) {
myUI.setModel(new NoGraphTableModel(myUI, details, myLogDataHolder.getDataPack().getRefsModel(), false));
myUI.updateUI();
onSuccess.run();
}
});
}
@@ -95,6 +95,7 @@ public class VcsLogUI {
if (previousModel instanceof AbstractVcsLogTableModel) { // initially it is an empty DefaultTableModel
restoreSelection(table, (AbstractVcsLogTableModel)previousModel, selectedRows, model);
}
table.setPaintBusy(false);
}
private static void restoreSelection(@NotNull VcsLogGraphTable table, @NotNull AbstractVcsLogTableModel previousModel,
@@ -67,12 +67,7 @@ public class NoGraphTableModel extends AbstractVcsLogTableModel<CommitCell, Hash
}
myUi.getTable().setPaintBusy(true);
myUi.getFilterer().requestVcs(myUi.collectFilters(), new Runnable() {
@Override
public void run() {
myUi.getTable().setPaintBusy(false);
}
});
myUi.getFilterer().requestVcs(myUi.collectFilters());
myAllowLoadingMoreRequest = false; // Don't send the request to VCS twice
}