[java, inspection, varargs] IDEA-381686 add support for varargs in Javadoc references

GitOrigin-RevId: c01b9be043eed1617be3062e56154364a325ebc2

java/java-analysis-impl/src/com/siyeh/ig/jdk/VarargParameterInspection.java

@@ -24,7 +24,9 @@ import com.intellij.openapi.project.Project;
 import com.intellij.psi.*;
 import com.intellij.psi.codeStyle.CodeStyleManager;
 import com.intellij.psi.codeStyle.JavaCodeStyleManager;
+import com.intellij.psi.impl.source.javadoc.PsiDocMethodOrFieldRef;
 import com.intellij.psi.infos.MethodCandidateInfo;
+import com.intellij.psi.javadoc.PsiInlineDocTag;
 import com.intellij.psi.search.searches.ReferencesSearch;
 import com.intellij.util.containers.ContainerUtil;
 import com.siyeh.InspectionGadgetsBundle;
@@ -53,7 +55,7 @@ public final class VarargParameterInspection extends BaseInspection {
   }
 
   @Override
-  protected @Nullable LocalQuickFix buildFix(Object... infos) {
+  protected @NotNull LocalQuickFix buildFix(Object... infos) {
     return new VarargParameterFix();
   }
 
@@ -91,7 +93,8 @@ public final class VarargParameterInspection extends BaseInspection {
       if (IntentionPreviewUtils.isIntentionPreviewActive()) {
         return SyntaxTraverser.psiTraverser(method.getContainingFile())
           .filter(ref -> ref instanceof PsiJavaCodeReferenceElement && ((PsiJavaCodeReferenceElement)ref).isReferenceTo(method) ||
-                         ref instanceof PsiEnumConstant && method.isEquivalentTo(((PsiEnumConstant)ref).resolveMethod()))
+                         ref instanceof PsiEnumConstant && method.isEquivalentTo(((PsiEnumConstant)ref).resolveMethod()) ||
+                         ref instanceof PsiDocMethodOrFieldRef && ref.getReference() instanceof PsiReference docRef && docRef.isReferenceTo(method))
           .toList();
       }
       final Collection<PsiReference> references = ReferencesSearch.search(method).findAll();
@@ -118,6 +121,7 @@ public final class VarargParameterInspection extends BaseInspection {
       }
       for (PsiElement reference : references) {
         modifyCall(typeText, parameters.length - 1, reference);
+        modifyJavadoc(parameters.length - 1, reference);
       }
       final PsiType arrayType = type.toArrayType();
       final PsiTypeElement newTypeElement = JavaPsiFacade.getElementFactory(lastParameter.getProject()).createTypeElement(arrayType);
@@ -128,8 +132,39 @@ public final class VarargParameterInspection extends BaseInspection {
       new CommentTracker().replaceAndRestoreComments(typeElement, newTypeElement);
     }
 
+    public static void modifyJavadoc(int indexOfFirstVarargArgument, @NotNull PsiElement reference) {
+      if(!(reference instanceof PsiDocMethodOrFieldRef ref)) return;
+      String[] signature = ref.getSignature();
+      if (signature == null || signature.length -1 != indexOfFirstVarargArgument) return;
+      PsiElement name = ref.getNameElement();
+      if (name == null) return;
+      String vararg = signature[indexOfFirstVarargArgument];
+      if (!vararg.endsWith("...")) return;
+      vararg = vararg.substring(0, vararg.length() - 3) + "[]";
+
+      final StringBuilder text = new StringBuilder();
+      text.append("/** {@link #").append(name.getText()).append("(");
+      for (int i = 0; i < signature.length -1; i++) {
+        text.append(signature[i]).append(",");
+      }
+      text.append(vararg).append(")} */");
+      final Project project = reference.getProject();
+      PsiComment comment = JavaPsiFacade.getElementFactory(project).createCommentFromText(text.toString(), reference);
+
+      PsiElement inlineDocTag = ContainerUtil.find(comment.getChildren(), c -> c instanceof PsiInlineDocTag);
+      if (inlineDocTag == null) return;
+      PsiElement newElement = ContainerUtil.find(inlineDocTag.getChildren(), c -> c instanceof PsiDocMethodOrFieldRef);
+      if(newElement == null) return;
+      reference.replace(newElement);
+    }
+
     public static void modifyCall(String arrayTypeText, int indexOfFirstVarargArgument, @NotNull PsiElement reference) {
-      final PsiCall call = (PsiCall)(reference instanceof PsiCall ? reference : reference.getParent());
+      final PsiCall call = reference instanceof PsiCall psiCall
+                           ? psiCall
+                           : reference.getParent() instanceof PsiCall psiCall
+                             ? psiCall
+                             : null;
+      if (call == null) return;
       JavaResolveResult result = call.resolveMethodGenerics();
       if (result instanceof MethodCandidateInfo &&
           ((MethodCandidateInfo)result).getApplicabilityLevel() != MethodCandidateInfo.ApplicabilityLevel.VARARGS) {

java/java-impl-refactorings/src/com/intellij/refactoring/safeDelete/JavaSafeDeleteDelegateImpl.java

@@ -57,9 +57,9 @@ public final class JavaSafeDeleteDelegateImpl implements JavaSafeDeleteDelegate
         }
       }
     }
-    else if (element instanceof PsiDocMethodOrFieldRef) {
-      String[] signature = ((PsiDocMethodOrFieldRef)element).getSignature();
-      PsiElement nameElement = ((PsiDocMethodOrFieldRef)element).getNameElement();
+    else if (element instanceof PsiDocMethodOrFieldRef ref) {
+      String[] signature = ref.getSignature();
+      PsiElement nameElement = ref.getNameElement();
       if (signature != null && nameElement != null) {
         final @NonNls StringBuffer newText = new StringBuffer();
         newText.append("/** @see #").append(nameElement.getText()).append('(');

java/java-tests/testData/ig/com/siyeh/igfixes/jdk/vararg_parameter/JavadocReference.after.java

@@ -0,0 +1,16 @@
+package com.siyeh.igfixes.jdk.vararg_parameter;
+
+public class JavadocReference {
+  void convertIndexes(String str, int[] indexes) {
+    System.out.println(indexes.length);
+  }
+
+  /**
+   * Converts indexes using conversion.
+   *
+   * See also {@link #convertIndexes(String, int[])}
+   */
+  void test() {
+    convertIndexes("hi!", new int[]{1, 2, 3});
+  }
+}

java/java-tests/testData/ig/com/siyeh/igfixes/jdk/vararg_parameter/JavadocReference.java

@@ -0,0 +1,16 @@
+package com.siyeh.igfixes.jdk.vararg_parameter;
+
+public class JavadocReference {
+  void convertIn<caret>dexes(String str, int... indexes) {
+    System.out.println(indexes.length);
+  }
+
+  /**
+   * Converts indexes using conversion.
+   *
+   * See also {@link #convertIndexes(String, int...)}
+   */
+  void test() {
+    convertIndexes("hi!", 1, 2, 3);
+  }
+}

java/java-tests/testSrc/com/siyeh/ig/fixes/jdk/VarargParameterFixTest.java

@@ -1,3 +1,4 @@
+// Copyright 2000-2025 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
 package com.siyeh.ig.fixes.jdk;
 
 import com.siyeh.InspectionGadgetsBundle;
@@ -17,4 +18,5 @@ public class VarargParameterFixTest extends IGQuickFixesTestCase {
   public void testGenericType() { doTest(); }
   public void testEnumConstants() { doTest(); }
   public void testConstructorCall() { doTest(); }
+  public void testJavadocReference() { doTest(); }
 }