MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-01-05 01:50:56 +07:00
Code Issues Packages Projects Releases Wiki Activity

field can be local: exclude all fields used in fields initializers (IDEA-72649 )

Browse Source
This commit is contained in:
anna
2011-08-21 16:39:02 +02:00
parent 386cb944a6
commit 12e8bcbd5d
4 changed files with 18 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
java/java-impl/src/com/intellij/codeInspection/varScopeCanBeNarrowed/FieldCanBeLocalInspection.java
View File

@@ -229,14 +229,11 @@ public class FieldCanBeLocalInspection extends BaseLocalInspectionTool {
}
@Override public void visitReferenceExpression(PsiReferenceExpression expression) {
final PsiExpression qualifier = expression.getQualifierExpression();
if (qualifier == null || qualifier instanceof PsiThisExpression) {
final PsiElement resolved = expression.resolve();
if (resolved instanceof PsiField) {
final PsiField field = (PsiField)resolved;
if (aClass.equals(field.getContainingClass())) {
candidates.remove(field);
}
final PsiElement resolved = expression.resolve();
if (resolved instanceof PsiField) {
final PsiField field = (PsiField)resolved;
if (aClass.equals(field.getContainingClass())) {
candidates.remove(field);
}
}

3
java/java-tests/testData/inspection/fieldCanBeLocal/fieldUsedInConstantInitialization/expected.xml Normal file
View File

@@ -0,0 +1,3 @@
<?xml version="1.0" encoding="UTF-8"?>
<problems>
</problems>

9
java/java-tests/testData/inspection/fieldCanBeLocal/fieldUsedInConstantInitialization/src/Test.java Normal file
View File

@@ -0,0 +1,9 @@
class Test {
public static final Object FOO = new Test().foo;
private final String foo;
private Test() {
foo = "some text";
}
}

1
java/java-tests/testSrc/com/intellij/codeInspection/FieldCanBeLocalTest.java
View File

@@ -30,6 +30,7 @@ public class FieldCanBeLocalTest extends InspectionTestCase {
public void testLocalStateVar2InnerClass() throws Exception { doTest(); }
public void testNotConstantInitializer() throws Exception {doTest();}
public void testInnerClassFieldInitializer() throws Exception {doTest();}
public void testFieldUsedInConstantInitialization() throws Exception {doTest();}
public void testFieldWithImmutableType() throws Exception {doTest();}
public void testIgnoreAnnotated() throws Exception {
final FieldCanBeLocalInspection inspection = new FieldCanBeLocalInspection();