PY-84972 Fix NPE in PyInvalidCastInspection

Mark PyWithAncestors.getAncestorTypes return type as @Nullable


(cherry picked from commit fb7cbbebfac371b21456711087f82fbdaf21673c)

IJ-MR-179357

GitOrigin-RevId: f24cca2c4923f4bb06b4f7204f2c56b95047e4cf

python/python-psi-api/src/com/jetbrains/python/psi/PyWithAncestors.java

@@ -19,6 +19,7 @@ import com.jetbrains.python.ast.PyAstWithAncestors;
 import com.jetbrains.python.psi.types.PyClassLikeType;
 import com.jetbrains.python.psi.types.TypeEvalContext;
 import org.jetbrains.annotations.NotNull;
+import org.jetbrains.annotations.Nullable;
 
 import java.util.List;
 
@@ -32,5 +33,5 @@ public interface PyWithAncestors extends PyAstWithAncestors {
    * Returns types of all ancestors from the hierarchy.
    */
   @NotNull
-  List<PyClassLikeType> getAncestorTypes(@NotNull TypeEvalContext context);
+  List<@Nullable PyClassLikeType> getAncestorTypes(@NotNull TypeEvalContext context);
 }

python/python-psi-impl/src/com/jetbrains/python/inspections/PyInvalidCastInspection.kt

@@ -83,7 +83,7 @@ private fun computeSuggestedIntermediateTypeName(targetType: PyType?, actualType
     fun mro(t: PyClassLikeType): List<PyClassLikeType> {
       val result = ArrayList<PyClassLikeType>()
       result.add(t)
-      result.addAll(t.getAncestorTypes(context))
+      result.addAll(t.getAncestorTypes(context).filterNotNull())
       return result
     }
 

python/python-psi-impl/src/com/jetbrains/python/psi/types/PyClassTypeImpl.java

@@ -380,7 +380,7 @@ public class PyClassTypeImpl extends UserDataHolderBase implements PyClassType {
   }
 
   @Override
-  public @NotNull List<PyClassLikeType> getAncestorTypes(final @NotNull TypeEvalContext context) {
+  public @NotNull List<@Nullable PyClassLikeType> getAncestorTypes(final @NotNull TypeEvalContext context) {
     return myClass.getAncestorTypes(context);
   }
 
@@ -628,7 +628,7 @@ public class PyClassTypeImpl extends UserDataHolderBase implements PyClassType {
     }
   }
 
-  private @NotNull StreamEx<PyClassLikeType> prepareTypesForProcessingMembers(@NotNull List<PyClassLikeType> types) {
+  private @NotNull StreamEx<PyClassLikeType> prepareTypesForProcessingMembers(@NotNull List<@Nullable PyClassLikeType> types) {
     return StreamEx.of(types).nonNull().map(type -> isDefinition() ? type.toClass() : type.toInstance());
   }
 

python/python-psi-impl/src/com/jetbrains/python/psi/types/PyTypingNewType.kt

@@ -77,7 +77,7 @@ class PyTypingNewType(private val classType: PyClassType,
     }
   }
 
-  override fun getAncestorTypes(context: TypeEvalContext): List<PyClassLikeType> {
+  override fun getAncestorTypes(context: TypeEvalContext): List<PyClassLikeType?> {
     return listOf(classType) + classType.getAncestorTypes(context)
   }