ensure expression valid, initializer expression should be already replaced (IDEA-125231)

java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/CreateFromUsageUtils.java

@@ -864,7 +864,7 @@ public class CreateFromUsageUtils {
 
   public static boolean isAccessedForWriting(final PsiExpression[] expressionOccurences) {
     for (PsiExpression expression : expressionOccurences) {
-      if(PsiUtil.isAccessedForWriting(expression)) return true;
+      if(expression.isValid() && PsiUtil.isAccessedForWriting(expression)) return true;
     }
 
     return false;

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/createLocalFromUsage/afterFinal.java

@@ -0,0 +1,7 @@
+// "Create Local Variable 'zeit'" "true"
+public class A {
+    void foo() {
+        final String zeit = "";
+    }
+
+}

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/createLocalFromUsage/beforeFinal.java

@@ -0,0 +1,7 @@
+// "Create Local Variable 'zeit'" "true"
+public class A {
+    void foo() {
+        ze<caret>it = "";
+    }
+
+}

java/java-tests/testSrc/com/intellij/codeInsight/daemon/quickFix/CreateLocalFromUsageTest.java

@@ -1,9 +1,24 @@
 package com.intellij.codeInsight.daemon.quickFix;
 
+import com.intellij.psi.codeStyle.CodeStyleSettingsManager;
+
 /**
  * @author ven
  */
 public class CreateLocalFromUsageTest extends LightQuickFixParameterizedTestCase {
+
+  @Override
+  protected void setUp() throws Exception {
+    super.setUp();
+    CodeStyleSettingsManager.getSettings(getProject()).GENERATE_FINAL_LOCALS = getTestName(true).contains("final");
+  }
+
+  @Override
+  protected void tearDown() throws Exception {
+    CodeStyleSettingsManager.getSettings(getProject()).GENERATE_FINAL_LOCALS = false;
+    super.tearDown();
+  }
+
   public void test() throws Exception { doAllTests(); }
 
   @Override