MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-05-06 05:10:22 +07:00
Code Issues Packages Projects Releases Wiki Activity

EA-33799 (IOE: PsiJavaParserFacadeImpl.createExpressionFromText)

Browse Source
This commit is contained in:
Bas Leijdekkers
2012-02-18 15:08:14 +01:00
parent 613c8a4798
commit 0d73811b02
3 changed files with 15 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/ConvertDoubleToFloatFix.java
View File

@@ -52,7 +52,7 @@ public class ConvertDoubleToFloatFix implements IntentionAction {
@Override
public boolean isAvailable(@NotNull Project project, Editor editor, PsiFile file) {
if (myExpression.isValid()) {
if (!StringUtil.endsWithIgnoreCase(myExpression.getText(), "d")) {
if (!StringUtil.endsWithIgnoreCase(myExpression.getText(), "f")) {
final PsiLiteralExpression expression = (PsiLiteralExpression)createFloatingPointExpression(project);
final Object value = expression.getValue();
return value instanceof Float && !((Float)value).isInfinite() && !(((Float)value).floatValue() == 0 && !HighlightUtil.isFPZero(expression.getText()));
@@ -67,7 +67,12 @@ public class ConvertDoubleToFloatFix implements IntentionAction {
}
private PsiExpression createFloatingPointExpression(Project project) {
return JavaPsiFacade.getElementFactory(project).createExpressionFromText(myExpression.getText() + "f", myExpression);
final String text = myExpression.getText();
if (StringUtil.endsWithIgnoreCase(text, "d")) {
return JavaPsiFacade.getElementFactory(project).createExpressionFromText(text.substring(0, text.length() - 1) + "f", myExpression);
} else {
return JavaPsiFacade.getElementFactory(project).createExpressionFromText(text + "f", myExpression);
}
}
@Override

7
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convertDoubleToFloat/after6.java Normal file
View File

@@ -0,0 +1,7 @@
// "Convert '1e-9d' to float" "true"
class Test {
void bar() {
foo(1e-9f);
}
void foo(float f){}
}

2
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/convertDoubleToFloat/before6.java
View File

@@ -1,4 +1,4 @@
// "Convert '1e-9d' to float" "false"
// "Convert '1e-9d' to float" "true"
class Test {
void bar() {
foo(1e-9<caret>d);