MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

ConstantExpressionInspection: display computed value in inspection message, cosmetics

Browse Source 
Review ID: IDEA-CR-28753
This commit is contained in:
Tagir Valeev
2018-01-26 12:36:52 +07:00
parent 97300d73f1
commit 0d23cefe70
2 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/InspectionGadgetsBundle.properties
+1
View File
@@ -2264,6 +2264,7 @@ fix.add.argument.family.name=Add argument
fix.add.argument.name=Add ''{0}'' argument
inspection.constant.expression.display.name=Constant expression can be evaluated
inspection.constant.expression.message=Constant expression can be evaluated to ''{0}''
inspection.constant.expression.fix.name=Compute constant value of ''{0}''
inspection.constant.expression.fix.name.with.value=Replace ''{0}'' with constant value ''{1}''
inspection.constant.expression.fix.family.name=Compute constant value
plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/style/ConstantExpressionInspection.java
+10 -4
View File
@@ -20,6 +20,9 @@ import org.jetbrains.annotations.NonNls;
import org.jetbrains.annotations.NotNull;
public class ConstantExpressionInspection extends AbstractBaseJavaLocalInspectionTool {
private static final int MAX_RESULT_LENGTH_TO_DISPLAY = 50;
private static final int MAX_EXPRESSION_LENGTH = 200;
@NotNull
@Override
public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
@@ -35,9 +38,9 @@ public class ConstantExpressionInspection extends AbstractBaseJavaLocalInspectio
}
void handle(PsiExpression expression) {
// intention disabled for long expressions because of performance issues on
// inspection disabled for long expressions because of performance issues on
// relatively common large string expressions.
if (expression.getTextLength() > 200) return;
if (expression.getTextLength() > MAX_EXPRESSION_LENGTH) return;
if (expression.getType() == null) return;
if (!PsiUtil.isConstantExpression(expression)) return;
final PsiElement parent = expression.getParent();
@@ -47,7 +50,10 @@ public class ConstantExpressionInspection extends AbstractBaseJavaLocalInspectio
if (value != null) {
String valueText = getValueText(value);
if (!expression.textMatches(valueText)) {
holder.registerProblem(expression, InspectionGadgetsBundle.message("inspection.constant.expression.display.name"),
String message = valueText.length() > MAX_RESULT_LENGTH_TO_DISPLAY ?
InspectionGadgetsBundle.message("inspection.constant.expression.display.name") :
InspectionGadgetsBundle.message("inspection.constant.expression.message", valueText);
holder.registerProblem(expression, message,
new ComputeConstantValueFix(expression, valueText));
}
}
@@ -71,7 +77,7 @@ public class ConstantExpressionInspection extends AbstractBaseJavaLocalInspectio
@NotNull
@Override
public String getName() {
if (myValueText.length() > 50) {
if (myValueText.length() > MAX_RESULT_LENGTH_TO_DISPLAY) {
return InspectionGadgetsBundle.message("inspection.constant.expression.fix.name", myText);
}
return InspectionGadgetsBundle.message("inspection.constant.expression.fix.name.with.value", myText, myValueText);