[ui] IJPL-161939 IJPL-191798 do not fail to close editor tab if an invalid focus target was specified

Fix broken toString after 08463bfc5a4e46a27bcec10d9b5ff9bfadf898e1

GitOrigin-RevId: abb44a585d5776fa5fbec4ff4edf8ba16c4bde11

platform/platform-api/src/com/intellij/ui/tabs/TabInfo.kt

@@ -297,7 +297,7 @@ class TabInfo(var component: JComponent) : Queryable, PlaceProvider {
     changeSupport.firePropertyChange(ALERT_STATUS, null, false)
   }
 
-  override fun toString(): String = LoadingNode.getText()
+  override fun toString(): String = text
 
   fun getAlertIcon(): AlertIcon = alertIcon ?: DEFAULT_ALERT_ICON
 

platform/platform-api/src/com/intellij/ui/tabs/impl/JBTabsImpl.kt

@@ -2464,10 +2464,13 @@ open class JBTabsImpl internal constructor(
     val toSelect = if (forcedSelectionTransfer == null) {
       getToSelectOnRemoveOf(info!!)
     }
-    else {
-      assert(visibleInfos.contains(forcedSelectionTransfer)) { "Cannot find tab for selection transfer, tab=$forcedSelectionTransfer" }
+    else if (visibleInfos.contains(forcedSelectionTransfer)) {
       forcedSelectionTransfer
     }
+    else {
+      LOG.error("Cannot find tab for selection transfer, tab=$forcedSelectionTransfer")
+      getToSelectOnRemoveOf(info!!)
+    }
 
     val result = ActionCallback()
     if (toSelect == null) {

platform/platform-impl/src/com/intellij/openapi/fileEditor/impl/EditorWindow.kt

@@ -730,8 +730,12 @@ class EditorWindow internal constructor(
     fileBeingClosed: VirtualFile,
     componentIndex: Int,
   ): TabInfo? {
-    tabBeingClosed.previousSelection?.let {
-      return it
+    val previousSelection = tabBeingClosed.previousSelection
+    if (previousSelection != null) {
+      // the WeakReference might reference an already closed tab
+      if (tabbedPane.editorTabs.getVisibleInfos().contains(previousSelection)) {
+        return previousSelection
+      }
     }
 
     val indexToSelect = computeIndexToSelect(fileBeingClosed = fileBeingClosed, fileIndex = componentIndex)