MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

IDEA-56168: duplicate id reference inspection marks good code as error

Browse Source
This commit is contained in:
Dmitry Avdeev
2010-07-19 15:06:03 +04:00
parent 4a48a177ca
commit 0aecb5f4b4
1 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
xml/impl/src/com/intellij/xml/util/XmlRefCountHolder.java
+11 -6
View File
@@ -17,6 +17,7 @@ package com.intellij.xml.util;
import com.intellij.codeInsight.daemon.impl.analysis.XmlHighlightVisitor;
import com.intellij.lang.Language;
import com.intellij.openapi.util.Condition;
import com.intellij.openapi.util.Key;
import com.intellij.openapi.util.Pair;
import com.intellij.openapi.util.UserDataCache;
@@ -30,6 +31,7 @@ import com.intellij.psi.util.CachedValueProvider;
import com.intellij.psi.util.CachedValuesManager;
import com.intellij.psi.util.PsiTreeUtil;
import com.intellij.psi.xml.*;
import com.intellij.util.containers.ContainerUtil;
import com.intellij.xml.XmlAttributeDescriptor;
import com.intellij.xml.XmlElementDescriptor;
import org.jetbrains.annotations.NotNull;
@@ -97,14 +99,17 @@ public class XmlRefCountHolder {
if (list == null) {
list = new ArrayList<Pair<XmlAttributeValue, Boolean>>();
myId2AttributeListMap.put(id, list);
} else if (!soft) {
}
else if (!soft) {
// mark as duplicate
if (list.size() == 1) {
if (!list.get(0).second.booleanValue()) {
myPossiblyDuplicateIds.add(list.get(0).first);
myPossiblyDuplicateIds.add(attributeValue);
Pair<XmlAttributeValue, Boolean> notSoft = ContainerUtil.find(list, new Condition<Pair<XmlAttributeValue, Boolean>>() {
@Override
public boolean value(Pair<XmlAttributeValue, Boolean> xmlAttributeValueBooleanPair) {
return !xmlAttributeValueBooleanPair.second;
}
} else {
});
if (notSoft != null) {
myPossiblyDuplicateIds.add(notSoft.first);
myPossiblyDuplicateIds.add(attributeValue);
}
}