MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-10-01 11:20:44 +07:00
Code Issues Packages Projects Releases Wiki Activity

IJPL-159657 Fix performance issue with UrlFilter

Browse Source 
After b77168e2 (related to KTIJ-29334), Url filter started using url filter each time, even if file url is present. That makes the performance test of this filter with only file urls slower. Here I've added some checks before using an expensive URL filter

^IJPL-159657 Fixed

GitOrigin-RevId: 30651ed33375244feb9e34173c6162387241360c
This commit is contained in:
Aleksei.Cherepanov
2024-08-06 13:25:09 +00:00
committed by intellij-monorepo-bot
parent 49f724bc6f
commit 0a5b243b28
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/execution-impl/src/com/intellij/execution/filters/UrlFilter.java
+11 -1
View File
@@ -59,7 +59,9 @@ public class UrlFilter implements Filter, DumbAware {
resultList.addAll(findMatchingItems(line, URLUtil.FILE_URL_PATTERN, textStartOffset));
}
resultList.addAll(findMatchingItems(line, URLUtil.URL_PATTERN, textStartOffset));
if (isPotentialUrl(line)) {
resultList.addAll(findMatchingItems(line, URLUtil.URL_PATTERN, textStartOffset));
}
if (resultList.isEmpty()) {
return null;
@@ -73,6 +75,14 @@ public class UrlFilter implements Filter, DumbAware {
return new Result(resultList);
}
private static boolean isPotentialUrl(String input) {
return input.contains("www") ||
input.contains("http") ||
input.contains("mailto") ||
input.contains("ftp") ||
input.contains("news");
}
protected @NotNull HyperlinkInfo buildHyperlinkInfo(@NotNull String url) {
HyperlinkInfo fileHyperlinkInfo = buildFileHyperlinkInfo(url);
return fileHyperlinkInfo != null ? fileHyperlinkInfo : new OpenUrlHyperlinkInfo(url);