MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

UnnecessaryTemporaryOnConversionFrom/ToString fix: do not apply when no arguments

Browse Source 
Fixes EA-115362 - AIOOBE: UnnecessaryTemporaryOnConversionToStringInspection$UnnecessaryTemporaryObjectFix.doFix
This commit is contained in:
Tagir Valeev
2018-01-29 10:13:28 +07:00
parent 2f66f59b15
commit 09e5f061ac
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/performance/UnnecessaryTemporaryOnConversionFromStringInspection.java
+4 -4
View File
@@ -151,12 +151,12 @@ public class UnnecessaryTemporaryOnConversionFromStringInspection
@Override
public void doFix(Project project, ProblemDescriptor descriptor) {
final PsiMethodCallExpression expression = (PsiMethodCallExpression)descriptor.getPsiElement();
PsiExpression[] args = expression.getArgumentList().getExpressions();
if (args.length == 0) return;
final String newExpression = calculateReplacementExpression(expression);
if (newExpression == null) {
return;
}
if (newExpression == null) return;
CommentTracker commentTracker = new CommentTracker();
commentTracker.markUnchanged(expression.getArgumentList().getExpressions()[0]);
commentTracker.markUnchanged(args[0]);
PsiReplacementUtil.replaceExpression(expression, newExpression, commentTracker);
}
}
plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/performance/UnnecessaryTemporaryOnConversionToStringInspection.java
+4 -4
View File
@@ -122,12 +122,12 @@ public class UnnecessaryTemporaryOnConversionToStringInspection
@Override
public void doFix(Project project, ProblemDescriptor descriptor) {
final PsiMethodCallExpression expression = (PsiMethodCallExpression)descriptor.getPsiElement();
PsiExpression[] args = expression.getArgumentList().getExpressions();
if (args.length == 0) return;
final String newExpression = calculateReplacementExpression(expression);
if (newExpression == null) {
return;
}
if (newExpression == null) return;
CommentTracker commentTracker = new CommentTracker();
commentTracker.markUnchanged(expression.getArgumentList().getExpressions()[0]);
commentTracker.markUnchanged(args[0]);
PsiReplacementUtil.replaceExpression(expression, newExpression, commentTracker);
}
}