MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

PreferMostUsedWeigher should not affect completion sorting if generated element is suggested

Browse Source
This commit is contained in:
Dmitry Batkovich
2017-04-14 12:56:44 +03:00
parent ba799ce032
commit 0931e87ebd
1 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-impl/src/com/intellij/codeInsight/completion/PreferMostUsedWeigher.java
+10 -9
View File
@@ -56,16 +56,17 @@ class PreferMostUsedWeigher extends LookupElementWeigher {
if (!(psi instanceof PsiMember)) {
return null;
}
else {
if (OBJECT_METHOD_PATTERN.accepts(psi)) {
return null;
}
if (looksLikeHelperMethodOrConst(psi)) {
return null;
}
final Integer occurrenceCount = myCompilerReferenceService.getCompileTimeOccurrenceCount(psi, myConstructorSuggestion);
return occurrenceCount == null ? null : - occurrenceCount;
if (element.getUserData(JavaGenerateMemberCompletionContributor.GENERATE_ELEMENT) != null) {
return null;
}
if (OBJECT_METHOD_PATTERN.accepts(psi)) {
return null;
}
if (looksLikeHelperMethodOrConst(psi)) {
return null;
}
final Integer occurrenceCount = myCompilerReferenceService.getCompileTimeOccurrenceCount(psi, myConstructorSuggestion);
return occurrenceCount == null ? null : -occurrenceCount;
}
//Objects.requireNonNull is an example