MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

resource bundle manager reduced count of getUrl() call while listening psi changes

Browse Source
This commit is contained in:
Dmitry Batkovich
2014-10-23 14:10:47 +04:00
parent cb30225546
commit 084c0a3e94
1 changed files with 24 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/properties/properties-psi-impl/src/com/intellij/lang/properties/ResourceBundleManager.java
+24 -9
View File
@@ -20,7 +20,9 @@ import com.intellij.openapi.application.ApplicationManager;
import com.intellij.openapi.components.*;
import com.intellij.openapi.diagnostic.Logger;
import com.intellij.openapi.project.Project;
import com.intellij.openapi.util.NotNullLazyValue;
import com.intellij.openapi.util.NullableComputable;
import com.intellij.openapi.util.Pair;
import com.intellij.openapi.util.text.StringUtil;
import com.intellij.openapi.vfs.VirtualFile;
import com.intellij.psi.*;
@@ -65,18 +67,31 @@ public class ResourceBundleManager implements PersistentStateComponent<ResourceB
if (oldParentUrl == null || newParentUrl == null) {
return;
}
final String newUrl = propertiesFile.getVirtualFile().getUrl();
final String oldUrl = oldParentUrl + newUrl.substring(newParentUrl.length());
if (myState.getDissociatedFiles().remove(oldUrl)) {
myState.getDissociatedFiles().add(newUrl);
}
for (CustomResourceBundleState customResourceBundleState : myState.getCustomResourceBundles()) {
if (customResourceBundleState.getFileUrls().remove(oldUrl)) {
customResourceBundleState.getFileUrls().add(newUrl);
break;
final NotNullLazyValue<Pair<String, String>> oldAndNewUrls = new NotNullLazyValue<Pair<String, String>>() {
@NotNull
@Override
protected Pair<String, String> compute() {
final String newUrl = propertiesFile.getVirtualFile().getUrl();
return Pair.create(oldParentUrl + newUrl.substring(newParentUrl.length()), newUrl);
}
};
if (!myState.getDissociatedFiles().isEmpty()) {
if (myState.getDissociatedFiles().remove(oldAndNewUrls.getValue().getFirst())) {
myState.getDissociatedFiles().add(oldAndNewUrls.getValue().getSecond());
}
}
if (!myState.getCustomResourceBundles().isEmpty()) {
for (CustomResourceBundleState customResourceBundleState : myState.getCustomResourceBundles()) {
if (customResourceBundleState.getFileUrls().remove(oldAndNewUrls.getValue().getFirst())) {
customResourceBundleState.getFileUrls().add(oldAndNewUrls.getValue().getSecond());
break;
}
}
}
}
@Nullable