MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

don't create SmartList if we can use getContent directly

Browse Source
This commit is contained in:
Vladimir Krivosheev
2014-11-10 12:21:18 +01:00
parent e8e996f5c2
commit 082d7f40d2
1 changed files with 19 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/util/src/com/intellij/util/xmlb/TagBinding.java
+19 -8
View File
@@ -58,13 +58,19 @@ class TagBinding extends BasePrimitiveBinding implements MultiNodeBinding {
@Override
public Object deserializeList(Object context, @NotNull List<?> nodes) {
boolean isBeanBinding = myBinding instanceof BeanBinding;
String name = ((Element)nodes.get(0)).getName();
List<? extends Content> children = new SmartList<Content>();
for (Object node : nodes) {
Element element = (Element)node;
assert element.getName().equals(name);
//noinspection unchecked
children.addAll(((List)(isBeanBinding ? element.getChildren() : XmlSerializerImpl.getFilteredContent(element))));
List<? extends Content> children;
if (nodes.size() == 1) {
children = getContents(isBeanBinding, (Element)nodes.get(0));
}
else {
String name = ((Element)nodes.get(0)).getName();
children = new SmartList<Content>();
for (Object node : nodes) {
Element element = (Element)node;
assert element.getName().equals(name);
//noinspection unchecked
children.addAll(((List)getContents(isBeanBinding, element)));
}
}
return deserialize(context, children, isBeanBinding);
}
@@ -79,7 +85,7 @@ class TagBinding extends BasePrimitiveBinding implements MultiNodeBinding {
public Object deserialize(Object context, @NotNull Object node) {
boolean isBeanBinding = myBinding instanceof BeanBinding;
Element element = (Element)node;
return deserialize(context, isBeanBinding ? element.getChildren() : XmlSerializerImpl.getFilteredContent(element), isBeanBinding);
return deserialize(context, getContents(isBeanBinding, element), isBeanBinding);
}
private Object deserialize(Object o, List<? extends Content> children, boolean isBeanBinding) {
@@ -102,4 +108,9 @@ class TagBinding extends BasePrimitiveBinding implements MultiNodeBinding {
public boolean isBoundTo(Object node) {
return node instanceof Element && ((Element)node).getName().equals(myName);
}
@NotNull
private static List<? extends Content> getContents(boolean isBeanBinding, Element element) {
return isBeanBinding ? element.getChildren() : XmlSerializerImpl.getFilteredContent(element);
}
}