MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

make IG test light

Browse Source
This commit is contained in:
Bas Leijdekkers
2014-09-30 19:07:01 +02:00
parent 7d3e5e591d
commit 075fb378d2
3 changed files with 19 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/InspectionGadgets/test/com/siyeh/igtest/style/unclear_binary_expression/UnclearBinaryExpression.java
+9 -9
View File
@@ -21,17 +21,17 @@ import java.util.List;
public class UnclearBinaryExpression {
void foo() {
boolean b2 = "asdf" + "asdf" instanceof String;
int i = true ? 1 + 2 * 7 : 2;
boolean b2 = <warning descr="Expression could use clarifying parentheses">"asdf" + "asdf" instanceof String</warning>;
int i = <warning descr="Expression could use clarifying parentheses">true ? 1 + 2 * 7 : 2</warning>;
boolean j = true ? false : true;
System.out.println(3 + 1 + 2 * 9 * 8 + 1);
System.out.println(<warning descr="Expression could use clarifying parentheses">3 + 1 + 2 * 9 * 8 + 1</warning>);
}
boolean bar(String name, Condition condition, Operation operation) {
List<String> values = new ArrayList();
return name.equals(condition.name)
return <warning descr="Expression could use clarifying parentheses">name.equals(condition.name)
&& values.contains(condition.value) == (operation == Operation.equals)
&& name instanceof String;
&& name instanceof String</warning>;
}
class Condition {
@@ -43,12 +43,12 @@ public class UnclearBinaryExpression {
}
void more(Object o) {
String s = true? false ? "one" : "two" : "three";
boolean b = true ? o instanceof String : false;
String s = <warning descr="Expression could use clarifying parentheses">true? false ? "one" : "two" : "three"</warning>;
boolean b = <warning descr="Expression could use clarifying parentheses">true ? o instanceof String : false</warning>;
}
void more(int i) {
i = i += i = 1;
<warning descr="Expression could use clarifying parentheses">i = i += i = 1</warning>;
}
void noMore() {
@@ -57,6 +57,6 @@ public class UnclearBinaryExpression {
}
int incomplete(String s) {
return s == null ?
return s == null ?<EOLError descr="Expression expected"></EOLError><EOLError descr="';' expected"></EOLError>
}
}
plugins/InspectionGadgets/test/com/siyeh/igtest/style/unclear_binary_expression/expected.xml
-51
View File
@@ -1,51 +0,0 @@
<?xml version="1.0" encoding="UTF-8"?>
<problems>
<problem>
<file>UnclearBinaryExpression.java</file>
<line>24</line>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Unclear binary expression</problem_class>
<description>Expression could use clarifying parentheses #loc</description>
</problem>
<problem>
<file>UnclearBinaryExpression.java</file>
<line>25</line>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Unclear binary expression</problem_class>
<description>Expression could use clarifying parentheses #loc</description>
</problem>
<problem>
<file>UnclearBinaryExpression.java</file>
<line>27</line>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Unclear binary expression</problem_class>
<description>Expression could use clarifying parentheses #loc</description>
</problem>
<problem>
<file>UnclearBinaryExpression.java</file>
<line>32</line>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Unclear binary expression</problem_class>
<description>Expression could use clarifying parentheses #loc</description>
</problem>
<problem>
<file>UnclearBinaryExpression.java</file>
<line>46</line>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Unclear expression</problem_class>
<description>Expression could use clarifying parentheses #loc</description>
</problem>
<problem>
<file>UnclearBinaryExpression.java</file>
<line>47</line>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Unclear expression</problem_class>
<description>Expression could use clarifying parentheses #loc</description>
</problem>
<problem>
<file>UnclearBinaryExpression.java</file>
<line>51</line>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Unclear expression</problem_class>
<description>Expression could use clarifying parentheses #loc</description>
</problem>
</problems>
plugins/InspectionGadgets/testsrc/com/siyeh/ig/style/UnclearBinaryExpressionInspectionTest.java
+10 -5
View File
@@ -1,11 +1,16 @@
package com.siyeh.ig.style;
import com.siyeh.ig.IGInspectionTestCase;
import com.intellij.codeInspection.InspectionProfileEntry;
import com.siyeh.ig.LightInspectionTestCase;
import org.jetbrains.annotations.Nullable;
public class UnclearBinaryExpressionInspectionTest extends IGInspectionTestCase {
public class UnclearBinaryExpressionInspectionTest extends LightInspectionTestCase {
public void test() throws Exception {
doTest("com/siyeh/igtest/style/unclear_binary_expression",
new UnclearBinaryExpressionInspection());
public void testUnclearBinaryExpression() { doTest(); }
@Nullable
@Override
protected InspectionProfileEntry getInspection() {
return new UnclearBinaryExpressionInspection();
}
}