cleanup static final constants

This commit is contained in:
Alexey Kudravtsev
2013-09-11 13:29:27 +04:00
parent c2f615315e
commit 06b1744f9d
2 changed files with 4 additions and 6 deletions
@@ -46,7 +46,6 @@ import java.util.regex.Pattern;
public class DependsOnGroupsInspection extends BaseJavaLocalInspectionTool {
private static final Logger LOGGER = Logger.getInstance("TestNG Runner");
private static final Pattern PATTERN = Pattern.compile("\"([a-zA-Z0-9_\\-\\(\\)]*)\"");
private static final ProblemDescriptor[] EMPTY = new ProblemDescriptor[0];
public JDOMExternalizableStringList groups = new JDOMExternalizableStringList();
@NonNls public static String SHORT_NAME = "groupsTestNG";
@@ -98,7 +97,7 @@ public class DependsOnGroupsInspection extends BaseJavaLocalInspectionTool {
if (!psiClass.getContainingFile().isWritable()) return null;
PsiAnnotation[] annotations = TestNGUtil.getTestNGAnnotations(psiClass);
if (annotations.length == 0) return EMPTY;
if (annotations.length == 0) return ProblemDescriptor.EMPTY_ARRAY;
List<ProblemDescriptor> problemDescriptors = new ArrayList<ProblemDescriptor>();
for (PsiAnnotation annotation : annotations) {
@@ -36,9 +36,8 @@ public class DependsOnMethodInspection extends BaseJavaLocalInspectionTool
{
private static final Logger LOGGER = Logger.getInstance("TestNG Runner");
private static final Pattern PATTERN = Pattern.compile("\"([a-zA-Z1-9_\\(\\)]*)\"");
private static final ProblemDescriptor[] EMPTY = new ProblemDescriptor[0];
@NotNull
@NotNull
@Override
public String getGroupDisplayName() {
return "TestNG";
@@ -69,7 +68,7 @@ public class DependsOnMethodInspection extends BaseJavaLocalInspectionTool
if (!psiClass.getContainingFile().isWritable()) return null;
PsiAnnotation[] annotations = TestNGUtil.getTestNGAnnotations(psiClass);
if(annotations.length == 0) return EMPTY;
if(annotations.length == 0) return ProblemDescriptor.EMPTY_ARRAY;
List<ProblemDescriptor> problemDescriptors = new ArrayList<ProblemDescriptor>();
for (PsiAnnotation annotation : annotations) {