MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

PY-18203 Redundant parentheses quick fix produces syntactically incorrect code for tuples

Browse Source 
If parentheses expression contains binary expression where left and right are parentheses expressions too, we check if left and right contain tuples
This commit is contained in:
Valentina Kiryushkina
2016-01-14 17:46:28 +03:00
parent 1e2e2f77d3
commit 05253be08a
4 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/src/com/jetbrains/python/inspections/quickfix/RedundantParenthesesQuickFix.java
+2 -1
View File
@@ -72,7 +72,8 @@ public class RedundantParenthesesQuickFix implements LocalQuickFix {
right instanceof PyParenthesizedExpression) {
PyExpression leftContained = ((PyParenthesizedExpression)left).getContainedExpression();
PyExpression rightContained = ((PyParenthesizedExpression)right).getContainedExpression();
if (leftContained != null && rightContained != null) {
if (leftContained != null && rightContained != null &&
!(leftContained instanceof PyTupleExpression) && !(rightContained instanceof PyTupleExpression)) {
left.replace(leftContained);
right.replace(rightContained);
return true;
python/testData/inspections/RedundantParenthesesInTuples.py
+1
View File
@@ -0,0 +1 @@
print("%d%s%s" % (((1,) + <caret>("", ""))))
python/testData/inspections/RedundantParenthesesInTuples_after.py
+1
View File
@@ -0,0 +1 @@
print("%d%s%s" % ((1,) + ("", "")))
python/testSrc/com/jetbrains/python/PyQuickFixTest.java
+5
View File
@@ -244,6 +244,11 @@ public class PyQuickFixTest extends PyTestCase {
doInspectionTest(PyRedundantParenthesesInspection.class, PyBundle.message("QFIX.redundant.parentheses"), true, true);
}
// PY-18203
public void testRedundantParenthesesInTuples() {
doInspectionTest(PyRedundantParenthesesInspection.class, PyBundle.message("QFIX.redundant.parentheses"), true, true);
}
// PY-1020
public void testChainedComparisons() {
doInspectionTest(PyChainedComparisonsInspection.class, PyBundle.message("QFIX.chained.comparison"), true, true);