Reuse the constant for "idea.required.plugins.id" instead of hardcoded string values

This commit is contained in:
Victor Alenkov
2018-10-16 21:34:23 -07:00
committed by Kirill Likhodedov
parent a4180a874b
commit 04aa2fbda7
2 changed files with 5 additions and 2 deletions
@@ -50,6 +50,7 @@ import java.util.concurrent.CopyOnWriteArrayList;
import java.util.zip.ZipEntry;
import java.util.zip.ZipFile;
import static com.intellij.openapi.application.JetBrainsProtocolHandler.REQUIRED_PLUGINS_KEY;
import static com.intellij.util.ObjectUtils.notNull;
import static java.util.Collections.singletonList;
@@ -134,7 +135,7 @@ public class PluginManagerCore {
public static void loadDisabledPlugins(@NotNull String configPath, @NotNull Collection<String> disabledPlugins) {
File file = new File(configPath, DISABLED_PLUGINS_FILENAME);
if (file.isFile()) {
List<String> requiredPlugins = StringUtil.split(System.getProperty("idea.required.plugins.id", ""), ",");
List<String> requiredPlugins = StringUtil.split(System.getProperty(REQUIRED_PLUGINS_KEY, ""), ",");
try {
boolean updateDisablePluginsList = false;
try (BufferedReader reader = new BufferedReader(new FileReader(file))) {
@@ -47,11 +47,13 @@ import java.util.EnumSet;
import java.util.List;
import java.util.concurrent.ForkJoinPool;
import static com.intellij.openapi.application.JetBrainsProtocolHandler.REQUIRED_PLUGINS_KEY;
public class IdeaApplication {
public static final String IDEA_IS_INTERNAL_PROPERTY = "idea.is.internal";
public static final String IDEA_IS_UNIT_TEST = "idea.is.unit.test";
private static final String[] SAFE_JAVA_ENV_PARAMETERS = {"idea.required.plugins.id"};
private static final String[] SAFE_JAVA_ENV_PARAMETERS = {REQUIRED_PLUGINS_KEY};
private static final Logger LOG = Logger.getInstance("#com.intellij.idea.IdeaApplication");