IDEA-212024 Replace adjacent literal with selected completion option when pressing Tab

GitOrigin-RevId: bc5edd0fb01781ff6b6afab151550bdbf152c6c6

java/java-impl/src/com/intellij/codeInsight/completion/JavaCompletionContributor.java

@@ -24,6 +24,7 @@ import com.intellij.openapi.project.Project;
 import com.intellij.openapi.roots.ModuleRootManager;
 import com.intellij.openapi.util.Comparing;
 import com.intellij.openapi.util.Condition;
+import com.intellij.openapi.util.TextRange;
 import com.intellij.openapi.util.text.StringUtil;
 import com.intellij.openapi.vfs.VirtualFile;
 import com.intellij.patterns.*;
@@ -807,6 +808,15 @@ public class JavaCompletionContributor extends CompletionContributor {
       if (dummyIdentifier != null) {
         context.setDummyIdentifier(dummyIdentifier);
       }
+
+      PsiLiteralExpression literal =
+        PsiTreeUtil.findElementOfClassAtOffset(file, context.getStartOffset(), PsiLiteralExpression.class, false);
+      if (literal != null) {
+        TextRange range = literal.getTextRange();
+        if (range.getStartOffset() == context.getStartOffset()) {
+          context.setReplacementOffset(range.getEndOffset());
+        }
+      }
     }
   }
 

java/java-tests/testData/codeInsight/completion/normal/ReplaceStringLiteral.java

@@ -0,0 +1,7 @@
+class MyClass {
+  {
+    String s = t<caret>"literal";
+
+  }
+
+}

java/java-tests/testData/codeInsight/completion/normal/ReplaceStringLiteral_After.java

@@ -0,0 +1,7 @@
+class MyClass {
+  {
+    String s = toString()<caret>;
+
+  }
+
+}

java/java-tests/testSrc/com/intellij/java/codeInsight/completion/TabCompletionTest.java

@@ -30,8 +30,8 @@ public class TabCompletionTest extends LightFixtureCompletionTestCase {
   }
 
   public void testReplaceThisWithSuper() {
-    configureByFile("ReplaceThisWithSuper.java");
-    checkResultByFile("ReplaceThisWithSuper_After.java");
+    configureByTestName();
+    checkResultJava();
   }
 
   public void testTabInXml() {
@@ -48,14 +48,23 @@ public class TabCompletionTest extends LightFixtureCompletionTestCase {
     myFixture.configureByFile("MethodCallBeforeAnnotation.java");
     myFixture.completeBasic();
     myFixture.type("tos\t");
-    checkResultByFile("MethodCallBeforeAnnotation_After.java");
+    checkResultJava();
   }
 
   public void testMethodCallBeforeAnnotation2() {
     myFixture.configureByFile("MethodCallBeforeAnnotation2.java");
     myFixture.completeBasic();
     myFixture.type("tos\t");
-    checkResultByFile("MethodCallBeforeAnnotation2_After.java");
+    checkResultJava();
+  }
+
+  public void testReplaceStringLiteral() {
+    configureByTestName();
+    checkResultJava();
+  }
+
+  private void checkResultJava() {
+    checkResultByFile(getTestName(false) + "_After.java");
   }
 
   @Override