remove legacy Internal_SetDirtyInEditorMode

This commit is contained in:
BlackMATov
2021-01-04 00:32:30 +07:00
parent cadefb411c
commit 2e2a1d7722
6 changed files with 11 additions and 46 deletions

View File

@@ -9,18 +9,6 @@ namespace IsoTools.Internal {
public abstract class IsoBehaviour : MonoBehaviour {
static List<IsoWorld> _tempWorlds = new List<IsoWorld>();
// ---------------------------------------------------------------------
//
// Internal
//
// ---------------------------------------------------------------------
public void Internal_SetDirtyInEditorMode() {
#if UNITY_EDITOR && !UNITY_2019_1_OR_NEWER
EditorUtility.SetDirty(this);
#endif
}
// ---------------------------------------------------------------------
//
// Protected

View File

@@ -208,7 +208,7 @@ namespace IsoTools.Internal {
UnregisterIsoObjectParent(iso_object);
}
public bool OnMarkDirtyIsoObject(IsoObject iso_object) {
public void OnMarkDirtyIsoObject(IsoObject iso_object) {
if ( iso_object.Internal.QTItem != null ) {
iso_object.Internal.QTItem = _quadTree.MoveItem(
iso_object.Internal.QTBounds,
@@ -219,11 +219,7 @@ namespace IsoTools.Internal {
iso_object);
}
_minIsoXY = IsoUtils.Vec2Min(_minIsoXY, iso_object.position);
if ( !iso_object.Internal.Dirty ) {
iso_object.Internal.Dirty = true;
return true;
}
return false;
iso_object.Internal.Dirty = true;
}
public void OnDrawGizmos(IsoWorld iso_world) {

View File

@@ -31,8 +31,7 @@ namespace IsoTools.Internal {
}
}
public bool OnMarkDirtyIsoObject(IsoObject iso_object) {
return false;
public void OnMarkDirtyIsoObject(IsoObject iso_object) {
}
public void OnDrawGizmos(IsoWorld iso_world) {
@@ -44,7 +43,7 @@ namespace IsoTools.Internal {
//
// ---------------------------------------------------------------------
public bool StepSortingAction(IsoWorld iso_world, IsoScreenSolver screen_solver) {
public void StepSortingAction(IsoWorld iso_world, IsoScreenSolver screen_solver) {
Profiler.BeginSample("IsoSortingSolver.ResolveVisibles");
var dirty = ResolveVisibles(screen_solver);
Profiler.EndSample();
@@ -53,7 +52,6 @@ namespace IsoTools.Internal {
PlaceVisibles(iso_world, screen_solver);
Profiler.EndSample();
}
return dirty;
}
public void Clear() {

View File

@@ -26,8 +26,8 @@ namespace IsoTools.Internal {
_impl.OnRemoveIsoObject(iso_object);
}
public bool OnMarkDirtyIsoObject(IsoObject iso_object) {
return _impl.OnMarkDirtyIsoObject(iso_object);
public void OnMarkDirtyIsoObject(IsoObject iso_object) {
_impl.OnMarkDirtyIsoObject(iso_object);
}
public void OnDrawGizmos(IsoWorld iso_world) {
@@ -46,7 +46,7 @@ namespace IsoTools.Internal {
class IsoWarningSolverImpl {
public virtual void OnAddIsoObject(IsoObject iso_object) {}
public virtual void OnRemoveIsoObject(IsoObject iso_object) {}
public virtual bool OnMarkDirtyIsoObject(IsoObject iso_object) { return false; }
public virtual void OnMarkDirtyIsoObject(IsoObject iso_object) {}
public virtual void OnDrawGizmos(IsoWorld iso_world) {}
public virtual void StepSortingAction(IsoWorld iso_world) {}
public virtual void Clear() {}

View File

@@ -269,7 +269,6 @@ namespace IsoTools {
if ( iso_world ) {
iso_world.Internal_MarkDirty(this);
}
Internal_SetDirtyInEditorMode();
}
// ---------------------------------------------------------------------

View File

@@ -432,15 +432,9 @@ namespace IsoTools {
// ---------------------------------------------------------------------
public void Internal_MarkDirty(IsoObject iso_object) {
if ( _screenSolver.OnMarkDirtyIsoObject(iso_object) ) {
Internal_SetDirtyInEditorMode();
}
if ( _sortingSolver.OnMarkDirtyIsoObject(iso_object) ) {
Internal_SetDirtyInEditorMode();
}
if ( _warningSolver.OnMarkDirtyIsoObject(iso_object) ) {
Internal_SetDirtyInEditorMode();
}
_screenSolver.OnMarkDirtyIsoObject(iso_object);
_sortingSolver.OnMarkDirtyIsoObject(iso_object);
_warningSolver.OnMarkDirtyIsoObject(iso_object);
}
public bool Internal_IsVisible(IsoObject iso_object) {
@@ -474,7 +468,6 @@ namespace IsoTools {
void ChangeSortingProperty() {
UpdateIsoMatrix();
FixIsoObjectTransforms();
Internal_SetDirtyInEditorMode();
}
void ChangePhysicsProperty() {
@@ -488,9 +481,7 @@ namespace IsoTools {
void StepSortingProcess() {
_screenSolver.StepSortingAction(this);
if ( _sortingSolver.StepSortingAction(this, _screenSolver) ) {
Internal_SetDirtyInEditorMode();
}
_sortingSolver.StepSortingAction(this, _screenSolver);
_warningSolver.StepSortingAction(this);
}
@@ -590,13 +581,6 @@ namespace IsoTools {
isShowQuadTree = _showQuadTree;
}
void OnRenderObject() {
var camera = Camera.current;
if ( camera && camera.name == "SceneCamera" ) {
Internal_SetDirtyInEditorMode();
}
}
void OnDrawGizmos() {
_screenSolver.OnDrawGizmos(this);
_sortingSolver.OnDrawGizmos(this);