Files
openide/java/java-tests/testData/inspection/dataFlow/fixture/StreamInlining.java
T
Tagir Valeev 80e63e20fc DFA: support partial streams and ::isInstance method reference
Fixes:
IDEA-182519 Support non-terminated Stream API chains in data flow
IDEA-182520 Support Xyz.class::isInstance in stream/optional chains
2017-11-22 14:23:00 +07:00

176 lines
8.4 KiB
Java

import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
import java.util.*;
import java.util.stream.*;
public class StreamInlining {
void testNulls(List<String> list) {
list.stream().filter(<warning descr="Passing 'null' argument to parameter annotated as @NotNull">null</warning>).forEach(System.out::println);
list.stream().map(<warning descr="Passing 'null' argument to parameter annotated as @NotNull">null</warning>).forEach(System.out::println);
list.stream().flatMap(<warning descr="Passing 'null' argument to parameter annotated as @NotNull">null</warning>).forEach(System.out::println);
list.stream().filter(x -> x != null).forEach(<warning descr="Passing 'null' argument to parameter annotated as @NotNull">null</warning>);
List<String> l = null;
l.<warning descr="Method invocation 'stream' may produce 'java.lang.NullPointerException'">stream</warning>().count();
int[] arr = null;
Arrays.stream(<warning descr="Argument 'arr' might be null">arr</warning>).count();
Stream<String> stream = null;
stream.<warning descr="Method invocation 'filter' may produce 'java.lang.NullPointerException'">filter</warning>(x -> x != null).forEach(System.out::println);
}
void testMethodRef(List<String> list, int[] data) {
if(<warning descr="Condition 'list.stream().map(String::new).anyMatch(x -> x == null)' is always 'false'">list.stream().map(String::new).anyMatch(x -> <warning descr="Condition 'x == null' is always 'false'">x == null</warning>)</warning>) {
System.out.println("never");
}
if(<warning descr="Condition 'Arrays.stream(data).mapToObj(int[]::new).anyMatch(x -> x == null)' is always 'false'">Arrays.stream(data).mapToObj(int[]::new).anyMatch(x -> <warning descr="Condition 'x == null' is always 'false'">x == null</warning>)</warning>) {
System.out.println("never");
}
list.stream().filter(Objects::isNull).map(<warning descr="Method reference invocation 'String::trim' may produce 'java.lang.NullPointerException'">String::trim</warning>).forEach(System.out::println);
if(<warning descr="Condition 'list.stream().filter(Objects::nonNull).anyMatch(x -> x == null)' is always 'false'">list.stream().filter(Objects::nonNull).anyMatch(x -> <warning descr="Condition 'x == null' is always 'false'">x == null</warning>)</warning>) {
System.out.println("never");
}
list.stream().map(Integer::valueOf).filter(<warning descr="Method reference result is always 'true'">Objects::nonNull</warning>).forEach(System.out::println);
}
void filterDistinctLimitSkipFilter(List<String> list) {
list.stream().filter(x -> x == null).distinct().limit(10).skip(1).filter(x -> <warning descr="Condition 'x != null' is always 'false'">x != null</warning>).forEach(System.out::println);
}
static class Holder {
Object obj;
}
int hash(List<Holder> holders) {
return holders.stream().filter(h -> h.obj == null).mapToInt(h -> h.obj.<warning descr="Method invocation 'hashCode' may produce 'java.lang.NullPointerException'">hashCode</warning>()).sum();
}
void test2(int[] array) {
IntStream.of(array).filter(x -> x < 5)
.filter(x -> <warning descr="Condition 'x > 7' is always 'false'">x > 7</warning>)
.forEach(value -> System.out.println(value));
}
void testInstanceof(List<?> objects) {
objects.stream()
.filter(x -> x instanceof String)
.filter(x -> <warning descr="Condition 'x instanceof Number' is always 'false'">x instanceof Number</warning>)
.forEach(System.out::println);
}
void testIsInstanceIncomplete(List<?> objects) {
IntStream is = objects.stream()
.filter(String.class::isInstance)
.mapToInt(x -> (<warning descr="Casting 'x' to 'Integer' may produce 'java.lang.ClassCastException'">Integer</warning>)x);
objects.stream()
.filter(String.class::isInstance)
.filter(<warning descr="Method reference result is always 'false'">Number.class::isInstance</warning>);
objects.stream()
.filter(x -> x instanceof String)
.filter(<warning descr="Method reference result is always 'false'">Number.class::isInstance</warning>);
objects.stream()
.filter(String.class::isInstance)
.filter(<warning descr="Method reference result is always 'true'">String.class::isInstance</warning>);
}
Stream<String> testInstanceOfMap(List<?> objects) {
return objects.stream().filter(it -> it instanceof String)
.map(entry -> {
if (<warning descr="Condition 'entry instanceof String' is always 'true'">entry instanceof String</warning>) {
return (String)entry;
}
return null;
})
.filter(<warning descr="Method reference result is always 'true'">Objects::nonNull</warning>);
}
void test(Stream<String> stream, Optional<String> opt) {
stream.filter(<warning descr="Condition 'String.class::isInstance' is redundant and can be replaced with '!= null'">String.class::isInstance</warning>).forEach(System.out::println);
opt.filter(<warning descr="Method reference result is always 'true'">String.class::isInstance</warning>).ifPresent(System.out::println);
}
// IDEA-152871
static class A {
void improved(String[] arr) {
Arrays.stream(arr).map(s -> s.isEmpty() ? s : null)
.map(s1 -> some(<warning descr="Argument 's1' might be null">s1</warning>))
.forEach(s -> System.out.println(s));
}
void improvedMethodRef(String[] arr) {
Arrays.stream(arr).map(s -> s.isEmpty() ? s : null)
.map(<warning descr="Method reference argument might be null">A::some</warning>)
.forEach(s -> System.out.println(s));
}
public static String some(@NotNull String s) {
return s;
}
}
// IDEA-169280
void f(List<String> l) {
if(l.stream().filter(s -> s != null).allMatch(s -> <warning descr="Condition 's != null' is always 'true'">s != null</warning> && s.startsWith("A"))) {
System.out.println("ok");
}
}
void boxed(IntStream is) {
is.boxed().filter(x -> <warning descr="Condition 'x != null' is always 'true'">x != null</warning>).forEach(s -> System.out.println(s));
}
boolean flatMap(List<String> list, List<List<String>> ll) {
System.out.println(ll.stream().flatMap(l -> l.stream()).count());
return list.stream().map(s -> s.isEmpty() ? null : s)
.flatMap(s -> Stream.of(s, s.<warning descr="Method invocation 'trim' may produce 'java.lang.NullPointerException'">trim</warning>()).filter(r -> r != null))
.anyMatch(x -> <warning descr="Condition 'x == null' is always 'false'">x == null</warning>);
}
String blockLambda(List<String> list) {
return list == null ? "" : list.stream().map(s -> {
return s.equals("abc") ? null : s;
}).findFirst().orElse("");
}
// IDEA-164262
static class MyClass {
@Nullable
static String nullableFunction(String s) {
return s;
}
static String functionThatDoesNotAcceptNull(@NotNull String s) {
return s;
}
void test(List<String> list) {
list.stream()
.map(MyClass::nullableFunction)
.map(s -> functionThatDoesNotAcceptNull(<warning descr="Argument 's' might be null">s</warning>)) // Exception will be thrown here
.forEach(System.out::println);
}
void testMr(List<String> list) {
list.stream()
.map(MyClass::nullableFunction)
.map(<warning descr="Method reference argument might be null">MyClass::functionThatDoesNotAcceptNull</warning>)
.forEach(System.out::println);
}
}
Optional<String> testOptionalOfNullable(List<String> list) {
return list.stream().filter(Objects::isNull).map(Optional::<warning descr="Passing 'null' argument to 'Optional'">ofNullable</warning>).findFirst().orElse(Optional.empty());
}
void testGenerate() {
List<String> list1 = Stream.generate(() -> Math.random() > 0.5 ? "foo" : "baz")
.limit(10).filter((xyz -> <warning descr="Condition '\"bar\".equals(xyz)' is always 'false'">"bar".equals(xyz)</warning>)).collect(Collectors.toList());
List<String> list2 = Stream.generate(() -> "xyz").limit(20).filter(<warning descr="Method reference result is always 'false'">"bar"::equals</warning>).collect(Collectors.toList());
Stream.generate(() -> Optional.of("xyz")).filter(<warning descr="Method reference result is always 'true'">Optional::isPresent</warning>).forEach(System.out::println);
LongStream.generate(() -> 5).limit(10).filter(x -> <warning descr="Condition 'x > 6' is always 'false'">x > 6</warning>).forEach(s -> System.out.println(s));
}
}