Nikita Eshkeevandintellij-monorepo-bot 565443bca4 [codeInsight] IDEA-219640 Inspection to detect some pointless String.substring ...

This patch fixes the notes from the review, it contains:

1. fixing the javadoc for ExpressionUtils#isConversionToStringNecessary
2. properly handling JavaTokenType.MINUS in ExpressionUtils#isDifference
3. properly handling complex PsiPolyadicExpression values in ExpressionUtils#isDifference
4. changing ProblemHighlightType to GENERIC_ERROR_OR_WARNING for
inspecitons like these
5. fixing the comments duplication problem when replacing the old string
with a new one for inspections like stringValue.substring(0, 1).equals("_")

Signed-off-by: Nikita Eshkeev <nikita.eshkeev@jetbrains.com>

GitOrigin-RevId: 907524c9026e2d1d7cd6f0bd7b988e478e73298d

2020-04-20 20:10:15 +00:00

..

afterPrintlnEmpty.java

…

afterStringBuilderAppendCleanUp.java

…

afterStringBuilderAppendEmpty.java

…

afterStringBuilderEmpty.java

…

afterStringConstructor2.java

…

afterStringConstructor.java

…

afterStringIndexOfZero.java

…

afterStringIntern.java

…

afterStringLastIndexOf2.java

…

afterStringLastIndexOf.java

…

afterStringStartsWithZero.java

…

afterStringSubstringLength.java

…

afterStringSubstringZero.java

…

afterStringToString.java

…

afterSubstringEquals.java

…

afterSubstringInAppend.java

…

afterSubstringOneCharInAppend.java

[codeInsight] IDEA-219640 Inspection to detect some pointless String.substring

2020-04-20 20:10:15 +00:00

afterSubstringOneCharInEquals.java

[codeInsight] IDEA-219640 Inspection to detect some pointless String.substring

2020-04-20 20:10:15 +00:00

afterToLowerCaseIsEmpty.java

…

beforeObjectToString.java

…

beforePrintlnEmpty.java

…

beforeStringBuilderAppendCleanUp.java

…

beforeStringBuilderAppendEmpty.java

…

beforeStringBuilderEmpty.java

…

beforeStringConstructor2.java

…

beforeStringConstructor.java

…

beforeStringIndexOfZero.java

…

beforeStringIntern.java

…

beforeStringInternNonConst.java

…

beforeStringLastIndexOf2.java

…

beforeStringLastIndexOf.java

…

beforeStringStartsWithZero.java

…

beforeStringSubstringLength.java

…

beforeStringSubstringZero.java

…

beforeStringToString.java

…

beforeSubstringEquals.java

…

beforeSubstringInAppend.java

…

beforeSubstringOneCharInAppend.java

[codeInsight] IDEA-219640 Inspection to detect some pointless String.substring

2020-04-20 20:10:15 +00:00

beforeSubstringOneCharInEquals.java

[codeInsight] IDEA-219640 Inspection to detect some pointless String.substring

2020-04-20 20:10:15 +00:00

beforeToLowerCaseIsEmpty.java

…