Commit Graph

2898 Commits

Author SHA1 Message Date
Anna Kozlova
fdf412aca7 transitive overriding methods check: applied for interfaces (IDEA-174806) 2017-06-23 18:19:42 +03:00
Anna Kozlova
0e5a7bca67 testdata for IDEA-174924 2017-06-23 18:19:42 +03:00
Anna Kozlova
d9145615c7 testdata 2017-06-22 21:46:30 +03:00
Anna Kozlova
db549e17d1 take into account container class type parameters: unchecked warnings 2017-06-22 15:54:30 +03:00
Anna Kozlova
cbe6eb48ed take into account container class type parameters: return type
detection if return type mentions type parameters should include types specified on outer class
2017-06-22 15:54:30 +03:00
Anna Kozlova
cba2ff917b take into account container class type parameters
when non-generic inner class is located inside generic outer, inference variables could be hidden in parent parameters (IDEA-174762; IDEA-174776)
2017-06-22 12:14:03 +03:00
Pavel Dolgov
0aa8430cb4 Java: Look for redundant assignment of a field in class and field initializers (IDEA-149587) 2017-06-21 14:45:30 +03:00
yarik
ced545552a [java formatter] c style comments formatting supported. Note, only single line comments or comments with each line starting with asterisks will be formatted, since by using /* and */ you 2017-06-20 14:48:26 +03:00
Anna Kozlova
b6482f44a1 add static import: use existing import name (IDEA-174647) 2017-06-20 11:32:03 +03:00
Anna Kozlova
5d8e3f67a1 don't override first field by same named second (IDEA-174523) 2017-06-16 11:53:53 +03:00
Anna Kozlova
f60676d110 default Optional.empty for Optional type (IDEA-174268) 2017-06-14 19:27:02 +03:00
Anna Kozlova
3dff91600a redundant code block: compare same overload resolution (IDEA-174288)
instead of trying with cast afterwards, don't suggest to remove the block at the first place
2017-06-14 11:51:52 +03:00
Anna Kozlova
605dfb1c3c redundant cast: ensure cast type compared with ground type (IDEA-174369)
remove attempts to emulate that and reuse getGroundTargetType api
2017-06-13 20:27:13 +03:00
Anna Kozlova
4b3e51a69d testdata changes 2017-06-13 20:27:12 +03:00
Anna Kozlova
fb928f72c6 lambda inference: conditional expressions in returns (IDEA-174301)
skip conditionals and parenthesis during find top expression
2017-06-13 16:12:45 +03:00
Anna Kozlova
634a945b0f apply unifying substitutor to compare return types (IDEA-174292)
attempt to apply incompatible return types in method hierarchy due to method type parameters used in return types
2017-06-13 16:12:44 +03:00
Maxim.Mossienko
7387ee525b update tests and testdata to reflect newer mock jdk 1.7 2017-06-13 15:09:42 +02:00
Roman Shevchenko
0d61e56b64 [java] recognizes @index Javadoc tag (IDEA-160185) 2017-06-09 17:50:49 +03:00
Roman Shevchenko
e16815fb9f [java] drops improperly added Javadoc tag 2017-06-08 19:14:48 +03:00
Tagir Valeev
fb6965b6b9 ExtractSideEffectsFix -> DeleteSideEffectsAwareFix; i18n
Now intention availability logic is moved from HighlightUtil to DeleteSideEffectsAwareFix
Review: IDEA-CR-21623
2017-06-08 12:15:20 +07:00
Tagir Valeev
a5dcf8841f ComparatorResultComparisonInspection: support >/>=/</<= checks
Additional fix for IDEA-173177. Now conditions like "a.compareTo(b) > 1" are warned as well.
2017-06-08 10:14:34 +07:00
Tagir Valeev
535c113dba IDEA-172877 Provide a quick-fix on 'Not a statement' error message 2017-06-07 15:27:49 +07:00
Anna Kozlova
02c718aae8 replace assignment with comparison in condition exps (IDEA-173860) 2017-06-06 19:07:58 +03:00
Anna Kozlova
6487bb6913 disable assign parameter to final field (IDEA-173815)
for constructors with chaining calls, for non-constructors
2017-06-06 14:54:06 +03:00
Tagir Valeev
dbcddf5a4a BoxForComparisonInspection enhanced -> UseCompareMethodInspection
Suggests to use Integer.compare(), etc. instead if ternary operator or if chain. Fixes IDEA-173766.
2017-06-06 17:20:08 +07:00
peter
03a663c63e IDEA-165006 Support chained completion for method references in Java 8+ 2017-06-05 19:20:02 +02:00
Anna Kozlova
c578a4ede7 disable assign param to field (IDEA-173747; IDEA-173689)
inapplicable types or already assigned
2017-06-05 20:14:45 +03:00
Anna Kozlova
a5501a81c0 incompatible return types in hierarchy fixed (IDEA-173809)
take parameter bounds into account
2017-06-05 20:14:44 +03:00
Anna Kozlova
6423538939 surround with array fix: disable for non-denotable types (IDEA-173797) 2017-06-05 17:45:46 +03:00
Anna Kozlova
12c350758d Interface.super method calls: ensure valid qualifier (IDEA-173888)
forbid calls to super methods which are overridden in direct superinterfaces
2017-06-05 14:34:18 +03:00
Anna Kozlova
377520ade5 intersection type validation fixed (IDEA-173900)
take type parameter bounds into account
2017-06-05 14:34:18 +03:00
Pavel Dolgov
6ebd6d9b4d Java: Fixed conversion of constructor parameters for java.awt.Color (IDEA-172996) 2017-06-01 13:30:14 +03:00
Tagir Valeev
588d978362 OptionalIsPresentInspection: do not warn if map() part can be null
If we cannot determine the non-nullity of map expression, then info
level is used. Fixes IDEA-172609 "Replace Optional.isPresent() checks
with functional-style expressions" is broken.
2017-05-31 17:48:57 +07:00
Anna Kozlova
3f76ffa2f8 provide quick fix to qualify super call to default interface method from class (IDEA-172325) 2017-05-30 15:00:42 +03:00
Tagir Valeev
b209ade15d TrivialFunctionalExpressionUsageInspection: disable for multi-statement lambda in "for" init/update 2017-05-29 12:19:05 +07:00
Anna Kozlova
5e77c443de simplification following IDEA-CR-21392 2017-05-26 13:36:45 +03:00
Anna Kozlova
51bcfcecf9 inference: don't traverse up through lambda bounds when parent inference was already started, in this case it's exception inference which should work without top level node (EA-83073 - assert: LambdaUtil.treeWalkUp; IDEA-173467) 2017-05-26 13:36:45 +03:00
Anna Kozlova
770ebf45af disable trivial functional expression for body with returns (IDEA-173436) 2017-05-25 16:06:05 +03:00
Tagir Valeev
3fda127a48 ComparatorResultComparisonInspection: renamed to "Suspicious usage of compare method" 2017-05-24 18:14:30 +07:00
Tagir Valeev
1db8b83dff IDEA-173177 Inspection: Comparing 'compareTo()` or 'Comparator.compare()' result with 1 / -1 2017-05-24 14:14:16 +07:00
Pavel Dolgov
16b1765f7f Java: Better handling of unreachable code (IDEA-172642) 2017-05-23 12:28:44 +03:00
Anna Kozlova
011b8e4e10 checked exception constraints: ensure ground type (IDEA-173200) 2017-05-22 11:25:29 +03:00
Anna Kozlova
e747d52bf5 create method from usage: treat polyadic expressions as for completion by containing expression (IDEA-151432) 2017-05-18 13:25:30 +03:00
Anna Kozlova
987caaf26d provide this(); fix when constructor requires super call (IDEA-151335) 2017-05-18 10:50:55 +03:00
Anna Kozlova
40cbf4648a fix testdata 2017-05-18 10:50:55 +03:00
Tagir Valeev
f2442e32fa ConvertSwitchToIfTest: test5 rewritten as getClass() is now pure 2017-05-18 14:36:52 +07:00
Tagir Valeev
8323d2f78d BulkMethodInfo: support for Java 1.4 (fixes EA-101278). 2017-05-17 11:54:09 +07:00
Anna Kozlova
94dd554c0c don't use void in non-free method calls (IDEA-172958) 2017-05-16 21:33:01 +03:00
Pavel Dolgov
c7d8ad3401 Java: Don't reuse cached ControlFlow when the context is not equivalent (IDEA-168768) 2017-05-15 12:34:52 +03:00
Alexey Kudravtsev
4a4626c750 removed default file header, because it adds no information but subtracts attention and space 2017-05-12 14:02:24 +03:00