Commit Graph

256 Commits

Author SHA1 Message Date
Igor Slobodskov
cf108da37d [DS-5493] compare Interval.language and type instead of just type
GitOrigin-RevId: a42048d57f5e3f6d7f061ded1e2a9eaf6be95ca2
2023-08-16 21:01:57 +00:00
Igor Slobodskov
026df603f0 [DS-5493] simplify NotebookCellLinesLexer
GitOrigin-RevId: ae8d26f68d46f2bd9b1dffd8f6ecae8bb0de479c
2023-08-15 19:37:38 +00:00
Igor Slobodskov
b46292cd64 [DS-4896] use ThreadingAssertions.softAssertReadAccess() in NonIncrementalCellLines
GitOrigin-RevId: 2a507ec3376e192fa111fda559e1a1f5021f9740
2023-08-10 17:26:27 +00:00
Igor Slobodskov
bac3d26b55 [DS-4896] use ThreadingAssertions.softAssertReadAccess() in NotebookCellInlayManager
GitOrigin-RevId: f7247351b1aed607964fe3c414e2fd53660b5d86
2023-08-10 17:26:24 +00:00
Igor Slobodskov
76c22ac6eb [DS-4896] use ThreadingAssertions.softAssertReadAccess() in NotebookIntervalPointerFactoryImpl
use it instead of deprecated ApplicationManager.getApplication().assertReadAccessAllowed()

GitOrigin-RevId: fc304f51290c8926f18d89f2d53e3a1009d93e1b
2023-08-10 17:26:21 +00:00
Vladimir Krivosheev
8dd13764a9 IDEA-326151 update hash algo for icons
GitOrigin-RevId: bb8f3acd0314190362619afb86151270b893f082
2023-08-09 14:46:20 +00:00
Igor Slobodskov
95c7e05e6f [DS-5033] suppress and log listener exceptions
f

GitOrigin-RevId: 7a45315bdf0805d0576fb7f61af58e28d0eee8fa
2023-07-28 14:24:55 +00:00
Ilya Muradyan
3a4aabbde6 DS-5115: Fix of appearance in New UI for Kotlin Notebook
GitOrigin-RevId: 812b171bd0c6ee9903418874441a94dc01c9556b
2023-07-18 20:32:05 +00:00
Anton Bragin
7043ce6f03 DS-5115 New UI notebook editor appearance extracted as a separate object
GitOrigin-RevId: 6fb9a5de4d9d8a555bb86e0882c4b82fedf066e0
2023-07-13 16:01:00 +00:00
Anton Bragin
53470d2c54 DS-5115 New UI: notebook cell background and caret row colors updated
GitOrigin-RevId: cc41de31bad6d2e790a4730b2c30d505887d6999
2023-07-12 20:17:00 +00:00
Igor Slobodskov
33cd5ee897 [DS-4636] skip mode change when editor is disposed
GitOrigin-RevId: 3ec6a7f0c3278c12278fcd8b3af6e4b6f13547fb
2023-07-05 19:59:38 +00:00
Daniil Ovchinnikov
97f0a7fd3b migrate usages of ModalityState.NON_MODAL to ModalityState.nonModal
GitOrigin-RevId: fb4855bfa90dbf384fed24871e4b28ab803847bb
2023-06-09 21:58:50 +00:00
Igor Slobodskov
f4751b0402 [DS-5156] Simplify JupyterInlayProgressStatusManagerImpl
* Change NotebookIntervalPointerConcurrentMap.removeAll implementation, fixes for review
* Use NotebookIntervalPointerConcurrentMap instead of mutableMap.
NotebookIntervalPointerConcurrentMap cleanups invalid pointers automatically.
* Remove JupyterInlayProgressStatusManager.Listener. It had only one trivial one-line implementation. Hardly another one implementation will be added, so better to simplify all and call code directly.

Merge-request: IJ-MR-107986
Merged-by: Igor Slobodskov <Igor.Slobodskov@jetbrains.com>

GitOrigin-RevId: e895b15f199b0b11f08d4704f758ca6108a759f2
2023-06-08 18:22:13 +00:00
Igor Slobodskov
2f8f9f9028 [EA-681190] hide undoManager to prevent usage in disposed project
GitOrigin-RevId: b6c215aafeca22f53ffd5a049f34942364bd4f17
2023-06-06 16:33:57 +00:00
Igor Slobodskov
dd04fa8b58 [DS-4838] don't check 'Editor.isNotebook' from EDT
GitOrigin-RevId: 4bc3e4073e5cf5978325d6323b0cb96505cb8a71
2023-06-06 16:32:52 +00:00
Igor Slobodskov
b5c8540752 [DS-5033] log class of factory which have thrown exception
GitOrigin-RevId: ce444b3260c0950f7cd788106982bddfe2c00013
2023-06-06 14:38:14 +00:00
Igor Slobodskov
d716a186f9 [EA-681190] check that project is not disposed
GitOrigin-RevId: ccf41998df1d02e2d3eeba54937b86c04afe96ce
2023-06-02 15:39:18 +00:00
Alexey Belkov
98ba892cc5 Apply Kotlin inspection "Range can be converted to indices or iteration"
GitOrigin-RevId: 2055bae4ddb461c2d4ae938be6e809dd3b8097eb
2023-06-02 14:35:11 +00:00
Alexey Belkov
12e01dd7ee Apply Kotlin inspection "'when' that can be simplified by introducing an argument"
GitOrigin-RevId: 5c40b61e1275e533030428b9e45d64a27c5a95fe
2023-06-01 13:27:47 +00:00
Alexey Belkov
4467dc883b Apply Kotlin inspection "Unnecessary type argument" on whole project
GitOrigin-RevId: 70a38b512309685d57bb5eddf2fc5068f14fe481
2023-05-27 14:22:18 +00:00
Alexey Belkov
1d790f1992 Apply "Java methods should be replaced with Kotlin analog" inspection on whole project
GitOrigin-RevId: 35d07247cdf7742957dde59bbb8d6408754a9c4e
2023-05-26 09:44:56 +00:00
Alexey Belkov
a6521777bf Revert "Apply "Java methods should be replaced with Kotlin analog" inspection on whole project"
This reverts commit 9863c1e3

GitOrigin-RevId: 7fe730efd4ffe4fef76fe6f36c3e53b496067855
2023-05-25 07:09:00 +00:00
Alexey Belkov
ebe914e465 Apply "Java methods should be replaced with Kotlin analog" inspection on whole project
GitOrigin-RevId: 9863c1e384067b97b5015147589e409facd37549
2023-05-24 16:04:31 +00:00
Alexey Belkov
eba859446f Apply "Kotlin | Assignment can be replaced with operator assignment" on whole project
^KTIJ-25352

GitOrigin-RevId: ed3283325767f207167717ca703a102f4eb50e66
2023-05-19 13:27:41 +00:00
Igor Slobodskov
ccb13e03e7 [DS-5033] suppress and log exceptions from NotebookCellInlayController.Factory
GitOrigin-RevId: 674605496051ad433b57eb6ef255f2ceeadb38af
2023-05-17 17:25:57 +00:00
Andrey Vokin
af5efbb867 DS-5065 Blinking stripes when typing in code cells
GitOrigin-RevId: 7f2adebd7eccdfb98a54782547ea44b2d4ad98d5
2023-05-16 07:49:50 +00:00
Andrey Vokin
7649c149a4 DS-5030 Gray stripe in markdown cell if it is the top or the bottom cell in the notebook
GitOrigin-RevId: 2c03a723792d82e46619fd450e9d495db9e852f3
2023-05-12 11:33:31 +00:00
Andrey Vokin
2452b376aa DS-5014 Wrong text in the "Add Code Cell/Add Markdown Cell" button. The button does not appear under the last cell
GitOrigin-RevId: e754cede19f6a81b4ebb4bda33eb5488b8ebd755
2023-05-08 17:16:53 +00:00
Andrey Vokin
94ec7f52e5 DS-5013 Table height is not adjusted when table is loaded
GitOrigin-RevId: c14b2ecef3b3495ed6203df813216ec2e9e848e7
2023-05-08 17:16:50 +00:00
Andrey Vokin
d27acd6372 DS-3609 Make DataSpell Remote Development accessible for the general audience
Fix cell bottom background

GitOrigin-RevId: 59b70df4cb990ce560b5a4c5b6b9f5ee0f9a48eb
2023-05-05 16:03:54 +00:00
Andrey Vokin
b1277de6e0 DS-3609 Make DataSpell Remote Development accessible for the general audience
Fix height of below cell delimiter line marker gutter renderer

GitOrigin-RevId: 2f6316caf2f41bcf65479ca527d786383b3b5ed0
2023-05-05 16:03:51 +00:00
Andrey Vokin
f4675b2b4f DS-3958 Support command mode in Jupyter Notebooks in Remote Development
Extract NotebookBelowCellDelimiterPanel

GitOrigin-RevId: 73fb43945aeb98553e17255040dae283f50b867c
2023-05-04 15:45:12 +00:00
Andrey Vokin
d495d68652 DS-3609 Make DataSpell Remote Development accessible for the general audience
Simplify below cell panel

GitOrigin-RevId: 32629b111e7980aa7582faabb4016a6d7d0b6d56
2023-05-04 15:45:10 +00:00
Andrey Vokin
1e0858d021 Fix package, according to dev guide
GitOrigin-RevId: 68b86445018382f832109f1afe9d959b27a3cbea
2023-05-03 08:34:29 +00:00
Andrey Vokin
874eaebb84 DS-4630 MVP of Jupyter Notebooks with Remote Development
Transfer cell delimiter panel via Protocol

GitOrigin-RevId: 6226bbcf1c2124db65968d085e27dfd58e0f04d3
2023-05-03 08:34:27 +00:00
Andrey Vokin
6f2aef80ae DS-4986 Separate view and behaviour of panel between notebook cells
GitOrigin-RevId: 8b2f315baed84fa84a1236b9d6aafba67c472317
2023-05-03 08:34:23 +00:00
Igor Slobodskov
b10c02c924 [DS-4945] add tests
GitOrigin-RevId: f80234902af1e63f561b0916e2c020468d5bd6d1
2023-04-29 14:22:08 +00:00
Sviatoslav Vlasov
0ffdad6028 [lux] Hotfix inlays
(cherry picked from commit a5d3930105af139fa7af219fe2bc17ec12acae02)

IJ-MR-106781

GitOrigin-RevId: a5ddda9d6e41a949636ff842f040188ca5a5533a
2023-04-28 20:32:45 +00:00
Georgii Zorabov
f67b893ca2 georgii.zorabov/make_interval_field_non_nullable
[DS-4464] fixed duplicated dependency

[DS-4464] changed findLanguageById to direct language Instance, added dependency to markdown and kotlin.compiler.common

[DS-4464] changed language fields type to non-nullable

[DS-4464] changed IntervalInfo language param type to non-nullable and moved !! assertion

[DS-4464] added dependency to Markdown from Jupyter and changed findLanguageById to direct MarkdownLanguage call

[DS-4464] made Interval.language non-nullable

Merge-request: IJ-MR-106697
Merged-by: Georgii Zorabov <georgii.zorabov@jetbrains.com>

GitOrigin-RevId: c9ed7734b855d7fcd41cc9faff264203ecb812fc
2023-04-25 22:02:01 +00:00
Georgii Zorabov
543633b095 [DS-4464] Added new CellLinesProvider and functions to ConnectionTestStrategy to fix issues with non-backed notebooks
[DS-4464] made key internal again

[DS-4464] added lexer param usage in makeIntervals

[DS-4464] fixed code formatting

[DS-4464] made JupyterTestCellLinesProvider and intervalsGeneratorFromLexer private

[DS-4464] fixed code formatting and naming, used makeIntervals call instead of inlining it

[DS-4464] removed redundant install call

[DS-4464] removed redundant functions from ConnectionTestStrategy, added key set to install in NotebookCellLinesProvider

[DS-4464] Added new CellLinesProvider and functions to ConnectionTestStrategy to fix issues with non-backed notebooks

Merge-request: IJ-MR-106621
Merged-by: Georgii Zorabov <georgii.zorabov@jetbrains.com>

GitOrigin-RevId: 008be66be66a9ef256f3e6b91eccf022906e9a9b
2023-04-24 17:30:26 +00:00
Georgii Zorabov
602bb2058a [DS-4464] added cell language providing for Jupyter files and added tests
[DS-4464] Changed intervals gen in NotebookOutputInlayControllerTest to custom because of non-backedNotebook file

[DS-4464] changed name of function in RMarkdownCellLinesTest and in CodeCellLinesChecker and fixed formatting

[DS-4464] changed name to call a proper function in each class

[DS-4464] moved CodeCellLinesChecker.IntervalsSetter.interval to CodeCellLinesChecker, made public, removed duplications

[DS-4464] reusing marker instead of creating new in markerSequence and fixed formatting in KotlinTest

[DS-4464] made markerSequence map, added property for markdownLanguage in tests and removed unused cast

[DS-4464] fixed params in markerSequence, moved intervalsGeneratorFromLexer to JupyterNotebookCellTypeAwareLexerProvider

[DS-4464] added cell language providing for Jupyter files and added tests

Merge-request: IJ-MR-105885
Merged-by: Georgii Zorabov <georgii.zorabov@jetbrains.com>

GitOrigin-RevId: 4afcad6442ac795fe1f01a5662d770a716dbb407
2023-04-20 17:18:48 +00:00
Vladimir Krivosheev
4bc9611674 waitForLoading should wait for coroutine execution
GitOrigin-RevId: 23170e674dab2c431b234546b81e3bc26c54165d
2023-04-18 14:14:47 +00:00
Vladimir Krivosheev
ad76a7f030 convert JBTabsImpl to kotlin (part 5)
GitOrigin-RevId: 9cba9921125da8f655fb2aff33fe2c33cdd9853e
2023-04-18 14:14:17 +00:00
Vladimir Krivosheev
9be2fe8e6a convert JBTabsImpl to kotlin (part 2)
GitOrigin-RevId: fae577876c38fef5b26292080f0f264b3ac353df
2023-04-18 14:14:07 +00:00
Andrey Vokin
827e65701c DS-3958 Support command mode in Jupyter Notebooks in Remote Development
GitOrigin-RevId: efc40641b1b2a1a42fe0436638d2f3c9cb6284f3
2023-04-15 08:40:01 +00:00
Olga.Lavrichenko
f07d1ca194 DS-4487 Rebuild BelowCellInlayController when editor font size changed or appearance font changed
GitOrigin-RevId: 288febba956ad7215cc217e0b1af4d9b14c32a1a
2023-04-11 13:03:03 +00:00
Alexey Kudravtsev
2b4ca53c2c remove fire* internal dangerous methods from MarkupModelEx, they don't belong there
GitOrigin-RevId: d16822dd511289df80447dd4edef55935cb022ad
2023-04-06 15:50:23 +00:00
Olga.Lavrichenko
40d1846f2f DS-4510 DS-4837 Saved execution time in UTC
GitOrigin-RevId: 5ae14febaffe57508fb53212d9855761d046dd79
2023-04-04 18:52:39 +00:00
Georgii Zorabov
a5cbbab04c georgii.zorabov/4464-RMarkdown
[DS-4464] changed complicated type to a data class IntervalInfo

[DS-4464] fixed Marker Interval transition

[DS-4464] added PlainText language providing if in CODE cell no language is detected and fixed naming

[DS-4464] fixed test with non-existent language name

[DS-4464] fixed tests and max language length name and usage

[DS-4464] reformated tests code

[DS-4464] fixed tests

[DS-4464] added tests

[DS-4464] fixed comments

[DS-4464] moved cellText creation inside if block

[DS-4464] fixed functions in RmdCellLanguageProvider and added longest language search

[DS-4464] deleted comment in IElementType

[DS-4464] made another change in provider for Python

[DS-4464] fixed RmdCellLanguageProviderForPython

[DS-4464] implemented language providers usage for Rmd

changed NotebookCellLines

[DS-4464] corrected language providers

[DS-4464] removed unused condtructor

[DS-4464] fixed constructor IElementType

added parsing first line of cell and field to IElementType

[DS-4464] changed getText to chatsSequence

[DS-4464] fixed comments

[DS-4464] splited to different providers and deleted unneccesary dependency

[DS-4464] added implementation for Rmd

[DS-4464] added some more

[DS-4464] added RmdCellLanguageProvider file

Merge-request: IJ-MR-103792
Merged-by: Georgii Zorabov <georgii.zorabov@jetbrains.com>

GitOrigin-RevId: ad1e639a36ab86faec187ba0d9f9972cdf2310a3
2023-04-04 14:36:59 +00:00
Igor Slobodskov
6b147d75ee [DS-4846] remove selection when selecting single cell
GitOrigin-RevId: 4d43513f85846a457adf819a3e248d641d54bbbd
2023-03-31 16:26:41 +00:00