Commit Graph

672 Commits

Author SHA1 Message Date
Andrew Kozlov
b6e88e8dbf [devkit] i18n property inlined in tests
GitOrigin-RevId: 918fdb959b193758dac26292d4fc4c506e8219d9
2024-04-23 17:20:36 +00:00
Yann Cébron
2338c10c80 [docs] update/cleanup URLs to IntelliJ Platform SDK docs
GitOrigin-RevId: 0c8f39ed84ff1375617613c5a7b68d4073efbc4c
2024-04-18 20:08:53 +00:00
Alexey Kudravtsev
bea50636b2 notnull, cleanup
GitOrigin-RevId: 04cf8a716196d0c05031edc810a44bb5e1a19e38
2024-04-18 15:28:24 +00:00
Yann Cébron
08dd3d9064 [devkit] support line marker to plugin.xml for EPs with >1 CTOR parameter (IDEA-351950)
add more tests

GitOrigin-RevId: 671729c6a760a7b8aae4d39a51f5d8afc830a0ff
2024-04-17 15:24:55 +00:00
Yann Cébron
5adb80d28b [devkit] support line marker to plugin.xml for EPs with >1 CTOR parameter (IDEA-351950)
GitOrigin-RevId: 233d5d39ff8e9efb8140235ab17b44462c341c5a
2024-04-17 12:02:19 +00:00
Vladimir Krivosheev
f8b4ecb14f reduce dependency on CGLIB
GitOrigin-RevId: 5c59ba6aac4113d14c50260c4a58bc7d45249338
2024-04-10 18:11:45 +00:00
Karol Lewandowski
1076dec137 IDEA-326655: Read or write action called during service initialization
GitOrigin-RevId: 7946e238e6421167c01a9fa96425f5ca354b10c6
2024-04-05 16:55:31 +00:00
Yann Cébron
ab7e136f01 [devkit] Plugin Model V2: no "experimental" highlighting for external plugins (IDEA-261862)
GitOrigin-RevId: 9eb47c0d54bb2470d22d494e8a7c433c745d89ba
2024-04-04 12:29:46 +00:00
Yann Cébron
0aeb6c9163 [devkit] DOM: remove obsolete "on-demand" attribute (IDEA-297005)
GitOrigin-RevId: aca260207fa8830f5ea5e682b9b59a92ba2ba9cf
2024-04-04 12:29:40 +00:00
Dmitry Avdeev
043ea9029b IDEA-349217 Add i18n inspection/quick fix to live template setting files
GitOrigin-RevId: 48444ea71c01086397eb50e9b4a9974f9bd14ccc
2024-03-15 11:17:12 +00:00
Nikolay Chashnikov
a6b4669f4b [devkit] provide highlighting and completion for product-modules.xml (IDEA-348550)
DOM model is added for product-modules.xml, and ProductModulesXmlDomInspection is introduced to report errors in it. The inspection is marked as internal and disabled by default, because currently it makes sense for the 'intellij' project only.
References to modules in product-modules.xml use IntellijModuleSymbol as the target, but for now it isn't integrated in Symbol API, and its data is used directly to resolve references to modules in IntellijModuleConverter.

GitOrigin-RevId: 98f264fdad920b518125c6dfcff794d31778c1c6
2024-03-08 11:48:45 +00:00
Gregory.Shrago
04d9f4675f introduce missing soft assert methods
`softAssertEventDispatchThread`
`softAssertBackgroundThread`

Also, unify constant names.

GitOrigin-RevId: 38f598d72d93c9a3d36feabbeeee21e6e1c74fa6
2024-03-03 23:34:01 +00:00
Vladislav Rassokhin
d5b62983c6 [devkit] move isIdeaProject to ProjectIconsAccessor, reuse code
GitOrigin-RevId: 83c08ca20b9a23910c527870664f6d266b5b07fd
2024-03-01 22:11:34 +00:00
Andrey Cherkasov
32e4248809 [devkit] LightServiceMigrationInspection: configurationSchemaKey must not be specified
^IDEA-254577

GitOrigin-RevId: db3871b563b94f9d55cf607326ebca8743756e60
2024-02-28 21:41:25 +00:00
Andrey Cherkasov
3323eb5bc3 [devkit] LightServiceMigrationInspection: fix tests
^IDEA-254577

GitOrigin-RevId: e7633864e0d8541f6bbf563b2909d2b4e150a6e2
2024-02-28 21:41:21 +00:00
Yuriy Artamonov
23c7c6f27c [devkit] Update platform versions in wizard
GitOrigin-RevId: 89ca04c86651bcaba8792ff3608082a6163dc66f
2024-02-27 16:31:44 +00:00
Yann Cébron
42ce5bb976 [devkit] IntelliJPlatformProductTest: speedup (IDEA-336017)
GitOrigin-RevId: bd048ef600b8a705a82df799af0c563e145b38bb
2024-02-26 11:38:48 +00:00
Jakub Chrzanowski
c5a80136b6 [devkit] IDEA-336017 Attach IntelliJ Platform dependency sources
GitOrigin-RevId: 543d07f4d54ad50b9497ca148032ddc526f9292c
2024-02-22 21:34:16 +00:00
Zhanna Gorelova
984e0ea1f6 [dev-kit] description gutter should not be added if folder name is not equal to class name (case should not be ignored), otherwise intention description won't be found
GitOrigin-RevId: 82518ebd5d8a434ff3a3ef30ede9db6410705d63
2024-02-14 18:18:23 +00:00
Karol Lewandowski
bf33f56ded IDEA-330739: Devkit: extend "Cancellation check in loops" inspection
- Added support for forEach() and similar methods, and ContainerUtil.process()

GitOrigin-RevId: fc9b66f3584cf94d603d9a84825f4142de92544d
2024-02-08 19:53:11 +00:00
Nikita Kudrin
3dce2dce2f [unit perf tests] AT-644 Renaming
GitOrigin-RevId: 464b77181de9f1e0cc6de2623201635c405ee4c3
2024-02-08 11:21:41 +00:00
Nikita Kudrin
b143fe1540 [unit perf tests] AT-644 Removed expected time from the tests
GitOrigin-RevId: a53f40c1721a46c7833018346dc622dec1f1b80a
2024-02-07 16:11:29 +00:00
Yann Cébron
6fc6517669 [devkit] Fix plugin.xml recognition when comment contains angle brackets (IDEA-345026)
close #2658

GitOrigin-RevId: 5de43cd45ffef6e8b4435b0f6de978c9eca1b56d
2024-02-06 23:34:53 +00:00
Nikolay Chashnikov
3acf7e90be [runtime module repository] build runtime module repository during compilation (IDEA-335089)
To ensure that we can change how runtime module descriptors are generated without requiring everybody to update their IDEs, the implementation from module 'intellij.devkit.runtimeModuleRepository.jps' is attached to the build process as a library 'devkit.runtime.module.repository.jps'.

GitOrigin-RevId: 11fb0d872aa5ac8981f026f2bf3077bcebd52af6
2024-01-31 12:16:17 +00:00
Andrey Cherkasov
6e95446bec [java] The 'Make class final' quick-fix must check final methods
...and remove their 'final' modifier. Since final classes cannot be inherited, marking a method as final is unnecessary and confusing.

^IDEA-309065

GitOrigin-RevId: de044d57c690772aefc7044d87159c42ebc92907
2023-12-18 20:25:02 +00:00
Andrey Cherkasov
519ffd2508 [java] The 'Make class final' quick-fix must check protected members
...and weaken their visibility. This is necessary because protected members in final classes may be confusing.

^IDEA-309065

GitOrigin-RevId: 33e814c2b11708616e110abbdead20d3e9f2b75d
2023-12-18 17:55:26 +00:00
Andrey Cherkasov
e59d2a751e [devkit] LightServiceMigrationInspection: provide quick-fix
...for the "Service can be converted to a light service" warning. The provided quick-fix annotates the service class with '@Service' and removes its registration from the 'plugin.xml' file.

^IDEA-254577

GitOrigin-RevId: 55cace08aa3beade8fb5e28532a29df459e2c1f0
2023-12-13 20:03:28 +00:00
Andrey Cherkasov
2e5cd31c49 [devkit] LightServiceMigrationXMLInspection: provide quick-fix
...for the "Service class annotated with '@Service' must not be registered in the 'plugin.xml' file" warning. The provided quick-fix removes the service registration from the 'plugin.xml' file.

^IDEA-254577

GitOrigin-RevId: fdb96913323c60dc8551ff55dac24c04b3299dff
2023-12-13 20:03:20 +00:00
Andrey Cherkasov
7884824d0f [devkit] Move test classes to another packages
GitOrigin-RevId: 807208799a195f262b1afbcd4c515fbf60adaf20
2023-12-13 20:03:18 +00:00
Dmitry Avdeev
6ba55541ee IDEA-337197 Throwable: the expensive method should not be called inside the highlighting pass in JSP
check unresolved references in a dedicated XmlUnresolvedReferenceInspection

GitOrigin-RevId: d54b7a0b933c33c8656726c84a9611c97c1268ff
2023-12-13 18:12:42 +00:00
Andrey Cherkasov
ddabcc31c7 [devkit] Simplifiable service retrieving: fix false positives
The inspection must not suggest replacing a service retrieving call if this call is an initializer of a variable annotated as @Nullable.

GitOrigin-RevId: f3f219dacd41f2540085bbb076779be1e742e0b7
2023-12-07 16:47:39 +00:00
Andrey Cherkasov
73d147c61b [devkit] Simplifiable service retrieving: fix false positives
The inspection must not suggest replacing a service retrieving call if this call is a return expression of a method with a nullable return type.

GitOrigin-RevId: 875181b5d03e4842e186524cb9b3f7756ba81290
2023-12-07 16:47:36 +00:00
Andrey Cherkasov
28108d64bb [devkit] Extension class should be final and non-public: false positives
The inspection must not warn on classes annotated with any of the VisibleForTesting annotations.

^IDEA-309065

GitOrigin-RevId: 6a9395c41b89c4c28bf9131d5c5de2f60127e517
2023-12-05 21:56:20 +00:00
Andrey Cherkasov
6904c08bc4 [devkit] Extension class should be final and non-public: false positives
The inspection must not warn on classes that have inheritors.

^IDEA-309065

GitOrigin-RevId: 16b93c4bc04ea2e84e7fabe1c663cbeebe7346f6
2023-12-05 21:56:16 +00:00
Andrey Cherkasov
7bef3fb7b8 [devkit] Simplifiable service retrieving: fix false positives
The inspection must not suggest replacing service retrieving calls with a `getInstance` call if a `getInstance` method has a nullable return type.

GitOrigin-RevId: cd8a36698f0c1efb4c6af27962554ae36ba7266a
2023-11-29 13:31:50 +00:00
Andrey Cherkasov
99d2b27c9d [devkit] "Incorrect service retrieving" inspection: false negatives
Added support the `ComponentManager#getServiceIfCreated` method

GitOrigin-RevId: 7eb6c0c157327a7ea8b4f3d69f0dac19003d8b37
2023-11-23 21:53:25 +00:00
Karol Lewandowski
8d7376eb72 IDEA-311444: Forbid using Process.waitFor/Process.onExit in favor of our own extension method Process.awaitExit
- enable inspection

GitOrigin-RevId: 46a9f8441542e490abde57c63ce12e2ac83c5a7d
2023-11-08 16:01:18 +00:00
Andrew Kozlov
fb35475e29 [devkit] IDEA-323201 wip status removed
GitOrigin-RevId: ab8a58ca7a1d01043f4881779a8fa71a955230ca
2023-10-23 18:08:02 +00:00
Andrew Kozlov
c2fff5cf93 [devkit] IDEA-315381 wip status removed
GitOrigin-RevId: 16bd67027ae4fe78d821fc98963af8e2156e965b
2023-10-23 18:08:01 +00:00
Nikita Kudrin
5f15fa3f42 [test framework] AT-107 Adding dependency on intellij.tools.ide.metrics.benchmark to publish metrics
GitOrigin-RevId: aaeb67a13dab0038e8f8e8ec6ed7d683d4dfe5d3
2023-10-16 23:23:34 +00:00
Karol Lewandowski
bc7544bdb8 IDEA-301191: Enable "TokenSet in ParserDefinition references non-platform classes"
GitOrigin-RevId: 1ea79e759ae0f70deb1a05cfc026940e07156204
2023-10-16 18:24:33 +00:00
Yann Cébron
abb4be365b [devkit] inspection "Listener implementation implements 'Disposable'" enabled by default (IDEA-323204)
GitOrigin-RevId: bd0a2367bcf47df10e4be8df6ad09055c336b5a4
2023-10-16 16:57:02 +00:00
Andrey Cherkasov
9e9ed6eb11 [devkit] The "Mismatch between light service level and its constructor" inspection: false negative
IDEA-334607

GitOrigin-RevId: b3fcda025cba7de82939b985c0447f2e4f80f862
2023-10-11 13:19:11 +00:00
Karol Lewandowski
dbb74a9c98 IDEA-334137: Delete UseCoupleInspection
GitOrigin-RevId: d32b83ebf9cef84ea724d239ca2d783fa327d21b
2023-10-11 09:51:59 +00:00
Andrey Cherkasov
2e21416fee [kotlin uast] Make the findDefaultValueForAnnotationAttribute method work for usages of Java annotations from Kotlin
^KTIJ-27300

GitOrigin-RevId: b363764c07ee11f634b70e150440d80b74022689
2023-10-06 07:18:09 +00:00
Andrey Cherkasov
c7e0b8adeb [devkit] The "Simplifiable service retrieving" inspection: fix false positive
IDEA-333347

GitOrigin-RevId: 585bd8e37e60c2da24f553a250dd2ba87374ef6a
2023-10-03 16:15:46 +00:00
Andrew Kozlov
d6e577c808 [devKit] IDEA-326862 GoodCodeRedVisitor moved to intellij.dev.codeInsight
all the implementations moved accordingly

GitOrigin-RevId: d8f87fc59df6ba322f1bfed864bd756dd226b530
2023-10-03 13:25:09 +00:00
Andrey Cherkasov
073114cdb2 [devkit] Split the "Incorrect or simplifiable retrieving service" inspection into two
IDEA-327590

GitOrigin-RevId: 721b34c773e16b93cc593080ba2dbc130606ed40
2023-10-03 04:01:17 +00:00
Andrey Cherkasov
6e10f5d13f [devkit] Remove "Eager service initialization during classloading" from SSR as it now a part of DevKit inspections
IDEA-330732
IDEA-326964

GitOrigin-RevId: 3b3b6ed72f36d62598f25a1d2f50904ade453cf2
2023-09-28 12:37:57 +00:00
Karol Lewandowski
9c75884cdf Clarify disabled/WIP inspection lists
GitOrigin-RevId: 1c414261219db85820c6648946b060129df7678b
2023-09-27 20:13:48 +00:00