Commit Graph

7814 Commits

Author SHA1 Message Date
Bas Leijdekkers
f198a23cdf Java: don't evaluate enum constants as constants expressions
GitOrigin-RevId: c5d703ce78b569a3bdab9e8e9dcc2e95bdadd07f
2024-08-29 19:03:09 +00:00
Bas Leijdekkers
8827db8d65 Java: remove enum functionality from constant evaluator
GitOrigin-RevId: edcb80e7ddeee3a45b83c98cf77f3c56fd850298
2024-08-29 19:03:09 +00:00
Tagir Valeev
07c73fd64a [java-dfa] Recognize String.strip/stripLeading/stripTrailing/isBlank
Also: limit the length of the resulting string if the length of the original string is known

GitOrigin-RevId: bfe3752b15949047366c3d3d79c7d13a49193abd
2024-08-29 14:08:22 +00:00
Tagir Valeev
59325634ab [java-inspections] IDEA-356832 Inspections ignore redundant Class::cast method call
GitOrigin-RevId: 390a19d69020bc91f1395e6c4d23f14992ca396b
2024-08-28 17:54:26 +00:00
Tagir Valeev
646b6ff3d1 [java] VariableNameGenerator: contracts
GitOrigin-RevId: f22a0ac01694934f291d31f0322f4c01d271418e
2024-08-28 17:54:26 +00:00
Tagir Valeev
70aabe4830 [java-inspections] AbstractClassNeverImplemented: improve description; reorder check for efficiency
GitOrigin-RevId: 4a7508def1712070c231ddc3ce6fd804bbc05784
2024-08-27 16:39:09 +00:00
Mikhail Pyltsin
71f4656438 IJ-CR-142399 [java-inspections] IDEA-356745 False positive 'Incorrect 'MessageFormat' pattern' when argument is array
-simplify variables

GitOrigin-RevId: f67c6172e1dcf8a61d6c335429de990de02b7ad6
2024-08-27 09:13:47 +00:00
Mikhail Pyltsin
76e51824bf [java-inspection] IDEA-356207 incorrect work with typeUseWithType option
GitOrigin-RevId: b4affe09ebbf3269881bf00d48f75cca3fd27a59
2024-08-27 09:13:47 +00:00
Bas Leijdekkers
f8f22f782d Java: cleanup AddTypeCastFix.java
GitOrigin-RevId: 01d277b7a19d255153f1632292df479845064a6c
2024-08-26 18:38:16 +00:00
Bas Leijdekkers
18cb209fa7 Java: add cast to single branch of conditional expression when possible (IDEA-358278)
GitOrigin-RevId: 8f3137172d8a1526da2228e3c9ed911f9805c16c
2024-08-26 18:38:16 +00:00
Bas Leijdekkers
83bba063e7 Java: improve message for cast fix
GitOrigin-RevId: 40cd180ca8fdae46a3ea0216ec7b08e82ca22364
2024-08-26 18:38:16 +00:00
Alexey Kudravtsev
baa254d5eb IJPL-160883 Apply ChangeLocalityDetector even if PSI reference or declaration is changed
do not disable ChangeLocalityDetector produced scope when the reference was changed in languages other than Java/Kotlin, because the rules might be different there. Instead, move that logic inside the java/kotlin ChangeLocalityDetectors

GitOrigin-RevId: 4aafa966186fe038c25e0a2512c80ba1b1d93eeb
2024-08-26 17:04:03 +00:00
Tagir Valeev
deec897dd4 [java-analysis] MutationSignature: startsWith -> equals (IDEA-355908)
GitOrigin-RevId: 7f344d27d39416cfe160c0ad648d625034e1a03d
2024-08-26 16:33:36 +00:00
Max Medvedev
1729cd94d5 cleanup JavaTelescope
GitOrigin-RevId: 881c66ff97088cd4e97cf2567c9fd7935578ddf0
2024-08-25 16:36:01 +00:00
Mikhail Pyltsin
e01d24d5c8 [java-highlighting] IDEA-357866 Spurious "Different case kinds used in the switch" error on incomplete code
- fixes
- not double error messages

GitOrigin-RevId: 8f789243ee4e09d3eb8de6a2db7dcbe25ee517db
2024-08-22 16:03:56 +00:00
Bas Leijdekkers
1a5e213e96 Java: "Suppress for <x>" fix should not make code uncompilable (IDEA-358115)
GitOrigin-RevId: 754d0bac805a0e9d56489c63e5486d6e7e15a4db
2024-08-22 15:27:14 +00:00
Mikhail Pyltsin
e39d914c56 [java-highlighting] IDEA-357868 Better error message for primitive types in instanceof
GitOrigin-RevId: bb638cf01ec27474d89859c27c5410add6be5931
2024-08-22 09:22:53 +00:00
Bas Leijdekkers
7db980cfcf Java: remove unneeded ':' from inspection problem report
GitOrigin-RevId: 9b0c070c8ca2a883d0d07f0064b67f22594cbced
2024-08-21 09:12:08 +00:00
Bas Leijdekkers
bd7f1f4270 Java: proper order of 'true' and 'false' in quick-fix name (IDEA-357973)
also fixes internationalization and the incorrect comma in the name
for "Create missing switch branches" quick-fix

GitOrigin-RevId: 16285e054447d8d15318df8889499bbbf91243a7
2024-08-21 09:12:08 +00:00
Mikhail Pyltsin
5b107c226b [java-property-tests] UninitializedReadCollector supports PsiForeachPatternStatement
GitOrigin-RevId: 9d52770fcc09b9c64a2db8d5449eb5c7277f7cd5
2024-08-19 17:36:49 +00:00
Mikhail Pyltsin
c56e5e7313 [java-inspections] IDEA-357725 LoggerInitializedWithForeignClassInspection should skip when the logger is the final field
GitOrigin-RevId: e910d9bb094f058c363148a3d08b695276bcc2c6
2024-08-15 18:02:00 +00:00
Bas Leijdekkers
adbb319537 Java: handle multiline headings a little better (IJ-CR-142291)
GitOrigin-RevId: 0c132d6b41dfc634c15bbe47d8176612909cf3f7
2024-08-15 15:56:37 +00:00
Bas Leijdekkers
a12f4edd1a Java: Use "isMarkdownComment()" (IJ-CR-142291)
GitOrigin-RevId: 24c203a2c93286e733933c554ad338db460a313f
2024-08-15 15:56:37 +00:00
Bas Leijdekkers
31cd07cef6 Java: avoid exceptions on bad javadoc html (IJ-CR-142291)
GitOrigin-RevId: 40fe350fab9354863141929cd135a5f2d0393fc2
2024-08-15 15:56:37 +00:00
Bas Leijdekkers
df3532e177 Java: make inspection dumb aware
GitOrigin-RevId: f2161c04f73163bebdebe1ebd8c84da793697089
2024-08-15 15:56:37 +00:00
Mathias Boulay
abd7b1dded fix(JDoc): Formatting and inspections issues
GitOrigin-RevId: 910e9b3335fa7c3967fb79893ecba7c69595a201
2024-08-14 18:24:38 +00:00
Mathias Boulay
6ebdc205ef feat(javadoc): early markdown support part 2
GitOrigin-RevId: 74093daa489fda535b3951828d6617519e5d293f
2024-08-14 02:45:23 +00:00
Mikhail Pyltsin
d8e9c970ae [java-highlighting] IDEA-357310 highlight soft-keywords in compiled files
GitOrigin-RevId: 5a30cb3acd3df05cc3bd016c0e612e0fee60750e
2024-08-13 21:21:59 +00:00
Mathias Boulay
3825899d51 feat(IDEA-353092): early markdown jdoc support
GitOrigin-RevId: 8c02012551f1a97d3f5d6aed021889911b138b28
2024-08-13 11:44:06 +00:00
Mikhail Pyltsin
dc7ef24c78 [java-inspections] IDEA-356745 False positive 'Incorrect 'MessageFormat' pattern' when argument is array
- delete outdated comment

GitOrigin-RevId: 41cc9b3487451c07ea0ab55f8cd88c6750a51010
2024-08-13 09:16:51 +00:00
Mikhail Pyltsin
d8b8f63677 [java-inspections] IDEA-356745 False positive 'Incorrect 'MessageFormat' pattern' when argument is array
GitOrigin-RevId: 75b8f2d944f05ab124e0b1ac340383dcc240b885
2024-08-12 20:28:37 +00:00
Bas Leijdekkers
21d8008ff1 Java: don't break indentation of element after javadoc comment when converting to markdown
GitOrigin-RevId: df6e25727b13fe229531eb2636dcfafa9cb8a175
2024-08-12 17:37:07 +00:00
Bas Leijdekkers
f40ed914fb Java: fix "Missorted modifiers" options and messages
GitOrigin-RevId: ab41b6c1d135c9b788feeec4a273a6f483b9bfa5
2024-08-12 13:37:26 +00:00
Bas Leijdekkers
426cda83e6 Java: support xhtml self-closing tags
GitOrigin-RevId: 97e23cb2054fc721e57a2017b952f35351675220
2024-08-12 13:37:26 +00:00
Max Medvedev
c0f11e5298 HighlightDisplayKey: introduce proper getShortName instead of toString
GitOrigin-RevId: 7c6fb37449dbebb6308c3d76f4cbb48bb3cc1392
2024-08-09 20:25:06 +00:00
Bas Leijdekkers
1c2887a09c Java: basic support for headings when converting Javadoc to Markdown
GitOrigin-RevId: 0b8d1dcfa1324ff783a9b412b6fb330bbc6b0646
2024-08-09 11:14:15 +00:00
Bas Leijdekkers
ebbf5a1d20 Java: fix <br> support when converting Javadoc to Markdown
GitOrigin-RevId: d85489271ee65ff043f039eda4bfa82f8e50db77
2024-08-09 11:14:15 +00:00
Mikhail Pyltsin
cb37003541 [java-inspections] IDEA-357323 Propose case null during adding all cases
GitOrigin-RevId: 6d7ffccc28d64ed0f52db0235c41796d1d81284e
2024-08-09 11:00:42 +00:00
Mikhail Pyltsin
0f5aa949cb [java-inspections] IDEA-357190 Support JEP477 - Remove unnecessary qualification is not suggested when it can be
- check if class is already imported

GitOrigin-RevId: 11a43bf80302194a4f8b34125de2bb741f1f3bac
2024-08-09 11:00:42 +00:00
Bas Leijdekkers
91cff4a4f1 Java: inspection for migration to Markdown documentation comments (IDEA-357191)
GitOrigin-RevId: 94d6c21d713073df58e2f6fb2bbd348a7039b9ce
2024-08-08 20:19:46 +00:00
Bas Leijdekkers
488e4a01bf Java: grammar
GitOrigin-RevId: 2fa00e04420bd0fb6a4826ccf35570c5ae017126
2024-08-08 20:19:46 +00:00
Aleksey Dobrynin
24f3b86d83 [java, highlighting, import-module] Check access module names for Module Import Declarations IDEA-356710
IJ-CR-141484

GitOrigin-RevId: aa63518be14907a230b0ca92189df6e552da36c5
2024-08-06 18:46:57 +00:00
Aleksey Dobrynin
2616038ffc [java, import-module] resolve "import module" jep 476 IDEA-355535
IJ-CR-140196

GitOrigin-RevId: 3c445405dbab1dcbb84050ce2353a03a8ce100aa
2024-08-06 14:50:39 +00:00
Bas Leijdekkers
24aaef624d Java: fix false positive on reference to enum constant (IDEA-357156)
GitOrigin-RevId: 7c833e46823ab41c9bdf275308ccee226d7e1a5f
2024-08-06 10:48:28 +00:00
Mikhail Pyltsin
b4fc8dafba [java-inspections] IJ-CR-140943 IDEA-356672 Support JEP 477. Incorrect intentions and actions with implicit imports
- reuse Graphs

GitOrigin-RevId: 0f2216ea150f27f74e198a306ab0df4b3f9fbdf4
2024-08-05 10:26:33 +00:00
Bas Leijdekkers
32fde2980c Java: mark variables as @PropertyKey(resourceBundle = JavaErrorBundle.BUNDLE) to avoid unused property warnings
GitOrigin-RevId: 0925582c9ae3876be21032a3c37b9d5b3cd56f83
2024-08-04 12:09:09 +00:00
Bas Leijdekkers
e91694a500 Java: remove forgotten code fragment duplicated in JavaNamesHighlightingVisitor
GitOrigin-RevId: 6c00fff53189a10e16d870af80f5bedb71f562aa
2024-08-04 12:09:08 +00:00
Aleksey Dobrynin
ab45ebd22f [java, complete, import-module] enhance code completion ordering: support transitive dependencies and implicit imports
GitOrigin-RevId: 737e01da30f0619ecae83693062e8b22adb5f6f3
2024-08-02 16:06:21 +00:00
Alexey Kudravtsev
4ab5c49640 avoid highlighting the same text range twice
GitOrigin-RevId: 411430679ddb43185c4b6081524d3250982a72ff
2024-08-01 17:13:09 +00:00
Mikhail Pyltsin
ccf2a6bae5 [java-inspections] IDEA-356982 PsiImplicitClass is created for certain invalid code and renders the whole file gray
- skip implicit classes in unused analysis

GitOrigin-RevId: 6eb880108723b3623b0cc449d76f9f87942fc8b7
2024-08-01 16:00:34 +00:00