Commit Graph

6498 Commits

Author SHA1 Message Date
Tagir Valeev
9c6aeba5b4 [java] More tests for preview; minor fixes
GitOrigin-RevId: 7f72c5f68ab821e728eb0d5152f0910f48035046
2022-07-22 11:54:00 +00:00
Tagir Valeev
d3bb907595 [java-intentions] MethodThrowsFix: cosmetics in preview
GitOrigin-RevId: 56217a0aa6b136a88f812b0a9917f4361b0bb32e
2022-07-21 18:15:09 +00:00
Olga Klisho
628d00949b (java) fixing 0-tolerance tests
GitOrigin-RevId: cf89d3001fcceb0d8911e49bbc1d35a87f1cc476
2022-07-21 13:15:25 +00:00
Roman Ivanov
8ef4ee0e28 ConditionalBreakInInfiniteLoopInspection: introduce option to suppress inspection when there only one statement in loop
GitOrigin-RevId: 96d4c844279a5166a11705004a3dc3830a04ff3f
2022-07-21 12:17:50 +00:00
Alexandr Suhinin
888020ea77 IDEA-298318: report mismatch errors for deconstruction inside instanceOf
GitOrigin-RevId: 591cf3577babf47512e1fbc5bb70b182aa0c08ce
2022-07-21 11:31:55 +00:00
Alexandr Suhinin
3a63092336 IDEA-298324: report mismatch errors in recursive deconstruction patterns
GitOrigin-RevId: 31271e8a4020c9e3d2fed77f1f32f4a69e3b07cb
2022-07-21 11:01:18 +00:00
Alexandr Suhinin
c68519d5f1 IDEA-297396: fix illegal fallthrough for pattern guards
GitOrigin-RevId: 41a247c8a52df15c86fcd0acc934308034a2da65
2022-07-20 19:59:35 +00:00
Alexandr Suhinin
c7d05b20a8 IDEA-297405: check exhaustiveness in switches with deconstruction pattern
GitOrigin-RevId: 1a1724a0842f7c387524989d6178283891dfc7cb
2022-07-20 19:59:32 +00:00
Alexandr Suhinin
10e2fcda21 IDEA-297389: highlight mismatched deconstruction patterns
GitOrigin-RevId: 0a53c42751596aad5298520a0f23c731d7449fd5
2022-07-20 19:59:27 +00:00
Alexandr Suhinin
efc70d4da2 IDEA-297404: fix domination highlighting for PatternGuard
GitOrigin-RevId: 8e56462effa3602e8dca36cad3c87453a6d7ca95
2022-07-20 19:59:21 +00:00
Bas Leijdekkers
a719a82ae4 java inspections: implement preview for quick fix
GitOrigin-RevId: d2930f7ddab6bf3d761b20b1759ff83f0cc06605
2022-07-20 18:53:12 +00:00
Louis Vignier
e8d121713c [codeInspection] MyAddExplicitTypeArgumentsFix: support preview
GitOrigin-RevId: 2c2f2192db2bb108e824f534440f0eeee8451371
2022-07-20 16:48:47 +00:00
Roman Ivanov
f5621d553f [java] show user-friendly error message for patterns similar to calls in switch labels
GitOrigin-RevId: 09f4de4b1929950320511e853a00c2a3dc1e4fb0
2022-07-19 18:03:40 +00:00
Alexey Kudravtsev
7b56d66b34 cleanup
GitOrigin-RevId: 2aa4c714c3b566c82a5fde8a6f25cc667b2a23b8
2022-07-19 10:54:57 +00:00
Anna Kozlova
e35f056f85 [java] local can be final: accept lambda parameters with explicit types (IDEA-223120)
GitOrigin-RevId: a6ee13c64c0139ba0a68f318daf448182a0f3f1d
2022-07-19 08:45:04 +00:00
Anna Kozlova
09b8dc66e1 [java] add remove arguments to (implicit) constructor calls (IDEA-224760)
GitOrigin-RevId: 5984a6c6310e69275054d2ebb70717635683f490
2022-07-19 08:45:03 +00:00
Bas Leijdekkers
cd5d2f165e Improve description wording
GitOrigin-RevId: 0eb80f9222d382d9ea4a2a597f49724e6fef5f6a
2022-07-18 23:38:01 +00:00
Bas Leijdekkers
304a1c2df5 Highlight incorrect escape instead of entire string literal
GitOrigin-RevId: 5455c5b43f8b19161dfa23643c197c8136cbbeff
2022-07-18 23:37:59 +00:00
Bas Leijdekkers
b31a73dd10 Java: more accurate highlighting of illegal escape sequences in strings
GitOrigin-RevId: 6461c554d2e44cf4e33278daefa924c73d0ca662
2022-07-18 23:37:51 +00:00
Tagir Valeev
98eabb1d6d [java-dfa] Hardcoded contracts for before/after date-time methods
Part of IDEA-172428 Inspection: Object used as its own method argument

GitOrigin-RevId: aed3b56245e4c4cdca51d7d1e5ee53962698bcb6
2022-07-18 14:05:13 +00:00
Tagir Valeev
6c3dab6a9e [java-intentions] MethodThrowsFix: support preview in all cases
GitOrigin-RevId: 0331f694a3a16d037fb25ea339af047a59653922
2022-07-15 17:08:44 +00:00
Tagir Valeev
801e39b71e [java-intentions] Cosmetic
GitOrigin-RevId: a293a5f94d8ca6a1c88faec1d17938f411238ace
2022-07-15 17:08:41 +00:00
Anna Kozlova
296a40e090 [marked for removal] remove option to ignore usages in same project
revert IDEA-288824

GitOrigin-RevId: cffcf39beb53cd19b5a09e5232d9a5ecfd8ee859
2022-07-15 14:49:47 +00:00
Tagir Valeev
2448ed4a54 [java-intentions] WrapObjectWithOptionalOfNullableFix: preview-friendly
GitOrigin-RevId: 1ae02607b4fc7a5d9f846f1e60d0a885df127232
2022-07-14 12:17:57 +00:00
Tagir Valeev
bb4c5c56ad [java-intentions] MoveAnnotationOnStaticMemberQualifyingTypeFix: support method return type properly
GitOrigin-RevId: d37d06d29927e59ee18d0a4743f26a9d077ee6d6
2022-07-14 12:17:54 +00:00
Tagir Valeev
e11a05b7d2 [java-intentions] NormalizeRecordComponentFix: fix all option
GitOrigin-RevId: d00c27858554da75a9253ff1d873edaebf64f255
2022-07-14 12:17:51 +00:00
Andrey.Cherkasov
4f45bae7fe [java-inspections] RedundantTypeArgs: don't suggest to remove annotated type arguments
IDEA-297758

GitOrigin-RevId: 726214eacf6c2cb96db68821b8e100d5722d6a8a
2022-07-14 05:06:24 +00:00
Andrey.Cherkasov
dac46c6a42 Fix warning
GitOrigin-RevId: 8549dbb3e459154ff90f9453b4548bde9702b202
2022-07-14 05:06:23 +00:00
Bas Leijdekkers
abdccd20d1 Highlight illegal unicode escapes in Java comments (IDEA-297534)
GitOrigin-RevId: 8efa596ed24018650d709c1805d16edf8938b424
2022-07-13 21:18:45 +00:00
Tagir Valeev
cff8154475 [java-inference] Fix inference for case null: (case null -> was already supported)
Fixes IDEA-297390 Wrong `@NotNull` is inferred for switch with explicit `null` case label
Also: support switch expressions

GitOrigin-RevId: 5605eb5e4487c592597b839c26319de021ba2282
2022-07-11 17:02:03 +00:00
Tagir Valeev
0e66f0b536 [java-highlighting] IDEA-160446 Java. "Array type has too many dimensions" error is not highlighted
GitOrigin-RevId: 40ae7025e52f6be0486ad2e1cf3bf4a85e9904ea
2022-07-11 15:56:33 +00:00
Tagir Valeev
f0a1504c96 [java-inspections] Add a quick-fix to 'Field may be final' inspection to add implicitly written annotation
Fixes IDEA-138120 Inspections "Field may be 'final'" and "Declaration can have final modifier" should ignore configurable annotations.
Also make AddImplicitlyWriteAnnotation undoable and add preview

GitOrigin-RevId: 8bbcebb00543375ea68881ef18df7b08da33aeb5
2022-07-11 15:56:28 +00:00
Tagir Valeev
eb034a306e [java-inspections] MoveFileFix: preview-friendly
GitOrigin-RevId: 6aa9490c40da65702d269d9c43ef712a5d358687
2022-07-11 15:56:27 +00:00
Tagir Valeev
b190d44779 [java-inspections] MethodArgumentFix: avoid unsafe field warnings
GitOrigin-RevId: 98ddc7c182e4030bbd7293467ee4bc2a4f6057a2
2022-07-11 15:56:25 +00:00
Tagir Valeev
3aa2d348eb [java-inspections] ReplaceMethodCallFix, ReplaceFieldReferenceFix: preview-friendly
GitOrigin-RevId: 984192e2eb892cf1d3181850b406f635f4f294b9
2022-07-11 15:56:24 +00:00
Tagir Valeev
59810ee9a3 [util] Predicates class to reduce number of loaded lambdas
GitOrigin-RevId: a89c8375b79468afd0b263fe670b83dcf85b96f6
2022-07-08 16:40:46 +00:00
Nikolay Chashnikov
98a484f592 [workspace model] pull up oldEntity and newEntity to the base EntityChange class and simplify code which use it
Implementations of WorkspaceModelChangeListener rather often need to do something with the old variant of the entity and/or with the new variant. Pulling up corresponding properties to the base class allows us to write simpler code, which don't need to check actual class of EntityChange.

GitOrigin-RevId: d5f9c916aed01120eba66146d404db1742fae082
2022-07-08 12:53:51 +00:00
Tagir Valeev
a32aae2b9b [java-intentions] IDEA-165333 Add constructor parameter fix may create recursive constructor invocation
GitOrigin-RevId: 53be80dace37ccb9b9735d49d562b701404f995e
2022-07-07 15:47:44 +00:00
Tagir Valeev
06d63c351a [java-refactoring] Refactor InlineMethod refactoring to use CodeBlockSurrounder
Added SurroundResult#collapse method to collapse expanded code block back.
Now, InlineMethodProcessor is simpler and preserves semantics at the call site more often.
Fixes IDEA-297364 Inline Method changes semantic for a method throwing exception

GitOrigin-RevId: 2ceb23e372e2876202dac687048ac86fb23cfc3b
2022-07-07 15:47:34 +00:00
Tagir Valeev
6a91e1b247 [java-intentions] ChangeTypeArgumentsFix: preview-friendly
GitOrigin-RevId: fc3f5540dd0f0c608acca861569e239c5a115224
2022-07-04 18:34:33 +00:00
Tagir Valeev
8df93af88f [java-intentions] QualifyThisOrSuperArgumentFix: declare abstract getFileModifierForPreview to avoid warnings
GitOrigin-RevId: 3cfd309d9f416333b3349c8f76cb4de563439828
2022-07-04 18:34:27 +00:00
Anna Kozlova
4dbd3f96f3 [java] highlight deprecated forRemoval as normal deprecation when located in same project (IDEA-296468)
GitOrigin-RevId: 0a70a1e5b11e0ef353c615ae34eb22d7f9420d53
2022-07-04 12:06:28 +00:00
Tagir Valeev
63dac115ae [java-inspections] DeleteRepeatedInterfaceFix, AddTypeArgumentsConditionalFix: preview-friendly
GitOrigin-RevId: b8dc793c45a508402f15d8c48bc654caf0bef10d
2022-07-01 15:34:54 +00:00
Tagir Valeev
4bbceb75f7 [java-intentions] FlipIntersectionSidesFix: preview-friendly (now, really)
GitOrigin-RevId: 966c69a65b4f32e2f01fcdf34eee538a815f4dbd
2022-06-30 15:04:59 +00:00
Tagir Valeev
92a5282ab9 [java-intentions] ConvertDoubleToFloatFix removed; superseded with CastMethodArgumentFix
GitOrigin-RevId: 861631447c4281fd75f77545702e8540ed4ed38b
2022-06-30 08:49:35 +00:00
Tagir Valeev
3b01ccb40d [java-intentions] QualifyWithThisFix, QualifySuperArgumentFix, QualifyThisArgumentFix: preview-friendly
Also suppress inspection for batch-only fix in CanBeFinalInspection

GitOrigin-RevId: 057700463f96bff1f33b2e00ab48e9cb357a2383
2022-06-30 08:49:32 +00:00
Tagir Valeev
47b811fe9f [java-dfa] Properly implement increment/decrement for array operand
Fixes IDEA-296799 'Constant conditions & exceptions' false positive when incrementing an array value

GitOrigin-RevId: f018dc670016473a6cf80c06a91b80cb48afb4e0
2022-06-30 08:49:29 +00:00
Tagir Valeev
32ab86a790 [java-intentions] FlipIntersectionSidesFix: preview-friendly
GitOrigin-RevId: fd927d442cf1a3c8695d1c42eb6ce078a2be873c
2022-06-30 08:49:28 +00:00
Bas Leijdekkers
63c4ffc2bc global inspections: don't create incorrect link between class and its field initializer targets
GitOrigin-RevId: 838fc87a71409dc722a9821525845e573242a883
2022-06-29 20:02:33 +00:00
Bas Leijdekkers
e61d97c6e1 global inspections: build reference only once per element
GitOrigin-RevId: c7665b3fecc5cd8ea181ad7e844c191af1267dab
2022-06-29 20:02:27 +00:00