Commit Graph

110 Commits

Author SHA1 Message Date
Tagir Valeev
e79d3d8824 [java-highlighting] IDEA-374968 Red code in ConcurrentSkipListMap.java
(cherry picked from commit cfb9b5cbf965190668e9cb4cb9ed102f26fcd3f7)

IJ-CR-166980

GitOrigin-RevId: 529629a073d5107bd13a12203f0528b49e3b5613
2025-06-26 14:43:03 +00:00
Bas Leijdekkers
ef6e09bed9 Java: reference graph cleanup
GitOrigin-RevId: cf3ce322376b553ac8d54d1263de37d1534dc4e1
2025-02-26 15:17:46 +00:00
Tagir Valeev
5014925e91 [java-highlighting] Refactor unrelated default method analysis; extract JavaPsiMethodUtil
Part of IDEA-365344 Create a new Java error highlighter with minimal dependencies (PSI only)

GitOrigin-RevId: 1e7f4feab6cbaa3d38960a3c0e45aa5dd2def61a
2025-02-21 10:35:05 +00:00
Vladimir Krivosheev
051ed2529b cleanup
GitOrigin-RevId: 6fa4f979e0a6641885e2225eb985b13713373ac5
2024-12-26 14:56:01 +00:00
Bas Leijdekkers
d93f3a397d inspections: report unused enum classes
for "Unused declaration" batch inspection

GitOrigin-RevId: 04c25515d2cef8867823ea3659a4baab2167c58a
2024-06-07 14:19:07 +00:00
Bas Leijdekkers
32ee8e3135 [java] consider enum constants used in batch inspection when valueOf() is called (IDEA-293797)
GitOrigin-RevId: 787c7356063bfbc11bbdc751dba55dd76f142e84
2024-05-29 14:19:54 +00:00
Bas Leijdekkers
153827d95f Java: handle @Repeatable annotations better in “Unused declaration” inspection
GitOrigin-RevId: 677f2c52ac069497147398dce1b42709e78ff445
2024-05-09 12:47:21 +00:00
Bas Leijdekkers
57b1788fa5 java: track java usages of annotation methods in Unused Declaration inspection (IDEA-256632)
psi hack because UAST lacks annotation property references

GitOrigin-RevId: 9d5f2fd8e9d55584be60ca529512dd0714fb551d
2024-04-25 13:49:49 +00:00
Bas Leijdekkers
45cb0ab7d0 java: small cleanup
GitOrigin-RevId: 91d9a5fff0f0b9def8d204b4bbce9ff740115db4
2024-04-25 13:49:43 +00:00
Andrey Cherkasov
019a6852f4 [java] Make extension classes final
GitOrigin-RevId: 1aae04982598568a111e8c78b9a71c9d2b4aa150
2023-12-13 20:02:09 +00:00
Bas Leijdekkers
9bcb2a6194 Java: remove workaround hack now that UAST supports resource expressions (IJ-CR-119831)
GitOrigin-RevId: 803dadd65b91ac5c0c4ab9ad7aeef2c5c6ab3d5a
2023-11-17 02:23:59 +00:00
Bas Leijdekkers
8a3ec7ba0d Java: Unused Declaration - recognize resource expressions in batch mode (IDEA-330141)
GitOrigin-RevId: b382042eeb7b90301f4de90456da51026e045200
2023-11-12 18:00:11 +00:00
Bas Leijdekkers
6631881072 Java: Unused Declaration - recognize operator assignment as read access (IDEA-330149)
GitOrigin-RevId: 5561bd503c9f7bfe0fc5e6eca209d0f272ed50ec
2023-11-10 15:57:27 +00:00
Anna Kozlova
e2d7214918 [kotlin] ensure that UastCallableReferenceExpression preserves receiver expression
- uast based visitor in unused declaration should analyse receivers which might contain references to variables/functions/etc

- Currently simple references in receivers are not processed and thus test has false positive

^ KTIJ-23958

- KotlinJavaApiUsageInspectionTest.`test reference in callable reference` doesn't test actual problem because UastVisitorAdapter is used: meaning that psi hierarchy is traversed and converted to uast one-by-one.

GitOrigin-RevId: 01b2c31fe42181c428b2c8767dc18db73bdfd659
2023-08-08 07:37:39 +00:00
Anna Kozlova
ee5d687203 [uast] [unused declaration] false positive on implicit invoke call on properties (IDEA-295430)
GitOrigin-RevId: 3075f11d592ddbe6e076410ae4982a1f30c67eac
2023-07-28 12:59:08 +00:00
Bart van Helvert
b80b9317be [java] IJ-CR-103082 Check value arguments inside updateParameterValues
GitOrigin-RevId: 9745ac494644ab3269a9c7d02cfe8f681ba5f9da
2023-02-28 16:43:46 +00:00
Bart van Helvert
d34ad5345e [java] Support varargs and named arguments in SameParameterValueInspection
#KTIJ-13986 Fixed.

GitOrigin-RevId: 91663d30b62cdd067a7ec447b65edfcc9b2bba9a
2023-02-16 18:32:11 +00:00
Nikolay Chashnikov
8ce3039acf cleanup: get rid of usages of deprecated constants from PsiType (IDEA-309438)
GitOrigin-RevId: 3373eb8b47af51b9f6dd71e565f773d69e8a3218
2023-01-26 16:11:57 +00:00
Andrey Cherkasov
386f046723 Use pattern instanceof
GitOrigin-RevId: b75b48d4765ffcc0ba8688acb9045686972c33b2
2022-12-07 16:47:15 +00:00
Anna Kozlova
1796357cb5 [inspections] better naming
GitOrigin-RevId: 583501439c5744a094e4fae5ad7505cb9611e963
2022-06-29 08:37:31 +00:00
Anna Kozlova
b582eff8c3 [unused declaration] take into account non-local returns (IDEA-295261)
GitOrigin-RevId: 772f91c8fe5614b0075394979f383e2810a6d3a8
2022-06-07 06:24:10 +00:00
Bas Leijdekkers
4731580745 Global inspections: remove a bit of unnecessary code
GitOrigin-RevId: 2e1d77b32aadee4f048955670bfc6edb992d1e87
2022-06-06 11:52:52 +00:00
Anna Kozlova
6e59e68a61 [unused declaration] special treatment for kotlin callable parameters (IDEA-295201)
GitOrigin-RevId: a0e943f2874b8149dd7aadbba1b1dc6ceb808286
2022-06-01 19:50:18 +00:00
Anna Kozlova
4586e67197 [inspections] return from light elements utility
GitOrigin-RevId: ab9aabd6bec61af95b06d044eb17a736230b75a5
2022-06-01 13:54:33 +00:00
Bas Leijdekkers
7537121a6e global inspections: waitForInitialized() -> initializeIfNeeded()
GitOrigin-RevId: ff6f801191e0028b285b87099a6fe73bc2343238
2022-05-29 13:35:30 +00:00
Bas Leijdekkers
ae88c6cbb4 Fix unused declaration record false positives in batch inspection (IDEA-293902)
GitOrigin-RevId: 9f6e745abc93560315c708cf3e6806f86533ac1e
2022-05-29 13:35:27 +00:00
Anna Kozlova
891e69c69c [java] unused declaration: go back from light elements to source through uast (IDEA-294591)
GitOrigin-RevId: 1999fdfce3242a62cb6a9f5c450d06369999df09
2022-05-24 16:56:27 +00:00
Bas Leijdekkers
310e3b8f2e Global inspections: track if class is enum to simplify code a bit
(will also be used in the future for better "Unused declaration" inspection messages)

GitOrigin-RevId: a24d1d2e01fc7e0644ad06c506bac9d89e39fab3
2022-05-23 15:45:45 +00:00
Anna Kozlova
7e11fe7574 [inspections] support property syntax for unused return value (IDEA-294487)
GitOrigin-RevId: 0d1d9df9cc1c9cd59b19b3a43e14cfe5b6bd47ac
2022-05-23 12:20:34 +00:00
Bas Leijdekkers
213c72182e Fix false positive on method called from subclass in the same file (IDEA-269128)
for "Declaration access can be weaker" global inspection

GitOrigin-RevId: 2d89a3eeb9f2bc8ffe13e1d57dfff94169a616c6
2022-04-17 22:57:09 +00:00
Bas Leijdekkers
77c2775063 Revert "java [unused declaration] - initial kotlin accessors support (disabled by default)"
This reverts commit e4055680

GitOrigin-RevId: 7f359f0b0c7c8e72b3bd011e40f9c0965821311a
2022-04-06 14:11:30 +00:00
Bas Leijdekkers
7f4d8f5164 global inspections: minor optimization/simplification
GitOrigin-RevId: fa92e37580a7c2e358cf139656c3144d3d6c43b0
2022-03-02 16:00:41 +00:00
Ilyas Selimov
df2321505f java [unused declaration] - initial kotlin accessors support (disabled by default)
GitOrigin-RevId: e40556803447e42af014a67c36f66affea258f52
2022-02-23 14:16:15 +00:00
Ilyas Selimov
4572835609 java [unused declaration] - switch on functional ref nodes
GitOrigin-RevId: b79fa6d91931bcc2c47f6f363f4a099736000d44
2022-02-09 12:40:24 +00:00
Bas Leijdekkers
8e71b6ca0d [global inspections] remove unneeded parameters and introduce variable to simplify code
GitOrigin-RevId: 6f5f4469960ef4291e6d1438d6ef710cb1307e95
2022-01-25 09:55:28 +00:00
Ilyas Selimov
c7d80fb16a [java unused declaration] - excluded functional ref node out of the graph
GitOrigin-RevId: 28ca95ff4709b8c7466abee73054d1bbb52ee28a
2022-01-19 08:40:35 +00:00
Bas Leijdekkers
b3dcce0941 [global inspection] more wait for initialized and logging to fix race conditions
GitOrigin-RevId: 5d160099032a99d19ae93984ea310565e403fbe0
2021-12-16 15:27:44 +00:00
Bas Leijdekkers
d1bacc33fc [global inspections] one more initialization check
GitOrigin-RevId: ead649d4166a993c479c05d54026494f806951ca
2021-10-19 19:55:25 +00:00
Bas Leijdekkers
37e358746c [global inspections] add more initialization checks
GitOrigin-RevId: 4979a1854485bae2b619cf14d2be292ca704ff69
2021-10-18 23:34:36 +00:00
Bas Leijdekkers
a9da3dd5ce [global inspections] wait for initialization in a few more places (IDEA-179389)
GitOrigin-RevId: f3e1b24eee0b8b1f259995abc0fac82ed07607c3
2021-10-18 23:34:20 +00:00
Anna Kozlova
3711123cf0 [java] [unused declaration]: process record's canonical constructors
EA-296213 (plugin) - CCE: RefJavaManagerImpl.getParameterReference

GitOrigin-RevId: 3b01695e5ff11d45fdcfdf6c1ffeb22a67b194bf
2021-10-18 17:01:14 +00:00
Bas Leijdekkers
b3ac7c53f3 [global inspections] try to avoid race conditions by waiting until elements are initialized before building references
GitOrigin-RevId: de52d36337741d435ea14a81b77d5340b355f905
2021-10-12 14:47:45 +00:00
Bas Leijdekkers
5e3a4a6417 [global inspections] cleanup
GitOrigin-RevId: 81df9e13fc773ab658badbb6cced2fbd4834aaa2
2021-10-11 22:27:31 +00:00
Ilyas Selimov
6b74c12eab [java] - unused declaration rework for functional expressions
GitOrigin-RevId: e2f2188edf79fddd902c038bdfdea072eed01bfe
2021-10-11 05:51:42 +00:00
Bas Leijdekkers
53352a5d6d [global inspections] cleanup
GitOrigin-RevId: d4dfbb1f68ebca3dfd427a34638a744c209ed833
2021-09-29 12:05:00 +00:00
Ilyas Selimov
1b4c297f74 IDEA-158821 - added an edge between refFrom and lambda/method ref parameters where it's needed
GitOrigin-RevId: 946c0073473e6a5f68da422518cdc137f9224601
2021-08-19 10:28:30 +00:00
Anna Kozlova
612d647e64 [global inspections] remove redundant cast
GitOrigin-RevId: d944bc7de6acf4c40074a3580cb8e2289d10c698
2021-06-22 19:26:12 +00:00
Anna Kozlova
2170b5c355 [global inspections] avoid CCE for anonymous classes in enum constants
GitOrigin-RevId: 7083ee1a97d43467d98ee5b15b122304397da0f4
2021-06-18 20:10:36 +00:00
Anna Kozlova
644bbb10dd [global inspections]: CCE
kotlin enum constant with anonymous class source corresponds to the field, not class (which is probably wrong) but here the cast is redundant anyway

GitOrigin-RevId: cf66ff194853f4d28c4987b12e8016112da199e3
2021-06-14 10:58:08 +00:00
Ilyas Selimov
937831e0de inspection-integration - exclude an edge between annotation access expression and annotation method
GitOrigin-RevId: bb7258de864e2b32529e679785d74ef145a43e33
2021-02-10 07:23:40 +00:00