Yann Cébron
1d0ac8c33e
[devkit] "Extension class should not be public": show dedicated hint for services (IJPL-115185)
...
GitOrigin-RevId: 8ddceed617020cacc5e5c2cd3dfab5d3b0fbd8ad
2024-06-20 14:27:35 +00:00
Yann Cébron
81971d10ee
IJPL-156832 DevKit: extract "element should be defined in..." checks for IDEA project to separate internal inspection
...
GitOrigin-RevId: dc8cffb5861d5fa31e979112270ceab8758357d4
2024-06-19 13:30:10 +00:00
Yann Cébron
3a4d44fce0
[devkit] PluginXmlFunctionalTest.testExtensionI18n: fix testdata
...
GitOrigin-RevId: 8af44344d517e3714e048f6914d401a57e9d5375
2024-06-04 13:53:05 +00:00
Yann Cébron
e11bc891e7
[devkit] PluginXmlFunctionalTest.testExtensionsHighlighting: fix testdata
...
GitOrigin-RevId: cb8a8bb9422fb054f167ad7807c31d5427a3b0cb
2024-06-04 13:53:01 +00:00
Yann Cébron
08dd3d9064
[devkit] support line marker to plugin.xml for EPs with >1 CTOR parameter (IDEA-351950)
...
add more tests
GitOrigin-RevId: 671729c6a760a7b8aae4d39a51f5d8afc830a0ff
2024-04-17 15:24:55 +00:00
Yann Cébron
5adb80d28b
[devkit] support line marker to plugin.xml for EPs with >1 CTOR parameter (IDEA-351950)
...
GitOrigin-RevId: 233d5d39ff8e9efb8140235ab17b44462c341c5a
2024-04-17 12:02:19 +00:00
Yann Cébron
ab7e136f01
[devkit] Plugin Model V2: no "experimental" highlighting for external plugins (IDEA-261862)
...
GitOrigin-RevId: 9eb47c0d54bb2470d22d494e8a7c433c745d89ba
2024-04-04 12:29:46 +00:00
Yann Cébron
0aeb6c9163
[devkit] DOM: remove obsolete "on-demand" attribute (IDEA-297005)
...
GitOrigin-RevId: aca260207fa8830f5ea5e682b9b59a92ba2ba9cf
2024-04-04 12:29:40 +00:00
Andrey Cherkasov
32e4248809
[devkit] LightServiceMigrationInspection: configurationSchemaKey must not be specified
...
^IDEA-254577
GitOrigin-RevId: db3871b563b94f9d55cf607326ebca8743756e60
2024-02-28 21:41:25 +00:00
Zhanna Gorelova
984e0ea1f6
[dev-kit] description gutter should not be added if folder name is not equal to class name (case should not be ignored), otherwise intention description won't be found
...
GitOrigin-RevId: 82518ebd5d8a434ff3a3ef30ede9db6410705d63
2024-02-14 18:18:23 +00:00
Karol Lewandowski
bf33f56ded
IDEA-330739: Devkit: extend "Cancellation check in loops" inspection
...
- Added support for forEach() and similar methods, and ContainerUtil.process()
GitOrigin-RevId: fc9b66f3584cf94d603d9a84825f4142de92544d
2024-02-08 19:53:11 +00:00
Yann Cébron
6fc6517669
[devkit] Fix plugin.xml recognition when comment contains angle brackets (IDEA-345026)
...
close #2658
GitOrigin-RevId: 5de43cd45ffef6e8b4435b0f6de978c9eca1b56d
2024-02-06 23:34:53 +00:00
Andrey Cherkasov
6e95446bec
[java] The 'Make class final' quick-fix must check final methods
...
...and remove their 'final' modifier. Since final classes cannot be inherited, marking a method as final is unnecessary and confusing.
^IDEA-309065
GitOrigin-RevId: de044d57c690772aefc7044d87159c42ebc92907
2023-12-18 20:25:02 +00:00
Andrey Cherkasov
519ffd2508
[java] The 'Make class final' quick-fix must check protected members
...
...and weaken their visibility. This is necessary because protected members in final classes may be confusing.
^IDEA-309065
GitOrigin-RevId: 33e814c2b11708616e110abbdead20d3e9f2b75d
2023-12-18 17:55:26 +00:00
Andrey Cherkasov
e59d2a751e
[devkit] LightServiceMigrationInspection: provide quick-fix
...
...for the "Service can be converted to a light service" warning. The provided quick-fix annotates the service class with '@Service' and removes its registration from the 'plugin.xml' file.
^IDEA-254577
GitOrigin-RevId: 55cace08aa3beade8fb5e28532a29df459e2c1f0
2023-12-13 20:03:28 +00:00
Andrey Cherkasov
2e5cd31c49
[devkit] LightServiceMigrationXMLInspection: provide quick-fix
...
...for the "Service class annotated with '@Service' must not be registered in the 'plugin.xml' file" warning. The provided quick-fix removes the service registration from the 'plugin.xml' file.
^IDEA-254577
GitOrigin-RevId: fdb96913323c60dc8551ff55dac24c04b3299dff
2023-12-13 20:03:20 +00:00
Andrey Cherkasov
ddabcc31c7
[devkit] Simplifiable service retrieving: fix false positives
...
The inspection must not suggest replacing a service retrieving call if this call is an initializer of a variable annotated as @Nullable.
GitOrigin-RevId: f3f219dacd41f2540085bbb076779be1e742e0b7
2023-12-07 16:47:39 +00:00
Andrey Cherkasov
73d147c61b
[devkit] Simplifiable service retrieving: fix false positives
...
The inspection must not suggest replacing a service retrieving call if this call is a return expression of a method with a nullable return type.
GitOrigin-RevId: 875181b5d03e4842e186524cb9b3f7756ba81290
2023-12-07 16:47:36 +00:00
Andrey Cherkasov
28108d64bb
[devkit] Extension class should be final and non-public: false positives
...
The inspection must not warn on classes annotated with any of the VisibleForTesting annotations.
^IDEA-309065
GitOrigin-RevId: 6a9395c41b89c4c28bf9131d5c5de2f60127e517
2023-12-05 21:56:20 +00:00
Andrey Cherkasov
6904c08bc4
[devkit] Extension class should be final and non-public: false positives
...
The inspection must not warn on classes that have inheritors.
^IDEA-309065
GitOrigin-RevId: 16b93c4bc04ea2e84e7fabe1c663cbeebe7346f6
2023-12-05 21:56:16 +00:00
Andrey Cherkasov
7bef3fb7b8
[devkit] Simplifiable service retrieving: fix false positives
...
The inspection must not suggest replacing service retrieving calls with a `getInstance` call if a `getInstance` method has a nullable return type.
GitOrigin-RevId: cd8a36698f0c1efb4c6af27962554ae36ba7266a
2023-11-29 13:31:50 +00:00
Andrey Cherkasov
99d2b27c9d
[devkit] "Incorrect service retrieving" inspection: false negatives
...
Added support the `ComponentManager#getServiceIfCreated` method
GitOrigin-RevId: 7eb6c0c157327a7ea8b4f3d69f0dac19003d8b37
2023-11-23 21:53:25 +00:00
Andrey Cherkasov
9e9ed6eb11
[devkit] The "Mismatch between light service level and its constructor" inspection: false negative
...
IDEA-334607
GitOrigin-RevId: b3fcda025cba7de82939b985c0447f2e4f80f862
2023-10-11 13:19:11 +00:00
Karol Lewandowski
dbb74a9c98
IDEA-334137: Delete UseCoupleInspection
...
GitOrigin-RevId: d32b83ebf9cef84ea724d239ca2d783fa327d21b
2023-10-11 09:51:59 +00:00
Andrey Cherkasov
c7e0b8adeb
[devkit] The "Simplifiable service retrieving" inspection: fix false positive
...
IDEA-333347
GitOrigin-RevId: 585bd8e37e60c2da24f553a250dd2ba87374ef6a
2023-10-03 16:15:46 +00:00
Andrey Cherkasov
073114cdb2
[devkit] Split the "Incorrect or simplifiable retrieving service" inspection into two
...
IDEA-327590
GitOrigin-RevId: 721b34c773e16b93cc593080ba2dbc130606ed40
2023-10-03 04:01:17 +00:00
Andrey Cherkasov
9264913ca1
[devkit] Fix the ServiceUtil.kt methods according to the fact that the default service level is application-level
...
IDEA-330430
GitOrigin-RevId: 5ba4b258d2c18c9c014397c1dd1280375acc9020
2023-09-27 19:27:13 +00:00
alexey.afanasiev
1b1e3f6df0
IJ-CR-114480 QD-6980 Addressing review. Rewrite checking if id is known.
...
GitOrigin-RevId: 6485588f554c30a5fe692a1a2e489bf5d67ddba7
2023-09-26 23:54:54 +00:00
alexey.afanasiev
a6fdafbbd3
IJ-CR-114480 QD-6980 Addressing review
...
GitOrigin-RevId: a36f346e8973d2a2cd3b0d9bac986f2081d4d18f
2023-09-26 23:54:50 +00:00
alexey.afanasiev
c4d106f610
QD-6980 Create UnknownIdInMetaInformationInspection for validating ids in metaInformation.json
...
GitOrigin-RevId: fa79c1138250d4a3d3a05e2d009513fb3b7ba353
2023-09-26 23:54:40 +00:00
Yann Cébron
6a50833d3c
IDEA-317306 plugin.xml: code insight for EP com.intellij.codeInsight.declarativeInlayProvider
...
support group attribute code insight
GitOrigin-RevId: 3968ede2b0eac5844a9e39b8e4df26fb43b209c3
2023-09-21 09:12:58 +00:00
Yann Cébron
893c3c8a1f
IDEA-317306 plugin.xml: code insight for EP com.intellij.codeInsight.declarativeInlayProvider
...
I18n attributes
GitOrigin-RevId: 4f1c426163e51a0abe95cf119b55b49f3d49e875
2023-09-20 10:19:13 +00:00
Karol Lewandowski
ab8201d58c
IDEA-323204: Add tests for deep inheritance
...
GitOrigin-RevId: d26892d35104dbef2c64266050551010b209f27a
2023-08-30 15:29:22 +00:00
Elena Lyulina
9db39a03d2
[devkit] IDEA-323201 simplify test data, improve wording, make class internal
...
GitOrigin-RevId: efb1f88a92264c43790383ca695874cc7424f3ea
2023-08-25 00:27:40 +00:00
Elena Lyulina
4a112d1970
[devkit] IDEA-323204 implement new inspection
...
GitOrigin-RevId: 379d6e0776d132ee356ba62db23660ca388ea137
2023-08-24 14:49:51 +00:00
Elena Lyulina
7b2a2bd293
[devkit] IDEA-323201 add inspection implementation, ensure no intersection with Companion object in extensions
...
GitOrigin-RevId: 38d092a7d9a7a43e5c7a1032a93dd5c8db9d65e6
2023-08-23 11:03:13 +00:00
Elena Lyulina
4701e0fd21
[devkit] IDEA-298703 improve naming, add a check for backing fields in kotlin
...
GitOrigin-RevId: 5e74319e790c4246b64e6d5f57c51c6930dbf19f
2023-08-22 10:52:55 +00:00
Yann Cébron
747ff771ba
IDEA-327715 Plugins: Improve handling of "No display name is specified for configurable"
...
GitOrigin-RevId: bda811d0e3e38fd9bc054bc43804e841fadcef01
2023-08-08 19:11:35 +00:00
Yann Cébron
cbaab2106b
IDEA-327236 Devkit: verify EP com.intellij.statusBarWidgetFactory has defined id attribute in plugin.xml
...
refine message
GitOrigin-RevId: acea3e8ac6292e07589ec219787aeb5cba752495
2023-08-07 09:13:43 +00:00
Yann Cébron
4db4c2dece
IDEA-327236 Devkit: verify EP com.intellij.statusBarWidgetFactory has defined id attribute in plugin.xml
...
GitOrigin-RevId: 242d9f39f97254e61a64f8222d480ab1595b5f72
2023-08-02 10:39:34 +00:00
Andrey Cherkasov
cc230391c5
[devkit] Rename the inspection and its error message and fix the description
...
IJ-CR-102810
GitOrigin-RevId: 49d74d790ee90f75a248413f5ae16b504c9d8afb
2023-06-23 17:07:50 +00:00
Andrey Cherkasov
719b7cdae1
[devkit] RetrievingServiceInspection: refactoring
...
IJ-CR-102194
GitOrigin-RevId: e993138435dff02876d6611248f52cce90823eb1
2023-06-18 18:33:38 +00:00
Andrey Cherkasov
d9cba03c9d
[devkit] RetrievingServiceInspection: report retrieving unregistered service
...
IJ-CR-102194
GitOrigin-RevId: 965ce37f0981058ade7cb425974d8ddfa8e6065e
2023-06-18 18:33:34 +00:00
Andrey Cherkasov
f96d25fe8d
[devkit] Do not report service classes that contain a check on the unit test or UI-less mode
...
IJ-CR-105402
GitOrigin-RevId: cc3e83f7e6e6f93f663c43aea66a3680e8c264b4
2023-06-18 18:33:31 +00:00
Andrey Cherkasov
1d45043879
[devkit] "A service can be converted to a light one" inspections: fix the error messages
...
GitOrigin-RevId: 3f6b50f4a1f9481da3ada69a82932f237c154bc2
2023-06-17 23:00:36 +00:00
Yann Cébron
77435029e9
IDEA-322654 Devkit: Inspection description checker inspection - support IntentionAction with skipBeforeAfter=true
...
GitOrigin-RevId: 36ca4e229fa8a789969f300aa77921e2c6f1341a
2023-06-15 18:42:35 +00:00
Karol Lewandowski
543599b81c
IDEA-284442: Fix issues:
...
- catch clauses from outer try expressions where reported, even if nested catch block handled PCE/inheritor
- all generic exception catch clauses where reported when PCE thrown implicitly
GitOrigin-RevId: f036ac5b37297a61e2999eeca1e3bb89eb026839
2023-06-01 23:01:37 +00:00
Karol Lewandowski
c8c1a876a2
IDEA-284442: Change level to ERROR
...
GitOrigin-RevId: 7a8593bf83e513004ebe5e74498ba715f63aa719
2023-06-01 23:01:31 +00:00
Yann Cébron
e612812f02
[devkit] remove accidental char in test data
...
GitOrigin-RevId: 16acef5da8e7f292fd9be497aeca0852f07dff2d
2023-06-01 12:56:14 +00:00
Yann Cébron
9b2e7ae309
IDEA-321405 Plugin Devkit: highlight EP properties marked with ApiStatus.ScheduledForRemoval
...
GitOrigin-RevId: 473f1968e0099430cfdeb23ca180e56d9c20cc75
2023-05-31 19:46:29 +00:00