Commit Graph

1053 Commits

Author SHA1 Message Date
Chris Lemaire
92778a057b [gh/gl] Fix review-in-editor not starting (IJPL-186195, IJPL-187199, IJPL-181783)
#IJPL-187199 Fixed
#IJPL-186195 Fixed

Cause of which is a threading exception on loading `.getContent()`


(cherry picked from commit eec980bbaf107e2caa4f08c5150e74b773e0593b)

IJ-CR-163488

GitOrigin-RevId: 602b08ae6568932027bd7db7f7aa00227cf22765
2025-05-23 12:08:00 +00:00
Chris Lemaire
b69afb1170 [gitlab] Fix missing items in changelist due to pagination links missing (IJPL-183235)
#IJPL-183235 Fixed

(cherry picked from commit db052c949fc3bd734000ec4b66dd352e61040deb)


(cherry picked from commit c68493b635b4a44597325dd8c3b1133bbc9880f1)

IJ-CR-161095

GitOrigin-RevId: 39edbd3bd9d59e7231b8efab1458b4c477ad8f9b
2025-04-28 14:27:41 +00:00
Nikita Katkov
4203d85a3a [github & gitlab] IJPL-171311 Bundle ultimate plugin versions into community IDEs built by ourselves
The existing gitlab.community and github.community modules that describe community versions of plugins with less functionality included do still exist intentionally. This is required for external developers to be able to build IDE from community project sources and get both plugins working there out of the box. Thus community plugins are still listed in IdeaCommunityProperties and PyCharmCommunityProperties. This part is only required for third-party folks. As for internal builds, they employ a build context produced by `org.jetbrains.intellij.build.IdeaUltimateBuilderKt.createBuildContextForCommunityProduct` which in turn prefers github.ultimate and gitlab.ultimate plugin distributions over community ones


(cherry picked from commit e8233c7133d63abe3aefa684cc57ed9bad9fee64)

IJ-CR-156816

GitOrigin-RevId: c7058bba3734d4509a66d48b338466f5e0e7b05d
2025-03-11 22:16:21 +00:00
Konstantin Nisht
c3502a782e [threading] IJPL-149765: Rename writeAction to edtWriteAction #1
GitOrigin-RevId: 26f827981587deb51f43b397615f6c598e510771
2025-02-19 11:28:22 +00:00
Vladimir Krivosheev
2db9ad8ef6 update bazel files
GitOrigin-RevId: 5bf54290c411048009614bacceeb742a53d5c0a4
2025-02-17 08:47:14 +00:00
Vladimir Krivosheev
a59247fe0f update bazel files
GitOrigin-RevId: 9c0599fc72c5eefddedd21b65242c39f1f6748fa
2025-02-14 21:08:26 +00:00
Ivan Semenov
cbb13b3cd1 [gitlab] remove dependency on json plugin
GitOrigin-RevId: 1aca929119f673bac61854f955ae1251954bf80b
2025-02-14 19:34:32 +00:00
Stanislav Ruban
59ffc34acf [migration to Kotlin LV 2.2] Update JPS modules w/ Kotlin w.r.t. KTLC-3
GitOrigin-RevId: d6fccd2ac258a15d122402e2fb1ea6db070703a5
2025-02-13 20:31:15 +00:00
Vladimir Krivosheev
e9f6e4644d update bazel files
GitOrigin-RevId: c332387fc13f74305d2440f3c738be00fa0ef25a
2025-02-07 10:05:46 +00:00
Nikolay Chashnikov
f3cd548a92 [yaml] refactoring: use dependency on 'intellij.yaml.backend' module instead of v2 dependency on YAML plugin (IJPL-176102)
Technically, currently this is the same, because 'intellij.yaml.backend' module is registered as the embedded module of YAML plugin, so it's loaded by the main plugin classloader. However, dependency on the module is more explicit. Also, we may need to temporarily convert 'intellij.yaml.backend' to an optional module to reuse the same plugin.xml for the frontend process.

GitOrigin-RevId: bf96ed0c60cb335fdb0e592a619e1425cb322f2b
2025-02-06 19:56:54 +00:00
Nikolay Chashnikov
549afb8e88 [yaml] refactoring: rename intellij.yaml.editing to intellij.yaml (IJPL-176102)
There is no need to use a longer name for the common part after the old 'intellij.yaml' was renamed to 'intellij.yaml.backend'. Also, this allows keeping the old main module name for the YAML plugin after moving 'plugin.xml' to this module.

GitOrigin-RevId: 1509abc515a490c949097dedbcf26fb12925c101
2025-02-06 19:56:54 +00:00
Nikolay Chashnikov
021bd3ea95 [yaml] refactoring: rename intellij.yaml to intellij.yaml.backend (IJPL-176102)
This module isn't used in a frontend variant of the IDE, so it should use the '.backend' suffix for consistency and to avoid confusion.

References from the build script to the 'intellij.yaml' module aren't changed in this commit because 'intellij.yaml.editing' module will be renamed to 'intellij.yaml' in the next commit, and plugin.xml will be moved to it.

GitOrigin-RevId: 1c535a9a02bdccd89f46cdad71e34064b1dab854
2025-02-06 19:56:54 +00:00
Leonid Shalupov
2f2ab1fe14 IJI-2422: community/plugins: move resources under resources root
GitOrigin-RevId: 8eb1f83f015e7e1a7626f69f9e64d7c328ba7765
2025-02-05 04:43:28 +00:00
Leonid Shalupov
e4e5753846 housekeeping: remove unused imports
GitOrigin-RevId: ccba6d05260f5eb551ffa87e0d8a38dc93148a3a
2025-02-04 11:00:15 +00:00
Vladimir Krivosheev
f1121010f7 cleanup (final, visibility)
GitOrigin-RevId: 8faa58a751c19a553c1ba09763e56795cb36ed38
2025-01-31 08:55:04 +00:00
Ivan Semenov
55f9b1883f [gitlab] implement account registrar to be used by external plugins
#IJPL-174997 Fixed

GitOrigin-RevId: 6edc215931ac815aa071731c0588cb1095f188d0
2025-01-15 13:18:53 +00:00
Vladimir Krivosheev
51985dbbd7 update bazel files
GitOrigin-RevId: 4259d00cb643511fd5a3a2e6b30d18a8ccc173f6
2025-01-06 00:16:01 +00:00
Vladimir Krivosheev
9fec499a7d don't export intellij.flex.shared
GitOrigin-RevId: 4ab9b4527cedcf53794583681edccda4c47d4668
2025-01-06 00:16:00 +00:00
Vladimir Krivosheev
0bc1cf1557 update bazel files
GitOrigin-RevId: 7320d3eff3aba093692ce66839c720ece6d7c4db
2024-12-30 11:28:24 +00:00
vladimir.petrenko
01be105976 IJPL-173842 gitlabci: load common GitLab module as "embedded"
Changed the loading type of the `intellij.vcs.gitlab` module to "embedded" in both Ultimate and Community plugin configurations. This ensures that the module is loaded only when explicitly required and improves plugin initialization behavior [AI generated].

Fix the problem "com.intellij.diagnostic.PluginException: Class org.jetbrains.plugins.gitlab.ui.GitlabCiIconProviderKt must not be requested from main classloader of org.jetbrains.plugins.gitlab plugin. Matches content module (packagePrefix=org.jetbrains.plugins.gitlab., moduleName=intellij.vcs.gitlab). [Plugin: org.jetbrains.plugins.gitlab]"

also see 4a5b0c098eb361c15a2bbb323da78df0f7e9f99d

GitOrigin-RevId: 6dbd78a33d45a7800caf2b8d269297cd903a4971
2024-12-19 10:28:03 +00:00
vladimir.petrenko
d9f77b596b IJPL-173842 gitlabci: basic code-insight support for "stage" symbol
it is a squash commit of several commits. It was made to avoid code appearance in the community part of the repository and because the gitlab-plugin layout (structure of the related modules, files, etc.) was changed. The messages of the squashed commits are:
- IJPL-84197 GitLab CI: add navigation from `stage` usage to its declaration
- IJPL-84197 GitLab CI: bidirectional navigation refs<->declarations for "stages" using Symbol API
- IJPL-84197 GitLab CI: completion for "stages" via Symbol API
- IJPL-84197 GitLab CI: rename "stages" in "in-place" mode via Symbol API considering "broken" ranges
"broken" ranges - ranges, that are passed into Pointer restoration function (see `GitLabCiStageSymbol.createPointer`) from IDE at the moment when Enter is pressed in the end of Rename action in "in-place" mode. "end" values of such ranges are equal to "start" values, and this looks like not expected behavior. And hacks are needed to consider these "broken" ranges.
- IJPL-84197 GitLab CI: support quoted strings for "stage"-values as well as plain text
- IJPL-84197 GitLab CI: fix problem: "stage declaration is not highlighted when cursor is on usage"
plus some refactoring
- IJPL-84197 GitLab CI: turn on registry flag
for simpler future tests running
- IJPL-84197 GitLab CI: tests for `stage` symbol editor support
- IJPL-84197 GitLab CI: move code to gitlab-ultimate module

GitOrigin-RevId: f49ea2717bfa4764abefee5ef81a9e474690754a
2024-12-19 10:28:02 +00:00
Vladimir Krivosheev
98799639aa do not use _test as lib - test targets do not support this
GitOrigin-RevId: f2f49db4294b6a64040dbbd5f1d95e972cbd70a3
2024-12-15 18:32:30 +00:00
vladimir.petrenko
a231bd507d IJPL-171311 gitlab: fix modules types in .iml files of recently created gitlab community and ultimate modules
GitOrigin-RevId: a1051995f5583e7f17549bf658bebfbbe2b839bc
2024-12-11 15:51:16 +00:00
Chris Lemaire
c5ee19e82a [gh/gl] Add back withInitial for resolving conflicts locally
Without this, I expect it to stay stuck until commits
can be fetched. Better to show something early.

GitOrigin-RevId: b1ef74d6306981ad177ec08d806600fb5d9cf220
2024-12-11 14:19:10 +00:00
Chris Lemaire
f37d281d9e [git4idea/gh/gl] Refactor ResolveConflictsLocallyViewModelBase to be a function
GitOrigin-RevId: c4b95c6f67b935c637f7cf49890cc470b63ea0e5
2024-12-11 11:13:36 +00:00
Vladimir Krivosheev
271ef59f4e do not export intellij.yaml.editing
GitOrigin-RevId: 79434088ab9f4a8ef5ef3477bf9f8c0341123d50
2024-12-07 13:12:27 +00:00
Ivan Semenov
0ba016e1ec [collab] publish async review diff API
GitOrigin-RevId: 14a2eb6c1c2d4d95380ff00399299bb4bd33a5f5
2024-12-04 17:54:09 +00:00
vladimir.petrenko
3c4fa759c2 IJPL-171311 gitlab: uniq package for each plugin/module descriptor as a requirement for Plugin Model V2
(cherry picked from commit 1d79748041d089b0e710961fe4f7e60872690383)

IJ-CR-150169

GitOrigin-RevId: d79e8f50fc8011381e350353439b2f85691f34ca
2024-12-04 15:20:24 +00:00
vladimir.petrenko
d8811d2c9e IJPL-171311 reintergrate new gitlab modules/plugins into intellij products building infrastructure
(cherry picked from commit 6ed40308cf10dadc3c43c7fe1103946a0de5dabd)

IJ-CR-150169

GitOrigin-RevId: 80f009abb2e50424959249280de9dfb585134bfe
2024-12-04 15:20:24 +00:00
vladimir.petrenko
b933241932 IJPL-171311 reorganize xml-s between "intellij.vsc.gitlab", "-.community" and ".ultimate" modules
(cherry picked from commit ce0ccba6be83fa341b8a035b099114e0af8647ed)

IJ-CR-150169

GitOrigin-RevId: c90c67b3e961929c4f9fa6fff29f67d39e29c608
2024-12-04 15:20:24 +00:00
vladimir.petrenko
21e80ad257 IJPL-171311 create "intellij.vsc.gitlab.community" module
it is only a first step of sawing "intellij.vsc.gitlab" module into a "intellij.vsc.gitlab" module and a "intellij.vsc.gitlab.community" plugin-module


(cherry picked from commit 2711465aa7fdd6261dab7f55d2aaf2a5c1c78c7d)

IJ-CR-150169

GitOrigin-RevId: a0a40647ffba431448b1997d51071d141ed555f3
2024-12-04 15:20:24 +00:00
Ivan Semenov
f06169e3a7 [github] add default impl to polymorphic DTOs
This ensures forward compatibility

GitOrigin-RevId: b1192cd40b7fa86d9f32ff1aade8ec602d70e5ed
2024-12-02 13:26:23 +00:00
Vladimir Krivosheev
17916c90f8 libraries -> lib, resources, opt-in, test deps
GitOrigin-RevId: db66ee95dcb0f0553b40c9cc56cd6afed8634cdd
2024-11-27 13:53:42 +00:00
Yann Cébron
60daf15cdd [all] plugin.xml: replace <reference> id with ref (IJPL-171993)
GitOrigin-RevId: af77ae2b1a15450c2e9d8defd2f8aa310ebe25d5
2024-11-21 14:54:23 +00:00
Chris Lemaire
4b48f192e2 [gh/gl] Add a close button to close new comments in gutter (IJPL-82785)
#IJPL-82785 Fixed

GitOrigin-RevId: f92d7ef884a229df27fe9ae0b825bf142491ee63
2024-11-21 11:37:26 +00:00
Chris Lemaire
5cdad54da9 [github] Fix NPEs for some more locations where localizedMessage is used (IJPL-171277)
GitOrigin-RevId: c7780a3a7565bf1829cc62cdab7e081aed2b8e08
2024-11-21 07:15:49 +00:00
vladimir.petrenko
ec90d7fdb9 IJPL-171311 gitlab: fix a path in test
GitOrigin-RevId: bc25e59136ba4d3e3da710900c2d71d488011508
2024-11-15 17:45:39 +00:00
vladimir.petrenko
a125413b52 IJPL-171311 gitlab: reimport moved gitlab module in intellij (ultimate) and intellij/community (community) projects
GitOrigin-RevId: f2fca62cc2b5ac4d9bae32e7d10a2a7e3789c7d0
2024-11-15 17:45:39 +00:00
vladimir.petrenko
74d15eda9b IJPL-171311 gitlab: move all files from .../gitlab to .../gitlab/gitlab-core folder
GitOrigin-RevId: fe9620907c27e835336bb6c2b9eda607b8c7ee2a
2024-11-15 17:45:39 +00:00
Chris Lemaire
32278698e5 [gitlab] Fix NPE on exception in timeline (IJPL-171277)
#IJPL-171277 Fixed

GitOrigin-RevId: f60d2a9d5b69697944a44a39cd622f71ea1b3af0
2024-11-14 18:52:56 +00:00
Ivan Semenov
12a3862bb8 [github/gitlab] convert markdown strikethrough to <strike> instead of a span with custom style
#IJPL-166062 Fixed

GitOrigin-RevId: 3bddbdb7fac69257c60c0d27d9e420c75bfc30f6
2024-11-05 13:16:33 +00:00
Ivan Semenov
a4b6deb0d5 [collab/gitlab] fix review diff file update when only selection is changed
#IJPL-164167 Fixed

GitOrigin-RevId: 79634a7d2efe2f45408998990256d4aea10200e0
2024-11-04 19:51:17 +00:00
Chris Lemaire
ae3f487a61 [gitlab] Fix clone dialog selection resetting
GitOrigin-RevId: 95d0572f168d3582affff3c8409dd77be1da4340
2024-10-30 00:41:14 +00:00
Chris Lemaire
71d07821eb [gitlab] Add exception to detect revoked tokens to clone dialog (IJPL-163625)
#IJPL-163625 Fixed

GitOrigin-RevId: 35f64ec7bd083a3b6cd0b43f27e204974d0d4a8f
2024-10-30 00:41:14 +00:00
Chris Lemaire
475fdfcc29 [gitlab] Refactor clone dialog exceptions and handling (IJPL-163625)
Just pass around data, let's stop the secret encapsulation of VMs.
Also moves UI-data closer to UI by moving some text selection

GitOrigin-RevId: d403779fffa6365d97a2510451774b0c693622a3
2024-10-30 00:41:14 +00:00
Chris Lemaire
8bec57fa57 [gitlab] Refactor clone dialog list loading (IJPL-163625)
List loading structure is moved into GitLabCloneRepositoriesListViewModel.kt
This makes it possible to load lists in parallel and
 is generally the structure more closely representing the visual structure.

Should help with refactoring the list rendering in the future
(I believe the list should be rendered as a list of lists somehow, but currently it's flattened into one big list.
 The current implementation seems hacky if you ask me)

GitOrigin-RevId: 806c32bc5ab314ee0003eabe13036c413944387f
2024-10-30 00:41:14 +00:00
Chris Lemaire
1268f21e97 [gitlab] Minimize the data load to send for clones (IJPL-161183)
#IJPL-161183 Fixed

This should make it easier to avoid timeouts,
but we're definitely not guaranteed to prevent them at this moment.

Also splits up the queries for snippets and clone dialog.
These should require and fetch much much less data than full project data.
This is because we may have to fetch hundreds if not thousands
of projects.

GitOrigin-RevId: 06e979df8922533858c117f5cfe2362bb6cb0ab3
2024-10-30 00:41:14 +00:00
Nikita Katkov
bfd78f3c44 [yaml] IJ-CR-147338 Moved gitlab-yaml test to the corresponding module
GitOrigin-RevId: 01522449f631d7720055dfb080ed849d769559fe
2024-10-22 16:44:33 +00:00
Nikita Katkov
c34a6ed1e4 [gitlab] IJPL-64341 Add non-translatable configurable id to the plugin descriptor
With this fix, we'll be able to add the gitlab classes to the ultimate tests classpath which will help to detect bugs caused by interfering extensions from all the plugins

GitOrigin-RevId: 485f87a181d8f93dc569c443fff2e7cfd70f53a5
2024-10-21 16:18:29 +00:00
Nikita Katkov
8a29cde59f [yaml] IJPL-64341 Specify content module in plugin layout snapshot
GitOrigin-RevId: e53c4ee15a9c40a6f4a35e8a0d6f40818cfeaa7b
2024-10-21 16:18:29 +00:00