Commit Graph

6822 Commits

Author SHA1 Message Date
Mikhail Pyltsin
13774e83ac [java-highlighting] IDEA-324445 offer when after TypePattern
GitOrigin-RevId: 5ef95cd17be1a7c76e82438d84f46f96b515be2f
2023-07-06 12:58:29 +00:00
Mikhail Pyltsin
d1ee298827 [java-highlighting] Refactoring for fallthrough
GitOrigin-RevId: 88bf0c45eb23406f29f693659c8495b286512d36
2023-07-05 20:46:12 +00:00
Mikhail Pyltsin
b43535b550 [java-highlighting] IDEA-324439 Check duplication in switch with taking into account enum class
GitOrigin-RevId: 5d01e0d205c8db48f46fb6301664324f67373c65
2023-07-05 20:46:06 +00:00
Mikhail Pyltsin
f92fe33afa [java-highlighting] IDEA-324405 Not take into account guarded cases for dominating
GitOrigin-RevId: 980851746c2e1c1e0f644540867c970598224d2a
2023-07-05 20:46:01 +00:00
Tagir Valeev
1a3e995a6a [java-intentions] IDEA-324419 Suggest 'change implements to extends' fix on constructor call
GitOrigin-RevId: 56fec73701b9d77cbcb98afbf45bc751359989ec
2023-07-05 15:46:15 +00:00
Mikhail Pyltsin
0254c50753 [java-highlighting] IDEA-324327 Constant associated with switch block must be used with primitives or String
GitOrigin-RevId: 864329b3d6cbefdf9c72358064b1e14f2fc4a1e3
2023-07-05 12:09:28 +00:00
Mikhail Pyltsin
014b89199b [java-highlighting] IDEA-324307 Allow to use qualified name for enum in switch. Check duplicates
GitOrigin-RevId: 7bfce5172e1e6f398f01063449eaaeeb2d77f1c9
2023-07-05 12:09:26 +00:00
Mikhail Pyltsin
0537252af9 [java-highlighting] IDEA-324307 Allow to use qualified name for enum in switch
GitOrigin-RevId: e07468e0ce50883fadfc3d57a6666fa5a90d348d
2023-07-05 12:09:25 +00:00
Mikhail Pyltsin
cc3044554e [java-highlighting] IDEA-324313 Annotations are not allowed in deconstruction types
GitOrigin-RevId: 8541407b1bfd7d7b82d5cc9ceabb0e9ee867285a
2023-07-05 12:09:23 +00:00
Mikhail Pyltsin
4bc43b46f4 [java-highlighting] IDEA-323955 Record patterns support available only for Java 20 preview. Fix compiler errors and tests
GitOrigin-RevId: 5f856519e56e61818e95cf63766fb6a54c6283ad
2023-07-05 12:09:22 +00:00
Mikhail Pyltsin
2be6bd8458 [java-highlighting] IDEA-323767 Rename "Downcast compatible" -> "checked cast compatible"
GitOrigin-RevId: 6ac91a8fde1cae06a0892847b3ae24db1fdd9d0f
2023-07-05 12:09:16 +00:00
Mikhail Pyltsin
ac1a73d5ee [java-highlighting] IDEA-323955 Make for record patterns support available only for Java 20 preview
GitOrigin-RevId: 564b8a7ff3586a032f048bef8fce18f8da3c0fe8
2023-07-05 12:09:15 +00:00
Tagir Valeev
bf78f8d6ce [java-intentions] ExpandStaticImportAction, ConvertCompactConstructorToCanonicalAction: ModCommand (IDEA-322693)
Also: i18n

GitOrigin-RevId: e8828e96bf095b567d269cb919b0ec94ff860431
2023-07-04 13:42:53 +00:00
Tagir Valeev
cf2584bfdd [java-inspections] ReplaceWithConstantValueFix: suggest to extract side effects when applicable
Fixes IDEA-323618 Side-effect ignored by code assist

GitOrigin-RevId: 6206743a4af64948f95d722708e42caf05dda2f3
2023-07-03 21:09:36 +00:00
Andrey Cherkasov
1530062b6c Move test files
GitOrigin-RevId: 83389f43c35e596912dc08c51550df67f16d50e5
2023-07-03 14:47:39 +00:00
Tagir Valeev
5ad96f7b38 [java-intentions] More ModCommands (IDEA-322693)
GitOrigin-RevId: ac544ca3f30695ccf6f8c389444d6ab6bb182ade
2023-07-01 12:25:11 +00:00
Tagir Valeev
3df9a89271 [java-inspections] AccessStaticViaInstanceFix: mod-command
IDEA-323888 Replace 'side effect' dialog in Java quick-fixes with chooser

GitOrigin-RevId: 215c1987ee33c6fd14f6fe987bbd491fa3b78343
2023-06-30 09:01:06 +00:00
Tagir Valeev
c55dfd035c [java-inspections] RemoveUnusedVariableFix: mod-command
IDEA-323888 Replace 'side effect' dialog in Java quick-fixes with chooser

GitOrigin-RevId: c89ef0ad65e69348de86e10a20686dbf9f8e0d57
2023-06-30 09:01:03 +00:00
Tagir Valeev
640306d59f [java-inspections] RemoveAssignmentFix, JoinDeclarationAndAssignmentJavaInspection: mod-command action, with chooser
IDEA-323888 Replace 'side effect' dialog in Java quick-fixes with chooser

GitOrigin-RevId: 0ceadfeebf9bf294d5201a641922efba3b8a66be
2023-06-29 10:02:34 +00:00
Tagir Valeev
5b29f251c1 [java-inspections] RemoveInitializerFix2: mod-command action, with chooser
IDEA-323888 Replace 'side effect' dialog in Java quick-fixes with chooser

GitOrigin-RevId: 99e43ec42520ff407ad755c1b05cd5c9320bd273
2023-06-29 10:02:30 +00:00
Tagir Valeev
ad40c945e2 [java-inspections] More quickfixes to ModCommand
GitOrigin-RevId: ccc6093d680712cb81c1325d997fb2771b61a0be
2023-06-25 19:05:51 +00:00
Tagir Valeev
e58fae06c9 [mod-command] ModCreateFile; used in MoveAnnotationToPackageInfoFileFix; tests
GitOrigin-RevId: c894f03c5fdb035fda9662337563368d380cb5fe
2023-06-20 10:22:34 +00:00
Andrey Cherkasov
9ccc820db2 [java] Remove Java 17 Preview and Java 18 Preview language levels
IDEA-314047

GitOrigin-RevId: 8c24deb2dfb5361f08857d7933ab290476f4ce84
2023-06-19 17:37:05 +00:00
Fabrice Tiercelin
c2b459a91e [java-inspections] IDEA-289267 Change highlight to unused code on RedundantArrayForVarargsCall and RedundantLambdaParameterType
Also, new tests

GitOrigin-RevId: 5dbb45fc400ba8de0a360e05a4eaf0aee07e0e83
2023-06-16 20:28:52 +00:00
Tagir Valeev
feb932c66e [java-intentions] More ModCommand actions
GitOrigin-RevId: a336391bae84d99c45b3529cf404905dcf0635dd
2023-06-16 09:48:07 +00:00
Tagir Valeev
379a59d56b [java-highlighting] GenericsUtil.getLeastUpperBound: support PsiDisjunctionType
Fixes IDEA-320698 False positive error highlighting of an expression with an union type in a throw statement

GitOrigin-RevId: 7120053a75edbcb8717657b9791d1a310a581c32
2023-06-07 10:27:32 +00:00
Tagir Valeev
b47e2068ba [java-live-templates] Stabilize ThrInSwitch test
Document.stripTrailingSpaces behavior depends on whether the document is committed, which looks to be racy.

GitOrigin-RevId: bdc8b46e9a968782ac7630102b5393460d113061
2023-06-07 10:27:31 +00:00
Tagir Valeev
9a26cb1f10 [java-inspections] LambdaCanBeMethodReferenceInspection: do not suggest ::isInstance for parameterized classes
Fixes EA-429448 - AE: LambdaCanBeMethodReferenceInspection.lambda$getLambdaToMethodReferenceConversionCandidate$0

GitOrigin-RevId: 71c796f587168bff0990bcff7369f7b189d5bede
2023-06-06 09:51:28 +00:00
Fabrice Tiercelin
94c43389e6 [java-inspections] OrderedBinaryExpression; used in SizeReplaceableByIsEmptyInspection
GitOrigin-RevId: 1fedec592b56b558cd3c6e6ba4348fed7284e5ca
2023-06-05 16:00:36 +00:00
Bas Leijdekkers
1a14d80d26 Java: better quick-fix on reference qualified with primitive (IDEA-321123)
GitOrigin-RevId: e9454c241cce0e0ac5a74cc09267f5c3d695ea1a
2023-06-05 08:56:44 +00:00
Bas Leijdekkers
b2cc1fde75 Java: more clear error message on trying to reference member of primitive type (IDEA-321123)
GitOrigin-RevId: 7244dcae3a1a93396930b6a7e4b1303a8482dbf0
2023-06-05 08:56:43 +00:00
Tagir Valeev
18063dd7f0 [java-completion] Support yield in smart-enter
Fixes IDEA-321061 'Complete Current Statement' doesn't handle 'yield' in switch expressions

GitOrigin-RevId: 4fa96c88bebb66d90f2d22a6e1bf5dd36f38c5c7
2023-06-02 11:56:40 +00:00
Mikhail Pyltsin
784d237783 [Java. Error Highlighting] IDEA-320367 Generic type parameter casting to a primitive
GitOrigin-RevId: 452eb7347d85cabca2c42eaa53f4f728ac42fda0
2023-05-17 16:09:16 +00:00
Tagir Valeev
29e678487a [mod-command] 36 more quick-fixes converted to ModCommand
GitOrigin-RevId: e896b23b230cd8475035579fd9d27a719ed8c291
2023-05-17 12:33:58 +00:00
Bas Leijdekkers
873cc2268f Java: clarification of inspection message and description
GitOrigin-RevId: 82fb5a32c54291d90bd1266677c8be3ba7b334d4
2023-05-16 19:32:08 +00:00
Alexey Kudravtsev
37f4997fe2 cleanup
GitOrigin-RevId: 2f24b672d8e3a60d4a99645873fcdfc32c1d917c
2023-05-16 18:48:48 +00:00
Mikhail Pyltsin
d59e284004 IJ-CR-107413 [java-inspections] IDEA-314208 Warn when InputStream.read() implementation returns a signed byte. PR
GitOrigin-RevId: b1d54b85bb51377fab754d545e164f9550fbde5c
2023-05-15 17:20:21 +00:00
Mikhail Pyltsin
d2645f66ba IJ-CR-107309 [java-inspections] IDEA-303605 Constant expression - new option to skip reference. PR
GitOrigin-RevId: da46a96d7203ed55853eb6376d6404a69899c479
2023-05-15 14:47:25 +00:00
Mikhail Pyltsin
3ae8ed0f14 [java-inspections] IDEA-314208 Warn when InputStream.read() implementation returns a signed byte
GitOrigin-RevId: 761b1c91c48501bfeebd47bc29a338a2d4d8098d
2023-05-11 20:58:45 +00:00
Tagir Valeev
91d8908e77 [mod-command] Support fix-all option; ConvertExpressionToReturnFix: ModCommandAction
GitOrigin-RevId: 0dbcc3cfdd1d945921f21b23195b75634a3de081
2023-05-11 10:51:35 +00:00
Tagir Valeev
92839cf245 [mod-command] AddExceptionToCatchFix: ModCommandAction; injection test
GitOrigin-RevId: 9a3ab90be0420b79f913c96b0d0101e538e6fca6
2023-05-10 18:16:50 +00:00
Tagir Valeev
ff7bded456 [mod-command] EditorUpdater#select(TextRange); fix injection handling
GitOrigin-RevId: c1c412601661e7bf8231d12e024bb53109d010ba
2023-05-10 18:16:48 +00:00
Tagir Valeev
91afaf57ef [mod-command] InvertIfConditionAction: ModCommandAction
GitOrigin-RevId: 328140468ee5e5370d3c87835c72a06841dc1d22
2023-05-10 18:16:40 +00:00
Tagir Valeev
e31a010d64 [mod-command] Allow to register ModCommandAction-based intentions
Also: ModCommandAction.Presentation; MergeFilterChainAction converted to ModCommandAction; API updates; documentation

GitOrigin-RevId: fe31dc71f1f0ae3ff71ef578ad22c5dd555783de
2023-05-10 18:16:37 +00:00
Mikhail Pyltsin
913fd3db6f [java-inspections] IDEA-303605 Constant expression can be evaluated - new option to skip non-literal exception
GitOrigin-RevId: 5adb14cc5d812c28ca811095e042ec18023a92d9
2023-05-10 13:01:51 +00:00
Mikhail Pyltsin
97dffbd482 [java-code.generation] IDEA-319808 Generated hashCode method has faulty != +0.0f check
GitOrigin-RevId: 5dc591c2b342c2201cf1d5430a6e8209178eaf7f
2023-05-10 13:01:50 +00:00
Tagir Valeev
d75b5e726f [mod-command] PsiUpdateContext#moveToPrevious; AddFinallyFix -> ModCommandAction
GitOrigin-RevId: 56625a1739da460bcc71712ae4ad682f2ce200c7
2023-05-05 19:45:51 +00:00
Tagir Valeev
69e2e794f3 [java-psi] Support method references with intersection type qualifier
Fixes IDEA-319068 Good code is red: Optional.ifPresent(AbstractSet::add) complains about add method

GitOrigin-RevId: 7fe34c7041a09504536ce99cd52e7ed89997ec73
2023-05-03 13:43:47 +00:00
Mikhail Pyltsin
5032fa91dd [java-inspections] IDEA-318681, IDEA-318678, IDEA-318677, IDEA-318676 Improve previews, get rid of external annotations
GitOrigin-RevId: 57d45849299ce12c5ec19d84dcabdaaee00c3831
2023-04-25 18:46:31 +00:00
Mikhail Pyltsin
068020ddd6 [java-inspection] IDEA-311127 Not find static import. Fix one more case
GitOrigin-RevId: a45f353468b849238dab2533c87b1f18740ec395
2023-04-25 11:16:42 +00:00