Commit Graph

151 Commits

Author SHA1 Message Date
Igor Slobodskov
646c41ab62 [DS-3893] consume exceptions and log them, don't throw inside beforeDocumentChange()
GitOrigin-RevId: 2ee3191851006f1c3374e8282747527cb73d4af6
2022-09-22 14:59:53 +00:00
Andrey Vokin
a0ea176bb5 DS-3609 Make DataSpell Remote Development accessible for the general audience
Replace CellLines.Interval with IntRange where it's possible in GutterLineMarkerRenderers

GitOrigin-RevId: 56d06e83ae47bfb41273f100845606d2b775f545
2022-09-21 15:43:14 +00:00
Vladimir Lagunov
4872efea4f EA-659513 Don't obtain caret position in non-notebook editors in EditorsWithOffsetsDataRule
GitOrigin-RevId: cd78d1f8381d3fc6a14da71a4e33f5b4f8478402
2022-09-21 12:25:50 +00:00
Tagir Valeev
b1653a6dc2 Enhanced switch used
GitOrigin-RevId: 6700624264ada4144a0e6c3df89820cc1b589fdd
2022-09-18 11:09:26 +00:00
Piotr Tomiak
db8f7b08a4 Refactor castSafelyTo to asSafely
GitOrigin-RevId: 36f843369a753f158f53b36ce21ab2ecaa29fea3
2022-09-16 16:19:10 +00:00
Piotr Tomiak
7c1a967f80 Add @NoInfer to castSafelyAs result.
GitOrigin-RevId: d34d4a40c1916b4620f79844909c88364d6600e4
2022-09-16 16:19:07 +00:00
Piotr Tomiak
658547b82c Revert "remove castSafelyTo - don't repeat what language provides, no need to have extra sugar"
This reverts commit f3f806f0

GitOrigin-RevId: cf5fb413dd7f6a01deec6f1e345503dd553ba23e
2022-09-16 16:19:03 +00:00
Vladimir Krivosheev
2afb98118d remove castSafelyTo - don't repeat what language provides, no need to have extra sugar
GitOrigin-RevId: f3f806f032c267c54cfa39f5d7f32a7e0ef4cbb6
2022-09-14 18:06:07 +00:00
Andrey Vokin
3546401768 DS-3659 Context menu action "Delete cell" deletes wrong cell
GitOrigin-RevId: 0d0d87e2f583fb3f6bb73f05f2a55c658b5733a0
2022-09-14 16:42:40 +00:00
Vladimir Krivosheev
0af2e7b5c5 fix - reduce member visibility (public -> private)
GitOrigin-RevId: fe8a4740e27d192798a9fa55ff41112d1b633e49
2022-09-14 15:09:45 +00:00
Alexey Belkov
342a2bf774 Replace deprecated Kotlin sumBy function usages in whole project
GitOrigin-RevId: 77796b34c7551144566c0b079c1f2ba825aa96ec
2022-09-14 13:45:23 +00:00
Alexey Belkov
b6e312ebe3 Replace deprecated usages of kotlin.Char.toInt() in whole project
GitOrigin-RevId: b6e767c3c08811a5c22d7b80c72b3ff09d3f957b
2022-09-13 18:15:33 +00:00
Andrey Vokin
9e726628aa DS-3609 Make DataSpell Remote Development accessible for the general audience
Use right offset range when look for below-cell-inlay in cell line marker renderer

GitOrigin-RevId: 96817b5512403a055f16facba46db61e4f0a3eb8
2022-09-13 11:11:22 +00:00
Igor Slobodskov
1f2479a19e [DS-3445] don't reuse NotebookOutputInlayController if it at wrong offset
GitOrigin-RevId: 2ad66cdc69620fcb9f87ca9453ee8838689921c5
2022-09-12 13:29:52 +00:00
Igor Slobodskov
4aaad8916f [DS-3445] refactor NotebookIntervalPointerFactoryImpl and interface, add tests
Merge-request: IJ-MR-95153
Merged-by: Igor Slobodskov <Igor.Slobodskov@jetbrains.com>

GitOrigin-RevId: 278dd256b4c8cb0d205fb1527e676b0cd375df53
2022-09-09 19:56:25 +00:00
Igor Slobodskov
abcf4f7054 [DS-3445] install NotebookCellLinesProvider for Python
GitOrigin-RevId: fb7338d1c1aba0f0af737a05c4be317d48190f57
2022-09-09 12:18:10 +00:00
Andrey Vokin
2f6600e76c DS-3609: [Jupyter Notebooks] Gutter rendering via line markers
BelowCellInlayController, AboveCodeCellInlayController

DS-3609 Make DataSpell Remote Development accessible for the general audience

GitOrigin-RevId: 41e1c5a272f9c942393de2191c776f8cd2048416
2022-09-09 03:51:20 +00:00
Igor Slobodskov
65f3b864c3 [DS-3445] store NotebookCellLinesProvider as data in document
GitOrigin-RevId: 16b1d76fd600d32f4076ada6ccd6bb042cb00023
2022-09-08 13:03:31 +00:00
Andrey Vokin
f98e2f9f06 [Jupyter Notebooks] Move out cell's background rendering to separate LineMarker
GitOrigin-RevId: b98a0541e725b77c80352735026fa33f3f584e51
2022-09-06 15:43:26 +00:00
Andrey Vokin
1c7edfd7fa [Jupyter Notebooks] Move out line numbers rendering to separate LineMarker
GitOrigin-RevId: 65cd51230b9ab112f0f99c8c6cb765647b5990d5
2022-09-06 15:43:23 +00:00
Andrey Vokin
6c92161502 [Jupyter Notebooks] Avoid usage of ListIterator<Interval> in favor of Interval
GitOrigin-RevId: 62e7a48073a11763ec1c87c1e827f9fe5ad6cb09
2022-09-06 15:43:20 +00:00
Andrey Vokin
1dce6be8f6 [Jupyter Notebooks] Render In/Out directly via LineMarker
GitOrigin-RevId: b9ba3efad611320d93393a0aeb9ee692d9f4676b
2022-09-06 15:43:13 +00:00
Andrey Vokin
a77e252ded [Jupyter Notebooks] Better names
GitOrigin-RevId: 8841a94ec74214a58087b82be8a14828d20ef556
2022-09-06 15:43:10 +00:00
Andrey Vokin
90319acec6 [Jupyter Notebooks] Add highlighter for each cell
GitOrigin-RevId: f0be30df580f59be215ab3e7adcf6c090d4b8cf4
2022-09-06 15:43:07 +00:00
Andrey Vokin
b9fe980861 [Jupyter Notebooks] Simplify NotebookGutterRenderer
GitOrigin-RevId: 40a72b1c87b5060bf7ba89014d456813f1f204c0
2022-09-06 15:43:04 +00:00
Andrey Vokin
93c0b867f4 [Jupyter Notebooks] get rid of NotebookCellGutterController
GitOrigin-RevId: 3bff5824aab60a7570ba7901b81de138e29a68b7
2022-09-06 15:43:00 +00:00
Nikolay Chashnikov
a0de92e1f3 cleanup: remove unused deprecated API (IDEA-295370)
GitOrigin-RevId: 439b59d8cf266e48f703345e656e4f29e617d00d
2022-09-06 12:45:06 +00:00
Vladimir Lagunov
37dc88e90e Add getActionUpdateThread to some actions
GitOrigin-RevId: 5ebd9f2d7c8bd4632fd46c24c1858cce7f47a2d6
2022-09-02 17:39:14 +00:00
Igor Slobodskov
c7eb8b283c [DS-3445] explicitly pass mySavedChanges as parameter
GitOrigin-RevId: 1792e16fd21dc0a82163a8aa200604bf51c4195e
2022-08-30 11:50:41 +00:00
Igor Slobodskov
2369c42b4e [DS-3445] move code to another function
GitOrigin-RevId: 1c6af6e4b23c455d793a7fbcd27caa300b3bef9a
2022-08-30 11:50:38 +00:00
Igor Slobodskov
305ebe4b43 [DS-3445] compare ordinals instead of pointers
GitOrigin-RevId: a97ba3557473d5e78d7371d02e56639fa3d81b62
2022-08-29 18:06:38 +00:00
Igor Slobodskov
eb75399978 [DS-3445] Merge NotebookIntervalPointerFactory.ChangeListener calls into one.
Intervals often inserted or removed in some sequential range. Listener will get info about all range of removed or inserted intervals. This allows to process modification in more effective way.

GitOrigin-RevId: e220f0a04344fab918368a941dc140e4a1e3a2a1
2022-08-29 17:30:25 +00:00
Igor Slobodskov
7c8dd61a72 [DS-3445] add NotebookIntervalPointersEvent
GitOrigin-RevId: 69f66b9f22bcbcf7534214c78e96bb3075f4ebbb
2022-08-29 17:30:22 +00:00
Igor Slobodskov
f5b14704c9 [DS-3445] swap NotebookIntervalPointers instead of moving them
GitOrigin-RevId: fad9830a5a79bec9ec9f0b8f2197429851079ac0
2022-08-29 17:30:19 +00:00
Igor Slobodskov
528ff8a114 [DS-3445] format code
GitOrigin-RevId: 5c0c450fd6f9e9c02bba1d78b75f50031ecefd15
2022-08-25 11:19:55 +00:00
Igor Slobodskov
24c0477d33 [DS-3445] postpone listener calls
GitOrigin-RevId: 213ca49e242c5807b1fa57ed0b887b1f107d3c72
2022-08-24 19:30:31 +00:00
Igor Slobodskov
90c442cdca [DS-3445] simplify code
GitOrigin-RevId: c21d98ddabe77a9b2781eb8ec2196a3264ce5a43
2022-08-24 19:30:29 +00:00
Igor Slobodskov
0b7bb90f4e [DS-3445] refactor code, split method
GitOrigin-RevId: 22eaecd6e2185ea7775683cd5eb338d69c00a5e6
2022-08-24 19:30:28 +00:00
Andrey Lisin
32f1675e7a EA-542148 - NPE: NotebookOutputNonStickyScrollPane$MyMouseHandler.contentFitsViewport
GitOrigin-RevId: c6201200a0eac5c1504034ec521fd4330736a278
2022-08-24 13:02:49 +00:00
Igor Slobodskov
2d16a60df1 [DS-3445] improve comments, change method name to more obvious
GitOrigin-RevId: 7196a69a531a239e64772d3bc61e67eb9f0a5ace
2022-08-22 12:21:42 +00:00
Igor Slobodskov
4fb3a11752 [DS-3445] add DocumentEvent and timestamp as fields to NotebookCellLinesEvent
GitOrigin-RevId: 7ce7cf85e4d64ef20f5495703e53d8fb9ff261e9
2022-08-19 21:41:30 +00:00
Igor Slobodskov
d93e53412b [DS-3445] add NotebookCellLinesEvent
GitOrigin-RevId: e4e678835b608c1912e4de31a0ecfb990428f9fa
2022-08-19 21:41:27 +00:00
Tagir Valeev
9038e3f77b Remove empty and irrelevant javadoc tags
GitOrigin-RevId: dcbbb8cff7ef267525129c464769f761d92c2120
2022-08-09 09:41:49 +00:00
Vladimir Lagunov
57900b836b DS-3706 Fix freeze in NotebookCellLinesIntervalDataRule by making it a slow rule
Even though the rule is used in some UI things like cell collapsing, it is not easy to untie it from PSI due to different token providers for different PSI languages.

In case someone has to revert this commit, they'll have to find a way to juxtapose `NotebookCellLinesProvider` implementations for editors without `LanguageExtension`.

GitOrigin-RevId: 2e8133ee83cec46428f83577fe5a914585c58485
2022-07-25 13:50:34 +00:00
Vladimir Lagunov
9b3e778922 DS-3583 Jupyter: inline getNotebookCellLinesInterval()
GitOrigin-RevId: 1782fbc5eddfb32cf1e109895a95d91a065531e1
2022-07-03 12:00:17 +00:00
Vladimir Lagunov
79ab7f094b DS-3583 Jupyter: set ActionUpdateThread=BGT, relying on PreCachedDataContext
GitOrigin-RevId: e0b2ff9094c440f16363c93a70319daedfdf7c2c
2022-07-03 12:00:15 +00:00
Vladimir Lagunov
7d175f330c DS-3583 Reorganize NotebookCellLinesContext.kt to get list of all matching editors, which can be cached later
GitOrigin-RevId: a5a2c419a085c0e66e34d7cf6a00f7b5c984d3b9
2022-07-03 12:00:09 +00:00
Vladimir Lagunov
fd2e274449 DS-3554 Jupyter: Get rid of a frequent warning: Overwriting an existing CLIENT_PROPERTY_DATA_PROVIDER
GitOrigin-RevId: f1cba2233503e335261c527175451010f5c2841d
2022-07-03 12:00:08 +00:00
Vladimir Lagunov
9eeb969724 DS-3583 Jupyter: convert DataContext extension properties to functions
According to Kotlin Coding Conveniences, they should be functions, because they are not trivial and can throw errors.

GitOrigin-RevId: 7c1e927c7384f9eb085ff19b19239554f962addb
2022-06-29 07:47:12 +00:00
Vladimir Lagunov
ef013f3435 DS-3580 Jupyter: Fix resizing outputs with initially limited height
GitOrigin-RevId: 9395479d6585a50de6cf1bbebcc695ae5f359489
2022-06-29 07:47:06 +00:00