Commit Graph

146 Commits

Author SHA1 Message Date
Tagir Valeev
cf2584bfdd [java-inspections] ReplaceWithConstantValueFix: suggest to extract side effects when applicable
Fixes IDEA-323618 Side-effect ignored by code assist

GitOrigin-RevId: 6206743a4af64948f95d722708e42caf05dda2f3
2023-07-03 21:09:36 +00:00
Tagir Valeev
2f1be4183d [java-inspections] More ModCommand fixes
GitOrigin-RevId: 0c09d9d462156b87b8cd8ef33d203d959a579baf
2023-06-27 11:08:29 +00:00
Tagir Valeev
ad40c945e2 [java-inspections] More quickfixes to ModCommand
GitOrigin-RevId: ccc6093d680712cb81c1325d997fb2771b61a0be
2023-06-25 19:05:51 +00:00
Bas Leijdekkers
01d55eeb9c Java: add parentheses to inspection warning
GitOrigin-RevId: c85afe8b4c44d05f30e3b1361286c22de7d84e2c
2023-06-22 14:48:20 +00:00
Tagir Valeev
9a63850218 [java-inspections] OptionalOfNullableMisuse: change message
GitOrigin-RevId: 168f791e21376d5a134683b7f3fc0661fdcaf091
2023-05-17 12:34:05 +00:00
Tagir Valeev
5906493339 [java-inspections] Less confusing warning & fix on misplaced annotation when fqn+array is used
GitOrigin-RevId: d490d2696d070827fbe6a3b958a05acd31afcdc7
2023-04-27 09:56:48 +00:00
Tagir Valeev
eac9020d84 [java-inspections] ExtractMethodRecommender: alternative highlighting experiment
GitOrigin-RevId: c630a700ff2b3ee4f76e23984172f9aeb31a6c15
2023-03-29 15:06:02 +00:00
Tagir Valeev
4b25e11528 [java-inspections] Extract method recommender: proofreading
GitOrigin-RevId: 747d75760e6a61c34c16b960cc60f2b59f1a59ff
2023-03-13 14:37:48 +00:00
Tagir Valeev
f5effaaeb3 [java] IDEA-210466 Suggest to move Java file to the source root
GitOrigin-RevId: f225ebbb2bcb6084b36ca504aae4e5463c074fc5
2023-03-06 15:05:37 +00:00
Tagir Valeev
2c0d7c5469 [java-dfa] Better tracking of class instantiability
Fixes IDEA-310238 Warn if an interface class is used for == comparison with value returned from smth.getClass()

GitOrigin-RevId: 03e2943f3df69c3021b387be0aa32fef42123321
2023-03-02 14:22:29 +00:00
Tagir Valeev
f4a568e5d6 [java-inspections] ExtractMethodRecommender: proof-reading
GitOrigin-RevId: c737ea5a56fbd23097aab81234692d93ff551b39
2023-02-24 11:31:53 +00:00
Tagir Valeev
5f02a4d3ba [java-inspections] ExtractMethodRecommender: proofreading
GitOrigin-RevId: 4dded16ebf9f26f53cdca089f2c5d51ae7fcb98c
2023-02-23 14:40:36 +00:00
Tagir Valeev
5612d67279 [code-inspections] SetInspectionOptionFix: support numerical value; used in ExtractMethodRecommenderInspection
GitOrigin-RevId: d4f587f5f1e280eca12f5b0e0ab48e232ba187f3
2023-02-23 13:14:33 +00:00
Tagir Valeev
7218710d59 [java-inspections] IDEA-313710 Suggest extract method refactoring on code snippets inside long methods
Draft implementation; currently isInternal and turned off by default

GitOrigin-RevId: 9f2d72de70112062929edd33a4bc9f8693f923fb
2023-02-20 15:23:36 +00:00
Tagir Valeev
e9cd48e8b7 [java-inspections] Proof-reading
GitOrigin-RevId: 90920eb2a514ccbbb8d51f9a2343ba4b32c0ecce
2023-02-14 14:00:37 +00:00
Anna Kozlova
6aa468aabd [kotlin] move to more appropriate bundle
GitOrigin-RevId: 95ad0451aaf13935d1296f4039ccdecb8ab9126e
2023-01-24 17:13:55 +00:00
Anna Kozlova
6bdb09bae5 [kotlin] explicitly execute potentially slow override/implement search under progress (KTIJ-24371)
GitOrigin-RevId: 9a47fa8a9a622353e34cfd0e9ca0d04bb07429a0
2023-01-23 18:12:26 +00:00
Andrey Cherkasov
8b5180c01f [java-inspection] LocalCanBeFinal: pattern variable support
IDEA-309250

GitOrigin-RevId: 649fa4e75d40c911fb24002396ba65542d1fc09d
2022-12-26 13:39:27 +00:00
Andrey Cherkasov
608c99ed4d [java-highlighting] Display error if record patterns in for-each loops aren't available (IDEA-309351)
GitOrigin-RevId: 0919de47769682aff2c016920175a74d89c9f7b6
2022-12-26 13:39:22 +00:00
Bas Leijdekkers
86f0b63857 Java: better quick fix texts for "Loop can be collapsed with Stream API" and "Simplifiable forEach() call" inspections
GitOrigin-RevId: c4db6507c258e5611f6d47b9373a0c2531802345
2022-12-23 13:26:29 +00:00
Andrey Cherkasov
7bf9474dac [java-highlighting] Provide quick-fix for the "Package annotations should be in file package-info.java" error
IDEA-216254

GitOrigin-RevId: 9d8c4074babff861b5702caa09dd320de5d63d72
2022-12-22 15:59:18 +00:00
Tagir Valeev
1f14021ad5 [java-inspections] VisibilityInspection: OptPane
GitOrigin-RevId: 881f40c6f944eed3d80df25d95e99c7cf9d0ec35
2022-12-19 20:05:53 +00:00
Tagir Valeev
3fc334a23a [inspections] Improve OptDropdown; use in ConstantOnWrongSideOfComparisonInspection, ParametersPerConstructorInspection
GitOrigin-RevId: a89fe782d0c462e7dacf65c6f6eddde9ce332d1f
2022-12-14 18:37:50 +00:00
Konstantin Aleev
3f2c382262 IDEA-217927 [uast] set language display name
GitOrigin-RevId: 38e144d9593f1889afa2e3a69e524c4c7fbdc671
2022-10-18 00:06:14 +00:00
pyltsin
561e2d81d0 [java-dfa] IDEA-300181 Report when the same stream is consumed more than once.
Co-authored-by: Tagir Valeev <tagir.valeev@jetbrains.com>

GitOrigin-RevId: 929f69d8e22285cae8906761df6b39ec46ce985c
2022-09-30 12:10:32 +00:00
Bas Leijdekkers
50dda1fccf quick fix name tweak
GitOrigin-RevId: 40f0291b698a357f4cfb2dea429f6b516e105550
2022-09-12 20:49:43 +00:00
Tagir Valeev
24511394c3 [java-intentions] IDEA-301288 Suggest to make variable effectively final moving assignment to the branch without assignment
GitOrigin-RevId: c9953f2df87f2fa35ed97be97e48cd6240ee8fae
2022-09-09 15:06:38 +00:00
Tagir Valeev
430cdc18db [java-analysis] JavacQuirksInspectionVisitor: cosmetic
GitOrigin-RevId: c1ea48d2f4c185b8b24736b322b78ed034ba38bb
2022-08-17 18:22:16 +00:00
Bart van Helvert
2a86552363 [java-inspections] Add quotes to annotations in inspection messages
GitOrigin-RevId: a2d102bb75c6f0f213cfe79928909f8501be6ca7
2022-08-04 13:39:06 +00:00
Tagir Valeev
8a9959167b [java-intentions] IDEA-299075 Better quick-fixes when generic method call has mismatched type
GitOrigin-RevId: 6fa73efcfb43cd7da05f95ef66c2cd40a3dc1a14
2022-08-01 18:23:39 +00:00
Bart van Helvert
342c8033b4 [java-inspections] Improve ChangeNullableDefaultsFix warning message
GitOrigin-RevId: c1a55bc8cd7249425fac57493487413b044a4cb0
2022-07-29 14:24:29 +00:00
Bart van Helvert
780a373547 [java-inspections] IDEA-298846 Add preview to ChangeNullableDefaultsFix
GitOrigin-RevId: 785aaba03830dc91498d384f03800d191c089bcb
2022-07-29 14:24:26 +00:00
Bas Leijdekkers
50350c4170 Java: improve inspection messages
for "Duplicated delimiters in 'StringTokenizer'" inspection

GitOrigin-RevId: 1c6b058704b9d612b058f774d779dc9eca6f48ac
2022-07-25 12:19:28 +00:00
Dmitry Gridin
5e1fade9d2 [java] MarkerType: fix i18n capitalization
GitOrigin-RevId: e0284bbf8928ed1ead4419915180fcac7309f133
2022-07-21 12:10:28 +00:00
Bas Leijdekkers
f0f3f4098c Simplify unsupported features warning
GitOrigin-RevId: 5295c833018bbbc23f8087ae52edcb7702aa8e0b
2022-07-18 23:37:50 +00:00
Tagir Valeev
2ceda3f922 Unused properties removed
GitOrigin-RevId: 5aefe1253c623a4d9029d6454a0f1d6ae46ad3fe
2022-07-07 15:47:41 +00:00
Roman Ivanov
4c02fc85a9 [java] check pattern guards and record patterns feature in HighlightVisitorImpl
GitOrigin-RevId: 691663582652efe8e54bcc50a5f99ae51da81a72
2022-06-28 15:41:21 +00:00
Bart van Helvert
13b35e5ecf [java] Remove unused imports
GitOrigin-RevId: 2bed87a0ce45a60dca6b652a5b3bf15401647ca5
2022-06-09 11:07:56 +00:00
Tagir Valeev
8fd79a665c [java-inspections] IDEA-294900 Remove repeating call fix on unresolved call error
GitOrigin-RevId: 220979068250f873c725310dc8cf38a36d1e7fdf
2022-05-27 13:26:35 +00:00
Anna Kozlova
db129f1e02 cleanup unused property
GitOrigin-RevId: aecfd310ea04ff1e468db1b0904d7d00adb44cce
2022-05-02 09:04:50 +00:00
Anna Kozlova
fb407c9394 [java] reassign variable as inspection (IDEA-207835)
GitOrigin-RevId: 99f09be79c515a15770cf38062eeca0776aa4a26
2022-04-22 18:58:37 +00:00
Bas Leijdekkers
a9981ea940 Quote modifier in inspection message
GitOrigin-RevId: b571162953afbd9afd01c65d62721dfc369730b5
2022-04-13 23:50:32 +00:00
Bas Leijdekkers
e72529cff2 capitalize "Java" (IJPF-CR-5078)
GitOrigin-RevId: 124bec7c8071720cc53d7279bfe27f00324f066d
2022-03-31 12:25:27 +00:00
Anna Kozlova
c7407e3248 [java] [jigsaw] better warning descriptions (IDEA-256236)
GitOrigin-RevId: 4fd2a2ede29c261b137cb13aa2ab6ae4a4bd556c
2022-03-30 19:31:12 +00:00
Bas Leijdekkers
601902f5eb fix inspection message strangeness
GitOrigin-RevId: 12db0098047932e92ac468072095492cb558adea
2022-03-20 19:35:18 +00:00
Bas Leijdekkers
1eeef6da62 improve "Method always returns the same value" inspection messages
GitOrigin-RevId: 20ef273a00b17991f4ff94bbbbf94be334af4e60
2022-03-20 19:35:15 +00:00
Bas Leijdekkers
91437afcba fix typo in inspection problem descriptor
GitOrigin-RevId: e384ea2dca273f83f6c533c9cab2e3a6f0834a10
2022-03-20 19:35:13 +00:00
Bas Leijdekkers
d7b5dc3dd6 fix "Redundant 'throws' clause" inspection message strangeness
GitOrigin-RevId: cfadac43b09231acf94393bf436bd0785f3d0c59
2022-03-20 19:35:10 +00:00
Bas Leijdekkers
9e836fbc0f improve "Redundant 'throws' clause" inspection messages
GitOrigin-RevId: b6f78d834640381aba871356f47fcc78041db86b
2022-03-13 12:09:43 +00:00
Nikolay Chashnikov
21f928cac9 [java] fix wording for "Redundant @ScheduledForRemoval annotation" inspection (IJPF-CR-4616)
GitOrigin-RevId: cbe78de4e53a4535f7cbd513e5b0700921b9be18
2022-02-21 15:26:06 +00:00