Commit Graph

2187 Commits

Author SHA1 Message Date
Dmitry Avdeev
d619e852b0 dedicated coroutineScope for RunManager
GitOrigin-RevId: 0d849e60590df190259f78f73bf282ea9f3b4845
2024-07-23 18:16:13 +00:00
Dmitry Avdeev
1357bffe12 IDEA-354900 Flaky test com.intellij.tests.BootstrapTests: com.intellij.jsp.refactoring.JspExtractTagFileTest.testExtractNextJspxTag
proper cancellation of RunConfigurationInArbitraryFileScanner

GitOrigin-RevId: a8a0198dbab2925d89df6ca5a88163c2eeabc767
2024-07-18 21:36:58 +00:00
Alexander Doroshko
a5a139dd05 [Run configurations] IJPL-11679 Run widget doesn't use last run config if its stored externally in .run folder
this fixes tests
in RunConfigurationSchemeManagerTest: `project loading - initially selected run config stored in run_xml file` and `set any run config as selected if no info`

GitOrigin-RevId: 7d4225a9ac127955e6b370b042ecbd936c06b0d4
2024-07-16 21:11:42 +00:00
Vladimir Krivosheev
af6959e243 IJPL-158410 make sure that we disable ugly ancient outdated swing implementation of tooltip
GitOrigin-RevId: ec8be5047832dbafa16dde8d8908d1656a5cce15
2024-07-16 16:57:35 +00:00
Alexander Doroshko
1faf63f920 [Run configurations] don't catch ControlFlowException in RCInArbitraryFileManager.loadChangedRunConfigsFromFile
GitOrigin-RevId: 2405d41d2ecedf916b5be01d86bdb8010fdc0596
2024-07-15 20:18:02 +00:00
Vyacheslav Moklev
369083ce27 [RDCT] Fix the run configuration popup not updating on start/stop of run configurations
GitOrigin-RevId: 50dd0e9e630e8fca342ebd8f7641a60a748a9be1
2024-07-15 12:13:58 +00:00
Vladimir Krivosheev
61cc661834 IJPL-158075 mark unsafe SingleAlarm constructor as Deprecated
GitOrigin-RevId: dd7d7398fecd6241db6c93183df421466ff97f91
2024-07-13 08:45:37 +00:00
Gregory.Shrago
87269ea1c1 introduce PresentationFactory.postProcessPresentation
To avoid changing action items back and forth.

GitOrigin-RevId: 498189a817a030e2b69906ffdb38d360276d0c4b
2024-07-12 17:26:54 +00:00
Vladimir Krivosheev
cfccc94883 IJPL-158097 refactor RegistryValue
GitOrigin-RevId: a04dfa7e85c1d3fe24fe455d56ac32d3d53861c4
2024-07-11 14:41:36 +00:00
Gregory.Shrago
9f0921bf51 migrate getData to uiDataSnapshot: platform 2
GitOrigin-RevId: 57c37e4e2861d04cd2350b8fdd210748215ed8a3
2024-07-11 12:06:59 +00:00
Vladimir Krivosheev
dc67a752c3 IJPL-11682 cleanup
GitOrigin-RevId: 5d89f0e705cc8ec26524420734a34f2387ea55e1
2024-07-11 09:50:39 +00:00
Vladimir Krivosheev
3ce41c5cdb IJPL-158075 ability to pass the correct scope to alarm (we cannot rewrite all usages, but at least we can use the correct scope)
GitOrigin-RevId: 7cb9fbf325ca2249a689cffff388a5275d8c2005
2024-07-11 09:50:38 +00:00
vladimir.petrenko
3b77fee326 IJPL-157490 Telepresence: update API-dump file
yes, it is intended


(cherry picked from commit 0b4c9a2197c343382142ed88aec54eb87192d0ad)

IJ-CR-138667

GitOrigin-RevId: 4768bcef63b12840736c483b58b728db12b543d9
2024-07-10 19:24:02 +00:00
vladimir.petrenko
73308a8ea2 IJPL-157490 Telepresence: revert final modificator to EditRunConfigurationsAction (IJ-CR-138667)
not necessary anymore (see the commit, when it was removed)

this should fix the failed test `FileComparisonFailedError: 'intellij.platform.execution.impl' API dump does not match the actual API`


(cherry picked from commit 1e38ad80468fcab9541c5989f83f7e2e4c4b0c72)

IJ-CR-138667

GitOrigin-RevId: 7978505a09d1af492360dc92f8b8a1d23f255a37
2024-07-10 19:24:02 +00:00
vladimir.petrenko
6dd2a59984 IJPL-157490 Telepresence: rename actions (IJ-CR-138667)
(cherry picked from commit 95c7754c302d57f322476600527df766ab9d1ceb)

IJ-CR-138667

GitOrigin-RevId: d67dc7ee643bcaa8bf0bb7f8337709654c1b1702
2024-07-10 19:24:02 +00:00
vladimir.petrenko
3b5f8fa5b1 IJPL-157490 Telepresence: rename actions group to RunConfiguration.Group (IJ-CR-138667)
(cherry picked from commit 55d834ee0b9b9bbafcbe79b47b6cc6865d6b2fe5)

IJ-CR-138667

GitOrigin-RevId: 009298bc4107bab82e698110b5c59db1f1e6f71d
2024-07-10 19:24:02 +00:00
vladimir.petrenko
d2af4e1898 IJPL-157490 Telepresence: maintain the reorganized actions in Old UI (IJ-CR-138667)
2 problems are fixed by this commit:
1) bad naming of `EditRunConfigurationsInNewUiAction` and its needlessness (IJ-CR-138667)
2) missing of actions in OldUi, which were reorganized by previous commits

To avoid duplication of "Edit..." items in Old UI that was solved before this commit by `EditRunConfigurationsInNewUiAction` implementation, the action with id `IdeActions.ACTION_EDIT_RUN_CONFIGURATIONS` is added under the corresponding condition in code after the commit. (After the completely removing of Old UI this part of changes can be reverted)

About the missing actions in Old UI:
They were missed because the DataContext did not contain a value for `RUN_CONFIGURATION_KEY` during actions updates. This is fixed by the introduced overridden `createActionPopup` method.


(cherry picked from commit 867e94bdedfdd753e783812d1939e22a3e37baa4)

IJ-CR-138667

GitOrigin-RevId: 86da724a6dac4218f392e91f4577e1458827635b
2024-07-10 19:24:02 +00:00
vladimir.petrenko
082acd4d50 IJPL-157490 Telepresence: move actions texts and descriptions to bundles so that they could be associated automatically
the new key-values in `ActionsBundle.properties` file are the copies of the corresponding `choose.run.popup.*` keys from `ExecutionBundle.properties`. The keys are renamed to the "action.[action_id].text/description" and moved to `ActionsBundle.properties` file so that they were automatically assigned to the corresponding actions declared in `LangActions.xml` file without writing any special code for doing this. The corresponding key-values were not removed from `ExecutionBundle.properties` because they have other usages. These usages were not rewritten so that they use the new key-values from `ActionsBundle.properties` because it can lead to changes in 100500 files, that can complicate possible backporting.


(cherry picked from commit 7ea94ef5f48a4dd323eb4cb33e149f772c0377f6)

IJ-CR-138667

GitOrigin-RevId: b9f345d1c3045151f5dcc335b0a0f654da408c42
2024-07-10 19:24:02 +00:00
vladimir.petrenko
a8e8d03450 IJPL-157490 Telepresence: refactor: extract actions to separate files + rename
(cherry picked from commit 20229422a8554eadf52b007c8632ec733474cab4)

IJ-CR-138667

GitOrigin-RevId: 644a8fcfe095df48782fdbbff0e68a9e442ca365
2024-07-10 19:24:02 +00:00
vladimir.petrenko
45fbfa1720 IJPL-157490 Telepresence: use "actions-extension mechanism" instead of new extension point that provides actions
(cherry picked from commit 5a0035880a08c5327379c86542fcd6ec8e6063de)

IJ-CR-138667

GitOrigin-RevId: 54db2c78cec8664359f9a18c7c6abe4b94780f1c
2024-07-10 19:24:02 +00:00
vladimir.petrenko
9b555ecf0d IJPL-157490 Telepresence: move "Add Kubernetes Tunnel" button into "Configuration" section ...
... in Run Configiration executors menu and convert it into AnAction


(cherry picked from commit 608be4e8de2e2efe0490553dc3ead5987dc74060)

IJ-CR-138667

GitOrigin-RevId: 7f100be25f9970485a2dff9e81514bfa79043d02
2024-07-10 19:24:02 +00:00
Wojciech Gąsiorek
4bb94dc0a5 IJPL-12596 Preserve custom order of folders in the
Run/Debug Configurations

Closes https://github.com/JetBrains/intellij-community/pull/2788

GitOrigin-RevId: 00ab3bfa40c367619573b1b48e66043b97cfd39e
2024-07-10 09:55:50 +00:00
Gregory.Shrago
30fe2c837e drop RunnerContentUi.ToggleSeparateWatches
Besides cleanup, fixes
IJPL-158013 `BackendToggleAction.isSelected` must not be called

GitOrigin-RevId: 012be42757842f7589e7cc5ac1f9c67ef99ad0db
2024-07-10 00:56:17 +00:00
Gregory.Shrago
0576008153 hide "Run" action when "Resume" is present in RemDev
GitOrigin-RevId: 42584cb6f820fd3f06dac9b40a8e531065829988
2024-07-09 21:36:33 +00:00
Tagir Valeev
d263e30396 Remove raw types in PopupStep#onChosen inheritors
GitOrigin-RevId: df36f1a249ab4d87c2d10e3d39c27f0351298921
2024-07-08 16:18:24 +00:00
Gregory.Shrago
fe17fc9341 deprecate AlwaysVisibleActionGroup
Replace with `ActionUtil.ALWAYS_VISIBLE_GROUP`.

Marker interfaces do not work in RemDev.

GitOrigin-RevId: bb443607926c84a7a519213bdd75fa3c337fd702
2024-07-05 22:40:35 +00:00
Gregory.Shrago
7390cbfb02 add option to always show inline actions for active configurations
GitOrigin-RevId: 9e2234ec0d3cd857c1dc933998e142a8ebe0e10a
2024-07-05 22:40:35 +00:00
Gregory.Shrago
d587049edb IJPL-157834 No way to start two run configurations at once
GitOrigin-RevId: 93a70bd8fc53164a9e4863559d5f901c50f0085b
2024-07-05 22:40:35 +00:00
Gregory.Shrago
34666bb5a2 IJPL-61164 Ability to launch multiple configurations at once
GitOrigin-RevId: c87c0267557dce91dcde8867e5f4a0c0c825f651
2024-07-05 22:40:35 +00:00
Gregory.Shrago
63d8e8c85f do not hide an inline run action when it is starting
Prepare for
IJPL-61164 Ability to launch multiple configurations at once

GitOrigin-RevId: 30d90c6c48eccf6df36f717520d0c1184385c3d3
2024-07-05 22:40:35 +00:00
Gregory.Shrago
6ec6180097 simplify RunToolbarPopup code
1. inline outdated experimental registry options
2. use postprocessing to filter out unneeded actions
3. add all inline actions and let visibility logic do its job
4. extract `PinConfigurationAction` and make it work as a toggle

Prepare for
IJPL-61164 Ability to launch multiple configurations at once

GitOrigin-RevId: 99d018f3d0d6752933aef036a27a228a9b4bd5b7
2024-07-05 22:40:35 +00:00
Gregory.Shrago
76ef82f2d4 introduce ActionUtil.ALWAYS_VISIBLE_INLINE_ACTION
A dedicated constant. `ALWAYS_VISIBLE_GROUP` must not be reused.

GitOrigin-RevId: 7db5c4d94d65a1e938272e8e6191376fabd3d294
2024-07-05 22:40:35 +00:00
Konstantin Hudyakov
338768cdf5 [terminal] IJPL-156352 Report non default Terminal settings to FUS
GitOrigin-RevId: 4da6d86b58a949ca0b045f1a260dfe20186089c3
2024-07-04 17:51:50 +00:00
Gregory.Shrago
ed642c4863 drop unneeded ExecutorAction.hideDisabledExecutorButtons
GitOrigin-RevId: 06e7009348441d70c16cbddc4eca3beb16aab655
2024-07-04 15:21:37 +00:00
Gregory.Shrago
98e7545cb8 introduce KeepPopupOnPerform to replace Presentation.isMultiChoice
A 4-value enum now includes previous "hard" and "soft" semantics without special treatment for `ToggleAction`.

See
IJPL-157628 Introduce Keep popups open for toggle items setting

GitOrigin-RevId: 123935b9367dd624b4c810b0dfa066fba23e1672
2024-07-03 04:11:57 +00:00
Pavel Porvatov
f30ff5eb55 [Kotlin UI DSL] Hidden/removed deprecated API
GitOrigin-RevId: b1fb3ab275ce643ad88926420f05f0065e9bb3d6
2024-07-02 07:29:39 +00:00
Pavel Porvatov
74be212997 [Kotlin UI DSL] Hidden/removed deprecated API
GitOrigin-RevId: b736860d6c544f4b0ecde6ea0642fe8d97726357
2024-07-02 07:29:39 +00:00
Tagir Valeev
229eff0461 Raw type and other warnings fixed
GitOrigin-RevId: cde52de8987d2a995c4d2861f3b77356d79f3dd4
2024-06-28 16:52:24 +00:00
Gregory.Shrago
87e4cedb39 migrate getData to uiDataSnapshot: database
GitOrigin-RevId: bfe13d0d4ba75e7d4b115dd7688fde629bb14bf4
2024-06-26 02:39:39 +00:00
Gregory.Shrago
72395b96fa migrate getData to uiDataSnapshot: platform
GitOrigin-RevId: f1de4233f6b054c18a572e58bdb5a8bf2a0acabe
2024-06-26 02:39:38 +00:00
Vladimir Krivosheev
9b7e40abe0 IJPL-156708 refactor JBTabsPresentation
GitOrigin-RevId: c1c605d90a332247c0133267369766ad1debaab3
2024-06-21 06:27:32 +00:00
Konstantin Aleev
56ec8d916a [fus] IJPL-156718 fix Run Configuration was started event field name
GitOrigin-RevId: bb29882b62d4343c89ea9bf660034b0cc7ea75c1
2024-06-20 13:37:44 +00:00
Konstantin Aleev
6ae5a06f0a [fus] IJPL-156718 Run Configuration was started event: use Service View instead of Services
GitOrigin-RevId: 551ba0ab0207803a80025a044e4715521003c180
2024-06-20 09:50:45 +00:00
Gregory.Shrago
646623bc62 introduce ActionWrapperUtil
Add the ability to customize data contexts for delegates.

Session API is not used in case of customization. For now, session always uses the original data context.

GitOrigin-RevId: 4c4b7dcfe55d41ab708cba6a415272cecd8b8eb6
2024-06-19 14:22:23 +00:00
Konstantin Aleev
11e07e0a4f [fus] IJPL-156718 add 'is in Services' flag to Run Configuration was started event
GitOrigin-RevId: eca38082810a3a04504da25a89056673d5188c44
2024-06-19 02:48:33 +00:00
Tagir Valeev
3fd0f4975d Pattern variable can be used fixes; other warning fixes
GitOrigin-RevId: 4965216d1872b439970db33dbe2864d5aab9606e
2024-06-18 19:55:23 +00:00
Vladimir Krivosheev
62e10d884d IJPL-156697 mark JBTabsImpl as internal
GitOrigin-RevId: 6f0d7543256e7bd3e39954cc1cc81f295c4fe65b
2024-06-18 08:23:56 +00:00
Konstantin Hudyakov
ab3d548417 [terminal] IJPL-155972 Do not make typed request text grey when command is generating
There will be another solution with showing the spinner.

GitOrigin-RevId: c0f1738fa1196b1476227560148013967b1e17b7
2024-06-17 16:17:31 +00:00
Dmitry Avdeev
1cc78a8d57 IJPL-156448 Run Configuration is produced in EDT
tuning ActionGroupWrapper

GitOrigin-RevId: 2c77669f4a0976ac083312a16192e253e5c2f522
2024-06-17 09:52:44 +00:00
Dmitry Avdeev
9e0d76f66d IJPL-156448 Run Configuration is produced in EDT
wrapping CreateRunConfiguration action spoils ConfigurationContext cache, so it's removed
hopefully this won't break scenarios described in IDEA-144385 (When JUnit run configuration exists it's hard to run main method in the same class)

GitOrigin-RevId: 4cf9d044c0e74a5fb2ccb134c379918181a8883f
2024-06-15 23:25:40 +00:00