Commit Graph

316 Commits

Author SHA1 Message Date
Alexey Merkulov
94704d2a77 [debugger] Reduce debugger registries
Registry FALSE value of the debugger.always.suspend.thread.before.switch registry is merged to debugger.how.to.switch.to.suspend.ala as DISABLE option

GitOrigin-RevId: 2ec66611c6b8f4803e717ea92e230ecaa96ce527
2024-07-22 18:16:02 +00:00
Tagir Valeev
9b8d299c1e Warnings fixed (i18n+others)
GitOrigin-RevId: 404f67f93b6c8d0df6ed13774791fc2d12b613cc
2024-06-27 11:21:13 +00:00
Alexey Merkulov
05e380cad5 [debugger] Rework thread resuming/suspending handling
Before the main approach was to make symmetrical suspend/thread operations. It can hang debugger in some cases. This change applies another approach: after operation, the debugger returns the thread to the needed state.

GitOrigin-RevId: d52f3cbf55f1d6cd44088bd732d85e2f90cae5d1
2024-05-29 15:30:49 +00:00
Alexey Merkulov
7e9eee4348 [debugger] Improve problems handling
It is incorrect to check all threads because some of them could be created after VM machine has been stopped by some suspend-all event

GitOrigin-RevId: ed4725b151c14b9162af91e0739aa37cc9b13376
2024-05-23 16:03:59 +00:00
Nikolay Chashnikov
afde5c0221 [java debugger] API cleanup: remove unused deprecated API (IJPL-503)
GitOrigin-RevId: 6389dbd06b0f268b48e30fc497bd2a1e8ef9425c
2024-05-15 23:25:49 +00:00
Alexey Merkulov
0fd2282f5f [debugger] Add registry to check the debugger engine consistency
GitOrigin-RevId: e224f9e193be8d10d222c7bfa665d1cda279c5a0
2024-04-22 21:07:46 +00:00
Vladimir Parfinenko
9069cc3dd2 [debugger] get rid of "Line and Lambdas" naming, fix IDEA-351980
Rebrand it internaly to "all positions" and just "Line Breakpoint" externally.

^IDEA-351980 fixed

GitOrigin-RevId: d869ba16014b738b6d24cc3988497bce0aedbf60
2024-04-18 10:55:08 +00:00
Alexey Merkulov
70d365d25a [debugger] Add notification about other threads also reached breakpoints
GitOrigin-RevId: 80bfff529dd80246ce8dc706bc126d6fdbe5924b
2024-04-16 20:08:55 +00:00
Alexey Merkulov
c5d47a6f55 [debugger] All breakpoints should be suspended in suspend-thread mode before switching to suspend-all mode
The change is under the registry now. It would fix a lot of problems with filtering, conditional break-points and so on, e.g. IDEA-349297

GitOrigin-RevId: a5b0e0090254f4ebd1d4355aa616bd6221993934
2024-04-16 20:08:44 +00:00
Vladimir Parfinenko
33577916cf [debugger] fix read access: EA-1044477, EA-1087462
GitOrigin-RevId: 670861d9a5dc24dbff83932806c7f9aabb610ee3
2024-02-19 16:31:15 +00:00
Yann Cébron
084b4bb75a [java/jvm] mark EPs as PossiblyDumbAware
GitOrigin-RevId: e91e26dabe85c81567c8cf94fde710e5df5908ba
2024-02-12 16:51:39 +00:00
Vladimir Parfinenko
0b1e060f0f [debugger] hide stack frames of classes filtered during stepping, IDEA-345410
Add checkbox into settings

^IDEA-345410 fixed

GitOrigin-RevId: 53405a88e876db945ac0713d3c4fb3d5a11e131f
2024-02-12 16:38:07 +00:00
Vladimir Parfinenko
f6346d4337 [java/kotlin debugger] add method/field breakpoint properties into tooltip, IDEA-343399
^IDEA-343399 fixed

GitOrigin-RevId: 95db4e3e3b2eaa4f39c8a2eaace15262a4017783
2024-01-18 14:30:02 +00:00
Vladimir Parfinenko
3ddcca04a6 [java debugger] better tooltips for Java breakpoints, IDEA-334537
^IDEA-334537 fixed

GitOrigin-RevId: dd1ebee1c8eecaf171f7c124ca60212bd4bd5bee
2024-01-17 19:00:09 +00:00
Vladimir Parfinenko
f33959ccc5 [debugger] unify Java exception breakpoint name with other languages
GitOrigin-RevId: 73d925d5377f3fcc43e28c8b4c66808d068872ba
2024-01-17 13:13:36 +00:00
Vladimir Parfinenko
d7fd4151c1 [debugger] include column number into XBreakpointType.getDisplayText()
GitOrigin-RevId: 357e8ec668fab25a77431b31e0923e2731ee0f20
2024-01-17 13:13:23 +00:00
Vladimir Parfinenko
cfbcaa1e41 [debugger] breakpoint tooltips cleanup, fix IDEA-343151
Simplify XBreakpointType.getDisplayText() by excluding
Java properties from it.

^IDEA-343151 fixed

GitOrigin-RevId: 2b6a14744e36e813d52315a5e7126d957a43f1d3
2024-01-17 13:13:16 +00:00
Nikita Nazarov
cd69495d25 Add common dialog window for retained size and paths to closest gc roots actions
https://github.com/JetBrains/intellij-community/pull/2570

GitOrigin-RevId: 440eb5ad0d254db37f5ccc28295ed3b334978d2b
2023-10-18 12:33:15 +00:00
Egor Ushakov
19b3f67759 IDEA-335023 Can't run Tomcat (IAE: duplicate element: com.intellij.openapi.fileTypes.PlainTextFileType@2e20b90a)
GitOrigin-RevId: 3a44d49b372e25bdd9c6d32203c13011fda89447
2023-10-17 11:33:20 +00:00
Vladimir Parfinenko
2f7f12e813 [debugger] try to prevent errors while getting Document by PsiFile, EA-920865
At the cooler it was said that ViewProvider is better than PsiDocumentManager

GitOrigin-RevId: 7d9a62f98acc463d1afa449c6262d0112f294d90
2023-10-09 18:28:54 +00:00
Nikolay Chashnikov
d67bdd5b72 [java] API cleanup: remove unused deprecated API (IDEA-322162)
GitOrigin-RevId: 8b8a875126194efe99989d51127072dd8e503d6e
2023-09-29 09:21:34 +00:00
Egor Ushakov
5c7ffb0969 fixed yellow code - use Set.of
GitOrigin-RevId: 0bacb04bd33c288a57405d52e867785546de216d
2023-08-18 14:08:09 +00:00
Egor Ushakov
7c97c4895d yellow code cleanup - use isEmpty
GitOrigin-RevId: 0baafb28bee61c3178b842f6246ac67ce62f17ff
2023-08-17 19:47:45 +00:00
Vladimir Parfinenko
fcca767ed2 [debugger] better disable inline breakpoint on return on Android
Allow conditional return breakpoints in library files (they have no module).
Also add notification about setting line breakpoint instead of inline on Android.

GitOrigin-RevId: d95a76ac71b1f589a68a015ad2c84f7a846e50ff
2023-07-24 14:32:49 +00:00
Max Medvedev
c5be6baafc [java debugger] SourcePosition#getElementAt is nullable
it indeed can return null, and clients should be ready for that

GitOrigin-RevId: c1a0c0b01951cf3035a4633bae0906f38a07060a
2023-07-09 12:48:19 +00:00
Egor Ushakov
178a0cdb87 IDEA-307792 Remove unused 'Hotswap in background' field from the debugger settings
GitOrigin-RevId: 7fa142d5361a46324462ded51cd5ec1136f66292
2023-06-23 15:17:28 +00:00
Vladimir Parfinenko
c9c9d58c9f [debugger] breakpoint on return inside one line if-return statement in Kotlin
^IDEA-315974

GitOrigin-RevId: 03c949e90b39f5cf9fd1c9b149b20ef7c4f56873
2023-06-16 09:43:44 +00:00
Vladimir Parfinenko
f7e1075301 [debugger] make Java breakpoint variants more clear
Rename "All" to "Line and Lambdas" as in Kotlin

GitOrigin-RevId: aa7adde794ec482b94372a8a3865e52db1475afa
2023-06-16 09:43:37 +00:00
Vladimir Parfinenko
ef260ef1aa [debugger] skipped breakpoints: add link to documentation
^IDEA-169914

GitOrigin-RevId: 4a5115b92718135d812bf9d8925a9527017343b5
2023-06-15 19:56:36 +00:00
Vladimir Krivosheev
227d75a1fc don't extend DynamicBundle
GitOrigin-RevId: 49cbebd629a92877dbeeffba8d97b0631fb9407e
2023-05-05 09:46:42 +00:00
Vladimir Parfinenko
a519073b0a [debugger] notify about skipped breakpoints during stepping IDEA-169914
Also perform logging for such breakpoints if any

GitOrigin-RevId: 5da09fa62a9a63984b240a0c36c0f621fcf38d07
2023-03-20 18:20:39 +00:00
Alexey Kudravtsev
9f5b60b0f0 replace some usages of ContainerUtil.set() with immutable sets to get rid of unclear-semantic methods
GitOrigin-RevId: 3ba1266af01d64a228c10df59b18c4ac797c2a9b
2023-02-20 19:11:19 +00:00
Alexey Kudravtsev
b95c41986e replace some immutableSet() with more standard Set.of()
GitOrigin-RevId: 3efd3c74490ef85971909ff3461d0f6cf8746aa7
2023-02-20 02:44:57 +00:00
Alexey Kudravtsev
93b8841b03 fix typo
GitOrigin-RevId: 974ae2b912bee06489d21355045397a883c2e34b
2023-02-17 16:12:35 +00:00
Artemy Pestretsov
294181000b [dfa debugger] extract common presentation code to allow reuse in PHP dfa debugger implementation
related to WI-70670, review IJ-CR-102855

GitOrigin-RevId: 0d58dcc3e53f6d4955dcec4cec9630fb9a63bd5a
2023-02-15 13:24:27 +00:00
Tagir Valeev
e9832acb26 [java] Use pattern variables; other minor cleanup
GitOrigin-RevId: e2345bd54d92f6676c6fbc55955e85cbdc5c2793
2023-02-01 17:09:26 +00:00
Nikolay Chashnikov
dce2adeea1 cleanup: remove redundant '@author' tags from javadoc comments - 22
Now we have Code Vision hints which determine the author via Git history and show it in the editor automatically, and this information is more accurate than the tags which were automatically added when files were created.

GitOrigin-RevId: 1e27fae6caa509913af40df9c827a890719d53e8
2023-01-18 17:02:37 +00:00
Roland Illig
db9b520892 Format code in intellij.java.debugger
GitOrigin-RevId: 86709d635442ffd1cd33494b45788233a296e266
2022-12-15 09:24:10 +00:00
Roland Illig
984f9a2540 Convert debugger documentation from HTML to Javadoc
GitOrigin-RevId: e12f0c11328a096a4d486eb422a7382cce1b4cd8
2022-12-13 10:18:45 +00:00
Alexey Belkov
74076e92d6 Use a more correct form of "fully qualified" phrase in messages
A hyphen is not needed. Examples:

https://docs.oracle.com/javase/specs/jls/se11/html/jls-6.html#jls-6.7

https://en.wikipedia.org/wiki/Fully_qualified_name

GitOrigin-RevId: 1212ebc0b70acf1519c78e68e363a7c9e9cf92da
2022-11-15 17:23:35 +00:00
Andrey.Cherkasov
6e7af5f625 debugger: record patterns support in evaluation
IDEA-301140

GitOrigin-RevId: c91c6667ceb7e1679262945ceb5337e54fb4be9e
2022-10-17 23:56:27 +00:00
Tagir Valeev
37cf32c901 [dfa-assist] Option in settings to turn off gray-out instead of registry key (IDEA-296575)
GitOrigin-RevId: a19fd7be9aadbfc2b5fa95d2d7363efac9e6a1db
2022-09-15 09:59:55 +00:00
Egor Ushakov
4f72c21d8f debugger - fallback to the default renderer in custom is unable to be evaluated
GitOrigin-RevId: f65e4dd132b14561c7bd216c1a44e805bf1aecc9
2022-08-25 13:24:34 +00:00
Egor Ushakov
3bdfb5c64f debugger code cleanup pt.2
GitOrigin-RevId: 7c2b28d49f73595dfdd69623f0dc10b7321e5133
2022-08-19 17:35:09 +00:00
Egor Ushakov
16b16d7c7e debugger cleanup - added final
GitOrigin-RevId: d1be762172cd530dec228bc4b3596fe1c6403e7a
2022-08-19 09:34:38 +00:00
Tagir Valeev
9038e3f77b Remove empty and irrelevant javadoc tags
GitOrigin-RevId: dcbbb8cff7ef267525129c464769f761d92c2120
2022-08-09 09:41:49 +00:00
Egor Ushakov
f33bccf2ff cleanup: removed redundant suppressions
GitOrigin-RevId: a0199a17e9def9f93bc6da1eaac504b1a6d0787a
2022-08-03 18:10:13 +00:00
Vladimir Krivosheev
c542bbd12d prefer to not use ExtensionPointName.extensions() (part 2- java)
In Kotlin streams should be not used, in Java extensions() maybe not performant if you in any case traverse the whole extension point

GitOrigin-RevId: 0b2f9df27d9580c22e78f8017b5d21edeb39e8df
2022-07-20 04:39:56 +00:00
Alexey Kudravtsev
3f2a2eaf34 JavaElementVisitor: notnull
GitOrigin-RevId: e4b356ce28796e2631b0a631b5108e0348b77baf
2022-06-11 23:31:48 +00:00
Elizaveta Sidorova
e661b867d8 IDEA-281278 Collection modification breakpoint
added debug mode, fixes for instrumentation and ide side

GitOrigin-RevId: aa51696888a5691de03072586ebd35b0a521f4aa
2022-03-28 18:26:29 +00:00