Commit Graph

6168 Commits

Author SHA1 Message Date
Alexey Kudravtsev
1828479d17 refine IDEA-284880: do not run Kotlin error highlighting/Java HighlightVisitorImpl during essential highlighting, but do run JavaNamesHighlightingVisitor/Kotlin names highlighting
GitOrigin-RevId: 2ea4b2ef0f5ddb2e8efb193c2c5798942dfea962
2022-01-20 13:23:43 +00:00
Anna Kozlova
8697bd962c [inspections] additional logging
GitOrigin-RevId: dcfc04ee81356d9a619d057401317afb5bda9c47
2022-01-19 19:15:51 +00:00
Ilyas Selimov
c7d80fb16a [java unused declaration] - excluded functional ref node out of the graph
GitOrigin-RevId: 28ca95ff4709b8c7466abee73054d1bbb52ee28a
2022-01-19 08:40:35 +00:00
Anna Kozlova
aa026b50f3 CCE
GitOrigin-RevId: 83de035ff519b7d9a43d2313321ec395bd691af0
2022-01-19 07:21:08 +00:00
Tagir Valeev
ff5d33a8c6 [java-analysis] Avoid inference for play.db.jpa.GenericModel
Fixes IDEA-285334 Incorrect contract inference for Play framework class leads to wrong nullability warning

GitOrigin-RevId: 3a50cd2ec26fe451a3d9813ae451558205ba7d6e
2022-01-19 04:28:26 +00:00
Andrey.Cherkasov
7524dc20ff [java-highlightings] Provide missed fix to fix containing method return type for conditional return
IDEA-256730

GitOrigin-RevId: 98a8befb15c2b571d1020d34018d88a60b952363
2022-01-19 04:16:49 +00:00
Andrey.Cherkasov
381684d2b2 [java-highlightings] Don't propose fix making return type void for method calls in conditional expressions branches
IDEA-256730

GitOrigin-RevId: 2953a47102a15fa572ac8271edb9bb0fe7c2f49e
2022-01-19 04:16:47 +00:00
Andrey.Cherkasov
bbd337ff8f [java-highlightings] Rename method and make it public
IDEA-257275
IJ-CR-19483

GitOrigin-RevId: 0989fc851ac558502b330f0df0a7d0cf86fb000e
2022-01-19 04:16:46 +00:00
Andrey.Cherkasov
b09fec3077 [java-highlightings] Refactoring: invert 'if' conditions
GitOrigin-RevId: 83d5d35ef22385b3e3b31d77ba0df974843d7307
2022-01-19 04:16:44 +00:00
Tagir Valeev
d2e2a474ad [java-dfa] First class support for Collection.removeIf()
Fixes IDEA-286737 Side-effects from removeIf predicate are not taken into account

GitOrigin-RevId: 6efc71f98d10824a288e4510a209da34ad381bbb
2022-01-18 15:44:01 +00:00
Anna Kozlova
e3c0d74cb6 [java] don't propagate ellipsis type as target type for non-vararg calls (IDEA-286407)
GitOrigin-RevId: 3693373240012db841bffaca1a5f8765200acbc8
2022-01-17 18:21:45 +00:00
Tagir Valeev
09c99286e9 [java-dfa] Ignore locality in isSuperType for types compared by equals()
Fixes IDEA-286020 False-positive 'result is always false' when converting string to bytes and backwards

GitOrigin-RevId: 274434e1f80a127645a71cf14d6218fa90aa76ca
2022-01-17 11:13:59 +00:00
Tagir Valeev
48414eeacf [java-dfa] Avoid capturing PSI element
GitOrigin-RevId: 6c37af43d0ca1f578879443cacde09d1160745f7
2022-01-17 11:13:58 +00:00
Andrey.Cherkasov
74d3b7fad5 [java-highlighting] Provide fix "Create missing branches" for an empty switch expression (IDEA-282606 )
GitOrigin-RevId: 5c63a5b3ce77f40aef226bafe1b904befc816734
2022-01-15 19:22:12 +00:00
Andrey.Cherkasov
1687e43a3f [java-highlighting] Fixes after review (IJ-CR-19483)
GitOrigin-RevId: 19cb1e1ef0b68a296085fcee6d452ec40c51baf9
2022-01-15 19:22:09 +00:00
Tagir Valeev
0f431159c9 [java-dfa] Properly process boxing of generic parameter in constructor
Fixes IDEA-286477 Primitive type considered null in generic

GitOrigin-RevId: f9e8a5eae5505511d84258b8a1bd67deafe8b8a3
2022-01-13 12:45:34 +00:00
Alexey Kudravtsev
a8fca0e475 split java highlighting into error-warning diagnostics (left in HighlightVisitorImpl) and pretty name highlighting (moved to JavaNamesHighlightingVisitor) for more fine-grained control over highlighting for IDEA-284880 "Essential" highlighting mode
GitOrigin-RevId: b0079ce4beba7f432561a16d5d78bc1e74cd53f8
2022-01-11 13:56:11 +00:00
Alexey Kudravtsev
b7da86785f cleanup
GitOrigin-RevId: 4f4c0fe3af8436168b269357cf32717fc1f43c63
2022-01-11 13:34:29 +00:00
Tagir Valeev
2d08b71a4e [java-inspections] IDEA-285964 Replacement for 'Expression can be replaced with Double.compare()' sometimes breaks the code
Option is added to disable the inspection when semantics change is possible

GitOrigin-RevId: 97e5576582b65c3ba0cb3122d6274a37e271386d
2022-01-10 08:52:07 +00:00
Andrey.Cherkasov
214ee7b316 [java-highlighting] Bad type in switch expression: provide quickfix to change return type of a method
IDEA-257275

GitOrigin-RevId: 5032f269098c8d6aa16a2a9231fc9ac566b85487
2022-01-04 21:57:32 +00:00
Alexey Kudravtsev
3fbe8f4d7c cleanup mess with unnecessary or wrong nullable/notnulls
GitOrigin-RevId: 8c6e4cd3715765510f1fb19e4be78bb6617d92ad
2021-12-30 12:37:35 +00:00
Alexey Kudravtsev
4359b65804 cleanup
GitOrigin-RevId: 9f9e6dab95bb5b4d6dc24d008c12316bbc4d6278
2021-12-30 12:37:28 +00:00
Alexey Kudravtsev
065798281a cleanup
GitOrigin-RevId: b9620e6f5df659a1547053feea885e2b1873731f
2021-12-30 12:37:25 +00:00
Dmitry Batkovich
8c6999422c drop VfsDependentEnum (since it exposes implementation details), use AttributeInputStream / AttributeOutputStream.
Required for LAB-107 to introduce composite VFS storages.

GitOrigin-RevId: 560a0a6acfe838bb12af66825e8ef83c53eafd58
2021-12-27 13:05:55 +00:00
Anna Kozlova
f5e4092ba8 [java] compare cls/psi modules correctly (IDEA-283483)
GitOrigin-RevId: b5be62cce3426c76842283472f1f415b0fbb3b52
2021-12-23 23:47:36 +00:00
Tagir Valeev
34192fbc95 [java-dfa] IDEA-285470 DFA: The reason of an Integer variable being always non-null after a ternary operator isn't very clear
GitOrigin-RevId: 476eb0cd257bd8bc77cf728bb65a559fdae229e4
2021-12-23 05:38:28 +00:00
Tagir Valeev
e0815c4cb5 [java-inspections] IDEA-284517 False positive for inspection @NotNull/@Nullable problems
GitOrigin-RevId: 1051f122adeba7f94fd8dc6bdf002f8ece7bcc82
2021-12-21 04:52:15 +00:00
Alexey Kudravtsev
0035ac9685 initial commit of IDEA-284880 "Essential" highlighting mode
GitOrigin-RevId: 6ad1142255e687e0898b8039998cfa72d34c0483
2021-12-20 13:05:56 +00:00
Bas Leijdekkers
9629bb5f5d [redundant throws] fix another race condition
GitOrigin-RevId: 3aac8e3c0e760f75307eb4260b09000546ce1665
2021-12-20 10:55:03 +00:00
Nicolay Mitropolsky
ee56e32200 Uast: cleanup after KT-30546,KT-30957 fixed
GitOrigin-RevId: ea67f660a092472234561c41b08eef5d5c3eb04e
2021-12-20 09:59:25 +00:00
Anna Kozlova
9b9deef0d2 [java] lvti: small optimizations
no need to check initializers for fields where var is not applicable anyway

GitOrigin-RevId: f31edd667ad7c46548fa85b7be60457f538dee3d
2021-12-20 08:23:04 +00:00
Tagir Valeev
973ebe7d60 [java-dfa] Check mutability for inlined Map methods
Fixes IDEA-285183 Enhance dfa: Add check mutabilaty for Map.merge and Map.compute
Also fix the lattice for Mutability
Tests from PR#1877

Co-authored-by: pyltsin-m <pyltsin-m@yandex.ru>

GitOrigin-RevId: 9b29b2ccf3d56092e0ef5ecf1a00243cfeb1e493
2021-12-20 07:01:11 +00:00
Anna Kozlova
39c9cc95c7 [java] lvti: report self referencing problems on refs, not on 'var' type (IDEA-284840)
IJ-CR-18768

GitOrigin-RevId: 37e3a9f52cd07f7a4554181a8f665545c9b7d0cb
2021-12-17 09:19:57 +00:00
Bas Leijdekkers
b3dcce0941 [global inspection] more wait for initialized and logging to fix race conditions
GitOrigin-RevId: 5d160099032a99d19ae93984ea310565e403fbe0
2021-12-16 15:27:44 +00:00
Anna Kozlova
bbf809f75a [java] don't calculate var type based on invalid data; reorder var based errors (IDEA-284840)
GitOrigin-RevId: 097f9b2d66f9381a321efe16d3ebc155ac31ee39
2021-12-16 05:53:07 +00:00
Bas Leijdekkers
dbc5354977 AnalysisScope: iterate over virtual file set if it is available for increased performance
GitOrigin-RevId: 6c0b2a1eafe4e25f591649c2af778f4fa6a8f293
2021-12-15 15:53:01 +00:00
Bas Leijdekkers
7e77df442f [global inspections] wait for initialized to avoid race condition
GitOrigin-RevId: c70dd0260da5504ee23632d735acaf59529820c0
2021-12-15 15:53:00 +00:00
Tagir Valeev
7367405b46 [java-highlighting] IDEA-284864 Improve reporting of always false while/for loops
GitOrigin-RevId: 9e7403383296cfa3c9478d8e635e592d31ba0518
2021-12-14 13:26:42 +00:00
Gregory.Shrago
12c74c9d89 make java fqn index use string keys
GitOrigin-RevId: 637d790f739944841efe199888666d2fe300dbf2
2021-12-14 12:42:07 +00:00
Tagir Valeev
f7f8e1ac14 [java-dfa] JavaDocs
GitOrigin-RevId: 33ef2b7cca378ff5e6ab4a3dbdc642748671d72b
2021-12-14 08:25:21 +00:00
Tagir Valeev
2fea8eb09e [java-inspections] Support preview for SetInspectionOptionFix inside DataFlowInspection
GitOrigin-RevId: bf15c8f03396f120746e7e6008460647216971ae
2021-12-13 10:26:43 +00:00
Roman Shevchenko
cbd0b038ee [platform] deprecating NullableLazyValue#createValue
GitOrigin-RevId: c5311629de456c0890fbd4fbdf2e65cc14b9d2e3
2021-12-13 07:08:11 +00:00
Ivan Semenov
a29f755592 [ui] remove duplicated property
GitOrigin-RevId: e9aa2a4efa27c794cda905e081137cda798ab5bb
2021-12-12 22:40:03 +00:00
Tagir Valeev
325edf9af2 [java-highlighting] IDEA-202570 Unreachable statement inspection should highlight whole switch expression
Also, fixed unreachable statement highlighting in different cases

GitOrigin-RevId: 20b28272b51c77e3413e1ca143222d35199728bd
2021-12-08 02:48:47 +00:00
pyltsin-m
0ded7bc2f5 [java-inspections] IDEA-284073 Enhance dfa: Support that Stream.toList() is unmodifiable
PR#1861

GitOrigin-RevId: ddddc2451708df8e11d00e059eafdb8674fa562b
2021-12-06 10:05:53 +00:00
Tagir Valeev
7cfaafd403 [kotlin-dfa] KTIJ-20287 Kotlin DFA: First-class support for object types
GitOrigin-RevId: 91cff5f08e01a7ab7fc9656abb0618bed2ab2dda
2021-11-30 08:36:22 +00:00
Anna Kozlova
e6165048e8 [java] skip plain cannot infer diamond error (IDEA-283409); add ambiguous constructor call (IDEA-272115)
this unifies error messages with method calls and allows more specific tooltips and additional fixes

GitOrigin-RevId: 5ab4340d822bba3d6563da12a16e4c41216a8627
2021-11-29 19:27:48 +00:00
Andrey.Cherkasov
01cc4df97e [java-inspections] Java8ListReplaceAllInspection (IDEA-270920)
GitOrigin-RevId: 1e79021fc4860398bc7bab047a5ec692e137d9dc
2021-11-29 06:59:20 +00:00
Tagir Valeev
d0348e9ba0 [lombok] IDEA-283371 Disable constant expression evaluation for Builder.Default fields
GitOrigin-RevId: 7c5f5b6bd9eb1f462af626ecd4a7b43519c62ada
2021-11-26 10:11:33 +00:00
Tagir Valeev
fb01dcf951 [intention-preview] IDEA-283366 Intention preview for "Set inspection option" fix
GitOrigin-RevId: 5a1e2ea46191542d56df2beba6fefb0b0b438981
2021-11-26 06:37:13 +00:00