Commit Graph
318 Commits
Author SHA1 Message Date
peter 57267fe776 Enum.values() is not-null (IDEA-161644) 2016-09-23 12:59:47 +02:00
peter b571394209 don't infer ->null contracts in scope of @MethodAreNonNullByDefault (addendum to IDEA-160991) 2016-09-21 10:50:31 +02:00
peter e3e321d056 issue dfa warnings when comparing non-final variables with constant values (IDEA-157871) 2016-09-20 16:41:43 +02:00
peter ca8004bfea IDEA-160991 Returning null should result in a warning in @TypeQualifierDefault notnull method 2016-09-19 18:05:40 +02:00
peter 9e1704670c support org.springframework.util.Assert.notNull (IDEA-159977) 2016-09-16 15:54:58 +02:00
peter e9e9dbfffe IDEA-160635 'Condition always true' inspection sometimes incorrect when inner class access final field 2016-09-07 16:25:08 +02:00
Tagir Valeev 87bea236f2 IDEA-160428 IDEA-CR-13384 Parenthesized expressions support 2016-08-30 10:55:06 +03:00
Tagir Valeev 625c740f99 IDEA-160428 Lambdas passed to Optional.map/filter/flatMap/ifPresent could have their argument implicitly marked as @NotNull 2016-08-29 19:03:38 +03:00
Dmitry Batkovich c42625863d null-literal argument: testdata warnings fixed 2016-08-23 17:11:43 +03:00
peter a315b017ca IDEA-159674 "Constant conditions & exceptions" false positive in GeneralCommandLine.MyTHashMap.putAll() 2016-08-22 17:44:56 +02:00
peter 8460252c88 IDEA-159678 Warn about possible NullPointerException on throw 2016-08-22 15:20:44 +02:00
peter 5b9bc05f39 IDEA-159699 Error highlighting is different when using AssertJ descriptions 2016-08-22 15:10:03 +02:00
peter c01814e651 IDEA-159977 inspector "Constant conditions & exceptions" not support org.springframework.util.Assert 2016-08-22 15:10:03 +02:00
Dmitry Batkovich 8a9227543c an index to detect nulls passed as arguments of method parameters + DataFlowInspection and NullableStuffInspection use it to detect method call failings when one of parameters is null 2016-08-18 12:21:51 +03:00
peter bba886e795 Merge branch 'master' of https://github.com/dahlstrom-g/intellij-community into dahlstrom-g-master 2016-08-03 13:55:20 +02:00
peter d923897b64 dfa: don't report the same constant expression twice (IDEA-158693, IDEA-CR-12537) 2016-08-01 20:21:23 +02:00
peter 09f208cf7e IDEA-158693 Returning expression constantly resolving to true not flagged as constant (Constant Conditions & Expressions) 2016-07-25 18:35:39 +02:00
Dana Dahlstrom f258f4ae01 Apply hard-coded contract to Assume.assumeThat
Change-Id: I35f88942f58c295b9a7343fc28496f54fc8f4b80
2016-07-18 18:59:38 -07:00
Dana Dahlstrom 9ab16ef854 Apply hard-coded contract to TestVerb.that
… to support TestVerb-returning methods like TruthJUnit4.assume,
Truth.assert_, and Truth.assertWithMessage, in statements like
assume().that(…).isNotNull().

Change-Id: Idbb1e9cfe6e58b067577fffc4ed301807ebbab9d
2016-07-18 18:59:38 -07:00
peter 6152c5b3c2 IDEA-151717 Ignore equals method for @ParametersAreNonnullByDefault 2016-06-07 17:44:20 +02:00
peter a124d8b134 IDEA-154872 Good code yellow: NotNull/Nullable analysis is not working properly when annotations have target TYPE_USE 2016-06-03 09:42:06 +02:00
peter e1b69b301e IDEA-156245 @NotNull doesn't seem to work for enums 2016-05-18 19:44:27 +02:00
peter 6a17887211 correct dfa comparison of boxed NaNs (IDEA-156202) 2016-05-18 19:44:26 +02:00
peter d8093d9057 IDEA-155801 "Dereference may produce NPE" warning should handle implicit constructor calls. 2016-05-13 16:15:15 +02:00
peter 786b4f5048 IDEA-156007 'Constant conditions & exceptions' inspection should propagate @Nullable/@NotNull annotations to lambda parameters 2016-05-13 16:15:15 +02:00
peter e3c07073c5 honor array component type nullability in index expression dfa (IDEA-154874) 2016-04-19 14:00:31 +02:00
peter 1475442c3f IDEA-154811 Nullable inspection is incorrect with user-defined valueOf static method in Enum 2016-04-19 12:33:19 +02:00
peter 0a9d2963ae don't lose precision during constant comparison in dfa (IDEA-153532) 2016-03-24 11:54:45 +01:00
peter f871d33fc8 IDEA-151355 Wrong 'condition always false' after using decrement on object field 2016-02-10 12:39:20 +01:00
peter c1fdc02b1a Enum.valueOf and annotations methods are not-null (IDEA-151305, IDEA-151174) 2016-02-10 12:39:19 +01:00
peter b3c40ee773 dfa: highlight just method reference name on possible NPE warnings (IDEA-149904) 2016-01-20 16:47:53 +01:00
peter 1392e7705f dfa: don't shadow final variable reassignments with wide irrelevant warnings (IDEA-148984) 2016-01-19 18:15:31 +01:00
peter f012d6fe41 dfa: flush only ++ unary operator arguments (IDEA-150271) 2016-01-19 18:15:31 +01:00
peter 0ddd1243b9 honor vararg calls when inferring contracts (IDEA-148862) 2015-12-03 17:32:53 +01:00
peter 9d2abd7276 IDEA-148657 "if (false)" quickfix text is meaningless 2015-11-30 16:26:38 +01:00
peter ab6ec15175 IDEA-148477 Handle AssertJ assertions in the same way as JUnit assertions 2015-11-26 08:28:04 +01:00
peter 2aa8b8c099 Revert: perform arithmetic operations during dfa (part of IDEA-143315) (ea61e3e9e6) 2015-11-18 16:14:35 +01:00
peter ea61e3e9e6 perform arithmetic operations during dfa (part of IDEA-143315) 2015-11-17 17:19:44 +01:00
peter 66b5456707 IDEA-146131 @NotNull on parameters should only apply until reassignment 2015-11-17 17:19:43 +01:00
peter 27271e9979 dfa: IDEA-146950 "<" expr is always false but "<=" is not 2015-10-28 14:02:36 +01:00
peter 488ef11fd4 dfa: support (i)++ (IDEA-146805) 2015-10-26 16:20:47 +01:00
peter af07f88aef IDEA-146122 Wrong 'can produce NPE' after comparing with enum constant 2015-10-12 13:33:38 +02:00
peter 67bfef7b1d dfa: add a test for assignment with side effects inside method calls (IDEA-145401, IDEA-CR-5542) 2015-10-12 13:33:37 +02:00
peter f3c4a52ece dfa: don't suggest to assert/surround-with-if possible NPEs on volatile fields, suggest to extract a local variable instead (IDEA-145668) 2015-10-06 16:59:10 +02:00
peter f98d01be5e dfa: don't suggest to simplify boolean expressions with side effects (IDEA-145401) 2015-10-06 15:29:27 +02:00
peter 06c0f35c8f IDEA-146009 Good code is yellow: "Unboxing may produce NPE" inside forEach lambda 2015-10-06 15:24:36 +02:00
peter bf4a3805e0 dfa: store CCE state in visitor, not runner: the latter is reused which can result in multiple warning 2015-09-01 21:48:59 +02:00
peter 0bae70149a IDEA-143937 Bogus warning by 'Constant conditions & exceptions' inspection within lambda expressions, due to JSR 305 @TypeQualifierDefault annotation 2015-08-18 20:00:23 +02:00
peter 0c28099a15 IDEA-143014 Wrong 'can be null' warning when assignment is done inside if condition 2015-07-31 13:28:36 +02:00
peter 1b70adbfd4 IDEA-137195 Not annotated constant fields should be treated as Nullable or NotNull when static code analysis is able to prove Nullable/NotNull 2015-07-20 17:20:58 +02:00