Commit Graph

902 Commits

Author SHA1 Message Date
Chris Lemaire
ba6f5feff8 [gitlab] Make file links point to local files in editor (IDEA-325362)
#IDEA-325362 Fixed

GitOrigin-RevId: 2560039da3c1641502070844c94f4b066a6d8344
2024-04-04 17:38:44 +00:00
Chris Lemaire
935bd24737 [gitlab] Make a VM for immutable timeline items rather than exposing model to UI
GitOrigin-RevId: 0db31fc02ae834aefb9c3c6616a6d1b3febcca58
2024-04-04 17:38:44 +00:00
Chris Lemaire
7c63cb8f39 [gitlab] Make a VM for commits rather than exposing the model to UI directly
GitOrigin-RevId: 7b47f88606cf46c78f9fe9694a60c58bcaa48e8a
2024-04-04 17:38:44 +00:00
Andrey Belyaev
1190821f07 [gitlab] IDEA-350674 Get rid of YAML plugin dependency in GitHub and GitLab plugins
Removed YAML plugin dependency in favor of simple file mask check, also check JSON schema as a backup option

GitOrigin-RevId: c704bded148be8e404b27f9416ac93f3f2a9459b
2024-04-04 13:20:02 +00:00
Chris Lemaire
d4a50b4ed2 [gitlab] Fix group projects the user is a member of not showing up in clone dialog (IDEA-350474)
#IDEA-350474 Fixed

Looks like the DTO we used to deserialize project info was the wrong one.
It was 'ProjectMemberDTO', but should've been 'ProjectDTO'.

GitOrigin-RevId: 349aa99d9aa2026587ea8b862791467637518e85
2024-04-03 16:28:28 +00:00
Ivan Semenov
8baf63ad2d [collab/gitlab/github] sort files for review diff the same way files in the tree are sorted
#IDEA-331019 Fixed

GitOrigin-RevId: 2d6614b34228f602573fc4b0c7f468541ca1958b
2024-04-02 14:23:53 +00:00
Ivan Semenov
37aa331340 [collab/gitlab/github] persist review changes grouping preferences
GitOrigin-RevId: 828169e0ac2190b734a35f14a5a62338d55a25ce
2024-04-02 14:23:53 +00:00
Ivan Semenov
16d9271f23 [collab/gitlab] rework MR settings to use flow instead of listener and extract a utility base class
GitOrigin-RevId: 551d76f91a0a9aad4a8d03bf593c4158e7c34985
2024-04-02 14:23:53 +00:00
Chris Lemaire
eaa66170a5 [gitlab] Make sure the same ID is used when storing a target account (IDEA-346082)
#IDEA-346082 Fixed

Seems the account was not overridden because a new ID was generated for the
'updated' account, but it should still override the old account.

GitOrigin-RevId: 36a6dcc6118f0cd23b1d3e96af8282e6393cb884
2024-03-25 12:51:47 +00:00
Chris Lemaire
9432be14aa [gitlab] Cleanup unnecessary comparison
GitOrigin-RevId: daff3adb49fba93a167cb4d1a96dba79139b1807
2024-03-25 12:51:47 +00:00
Chris Lemaire
768aa0bdf0 [gitlab] Fix the rainbow flag emoji for maximum code pride (🏳️‍🌈)
The rainbow flag character has an invisible 'Zero Width Joiner' character
in-between a white flag and rainbow emoji.

Our file of emojis did not contain this joiner character,
meaning the emoji would be displayed as the two separate flag and rainbow emojis.

GitOrigin-RevId: 4fabd1e9290237c1569c81e3923472e0892b9d33
2024-03-11 21:29:41 +00:00
Chris Lemaire
1474903866 [gitlab] Fix MR list constantly in loading state on startup (IDEA-348189)
#IDEA-348189 Fixed

Looks like this was some race condition that happened because `requestMore`
was called rapidly enough to cause to concurrent calls to compete for setting `loadingState`.

GitOrigin-RevId: c6b9e3234bc3ffea3b3f8580944a813baebb4668
2024-03-11 21:29:41 +00:00
Vedana.Voronina
3364f7e9eb [collab/space] IDEA-348001: use different reviewers outline in space plugin
[collab/space] IDEA-348001: add default outline for avatars without status


Merge-request: IJ-MR-127943
Merged-by: Veda Voronina <Vedana.Voronina@jetbrains.com>

GitOrigin-RevId: 6a472fe3d902f531a3a9868bb5af5d140d86294f
2024-03-11 20:50:47 +00:00
Ivan Semenov
a26a18146c [collab/github/gitlab] display review submission errors
#IDEA-348506 Fixed

GitOrigin-RevId: 3c199046b5cfb36eec3a2dd0a7e8f793aca83a3a
2024-03-07 19:35:20 +00:00
Ivan Semenov
1ad4b42a26 [gitlab] prevent top-level exception from MR lookup on push
#IDEA-347481 Fixed

GitOrigin-RevId: 870487898b11dd93399a203cc04894ef591f2c9d
2024-03-07 19:35:20 +00:00
Chris Lemaire
2d218e6da4 [gitlab] Fix fork prefix not specific enough for GitLab (IDEA-347126)
The new prefix will be 'fork/owner/path' if the fork is public, or
'fork/author-username' if the fork is private.

GitOrigin-RevId: 3947a99fc4c729e84e7969bd687ddb8739f2ea6e
2024-03-05 19:10:51 +00:00
Chris Lemaire
c2d9942026 [gitlab] Extract isFork logic to details
GitOrigin-RevId: c20ae4ebed46384f5f089a093cc6ba9855ee399f
2024-03-05 19:10:51 +00:00
Chris Lemaire
670010ad75 [gitlab] Make private forks checkout through special ref (IDEA-326553)
Fixes IDEA-326553

refs/merge-requests/{iid}/head is used here.
Changes to other places where getSourceRemoteDescriptor is called
should still follow sometime.

Currently, the special ref is checked out as a local branch named fork/refs/merge-requests/{iid}/head.
This is not ideal for a few reasons, but future commits should solve this:

Checking out as a branch makes it possible to confuse the special ref as a remote branch. It's not a remote branch and it cannot be made one. You shouldn't be able to push to it, but pull might be made possible in some special fetch way.

GitOrigin-RevId: c74b15971b2620e707a523206fb4ec9ae1f95d70
2024-03-05 19:10:51 +00:00
Chris Lemaire
11f93a3ec4 [gitlab] Remove exception thrown when sourceProject is null (IDEA-326553)
Needed to enable showing private forks.

GitOrigin-RevId: 770e28104552e7de08eeea2a05f210f736bc12c7
2024-03-05 19:10:51 +00:00
Chris Lemaire
dc3c081688 [gitlab] Rename getRemoteDescriptor to getSourceRemoteDescriptor
More accurately describes the project it should describe.

GitOrigin-RevId: 8eb5db8006af823fc206d1740e6269aebfe74152
2024-03-05 19:10:51 +00:00
Chris Lemaire
50988af32c [gitlab] Fix regression in draft notes editing (IDEA-348095)
#IDEA-348095 Fixed

Problem is that when `position[position_type]` is passed, GitLab expects more
position info as well, but the rest of the position information does not exist
for draft replies

GitOrigin-RevId: 641906c5f03f1674b5effacbfcc68859b0122fc8
2024-03-04 13:23:00 +00:00
Aleksandr Krasilnikov
0f955cd14f IDEA-343424 [collab] Convert parameter to receiver
GitOrigin-RevId: 829feffff2de17e2fc67057b54f755db4a82140a
2024-03-03 23:02:06 +00:00
Ivan Semenov
4b170fa639 [git/github/gitlab] don't show review creation action if push is unsuccessful
#IDEA-346954 Fixed

GitOrigin-RevId: 6356f5dd236846055b9bec9a769206f876b63d0d
2024-03-01 17:22:14 +00:00
Aleksandr Krasilnikov
75139d63ef IDEA-343424 [collab] Move diff titles calculation from DiffRequest to DiffRequestProducer level
GitOrigin-RevId: fe424c24186a034888ac929e22ae0be9752e040c
2024-02-29 21:18:06 +00:00
Chris Lemaire
d00daebc7c [github/gitlab] Show warning in panels before login progress
Instead, we show the warnings before entering the steps to progress through login.
This should be enough to indicate to the user that something is wrong.

GitOrigin-RevId: 44224ef46c43431a4981732791c88bd2c3ad1b75
2024-02-29 16:07:38 +00:00
Chris Lemaire
fdb10c20cd [gitlab/github] Resize outlined icons after outlining to be original intended size
Hacky solution, should probably scale down inner icons, but this seemed
more sure to work.

On top of the titular change, SpaceAvatarProvider did not scale
the given unscaled size.

GitOrigin-RevId: eb0dc4eef72516ce77f3a6304da010edbb44d6dc
2024-02-29 15:54:41 +00:00
Chris Lemaire
0f8d5f9e02 [gitlab] Fix focus on validation causing unclosable error popup
#IDEA-326786 Fixed

GitOrigin-RevId: 6c25cf812b1096ba2ac2c8fd2fa37ce9939561d9
2024-02-28 16:34:23 +00:00
Chris Lemaire
794337b917 [gitlab] Fix parameter passing for draft notes API
Parameters should not be passed in the body and should be fully filled out
when updating draft notes.

#IDEA-346910 Fixed

GitOrigin-RevId: 504e72f8f218b8550b6986c03133355fb7c567b0
2024-02-28 16:34:23 +00:00
Ivan Semenov
c35acfb5bc [gitlab] do not create intermittent file to load emojis
#IDEA-347003 Fixed

GitOrigin-RevId: d82e2d07cdcf3dd07b2f7446f6a8860596ca1da6
2024-02-27 18:05:22 +00:00
Ivan Semenov
5683d6351c [gitlab] parse emoji file lazily
GitOrigin-RevId: 4d624d674fa547e27e3c717bf25a9500bab9f0c4
2024-02-27 18:05:22 +00:00
Ivan Semenov
c7e9a11545 [gitlab] fix service retrieval
GitOrigin-RevId: 79024f04cd001252ecfd5e8939c68b833b501b60
2024-02-27 18:05:22 +00:00
Ivan Semenov
08992fdff9 [gitlab] fix project lookup API nullability
#IDEA-347481 Fixed

GitOrigin-RevId: f52dbc567c7524adb155c13d6f6794ac1eb1774f
2024-02-27 14:21:49 +00:00
Chris Lemaire
c73f2e5f61 [gitlab] Fix snippet creation failing with 'Collection is empty'
Happened because the list of known repositories could now be empty.
It had to be non-empty before, but I relaxed the conditions for it for:

https://youtrack.jetbrains.com/issue/IDEA-343813/Missing-Gist-Create-functionality

Follow-up of: 2b2561254120f695d568de7ff9b1da5ee25267f7

GitOrigin-RevId: 05789469e0c60bc5359a4460960a1466ce821937
2024-02-26 16:50:57 +00:00
Chris Lemaire
4195f0083d [gitlab] Explicitly use non-deprecated function
GitOrigin-RevId: 19d54bd2f8873c16efb355cabc35886f18570a33
2024-02-26 16:50:52 +00:00
Ivan Semenov
5619489449 [gitlab] fix git branch popup review actions
do no try to cheat the action system and just hope for the best
apparently data context is now recreated between update and action perform

#IDEA-346815 fixed

GitOrigin-RevId: 29d2cb0558cdcceb373db007dc496a3d4b0d0fe9
2024-02-21 15:42:57 +00:00
Chris Lemaire
281147f2c3 [gitlab/github] Show create gist and create snippet actions when there's an account or repository (IDEA-343813)
#IDEA-343813 Fixed

Trying to strike a balance between users feeling the creation actions are out-of-context
and users missing the actions from their regular palette of context menu actions.

Now the actions are shown if (the action can be performed and) there
is at least one repository of the required type OR the user has a logged in account.

GitOrigin-RevId: 2b2561254120f695d568de7ff9b1da5ee25267f7
2024-02-20 17:59:26 +00:00
Chris Lemaire
a08c52b166 [gitlab] Fix compatibility of repository DTO (IDEA-346667)
Fixes IDEA-346667

No default branch could be present in a repository.
For instance when a fresh repo is created empty.
The parameter should have been nullable just like the GQL schema indicates.

GitOrigin-RevId: 3b6c143e4a09a9569c8a1c952c60df0a0427baa5
2024-02-20 13:34:54 +00:00
Chris Lemaire
588a5938f0 [gitlab] Add comment for 16.8 compatibility fix
GitOrigin-RevId: b892f9ec44a32d10310a8467560d73462c6b01d0
2024-02-20 13:34:54 +00:00
Pavel Gromov
7286f11776 [gitlab] Show exceptions related to an account
GitOrigin-RevId: 7296866d086ec65a91608e56b3797d1e82ed5e80
2024-02-19 22:49:36 +00:00
Pavel Gromov
35a7afc1db [gitlab] Do not block submit action if API does not have property
* #IDEA-340870 Fixed

GitOrigin-RevId: 73b65eea6b1596db3a4f2914c980db4308996b5a
2024-02-19 22:49:36 +00:00
Ivan Semenov
cfd7bd92b3 [gitlab] better bundle texts
GitOrigin-RevId: 54e87c1d994f500b186eee211438a3c0ed736644
2024-02-19 18:07:26 +00:00
Ivan Semenov
6d629fb998 [collab/github/gitlab] extract review diff from editor action and enable for both review systems
GitOrigin-RevId: 51ed4789d2fc11399acc7099882b36538aa47e0e
2024-02-19 18:07:26 +00:00
Ivan Semenov
000e6188b6 [collab/github/gitlab] extract common function
GitOrigin-RevId: 74ed0da5a676010dd209bb6455f4a6052838ae38
2024-02-19 18:07:26 +00:00
Ivan Semenov
1041d117ac [gitlab] do not access data context from potentially separate EDT event
GitOrigin-RevId: 07d27842564466d8e7bdc29dbc2b9dcc28723a1a
2024-02-19 18:07:26 +00:00
Ivan Semenov
5152825958 [gitlab] add some spacing to reaction picker popup
GitOrigin-RevId: f39365563d919fa909cd0de2fd58c20d0b6894d5
2024-02-19 18:06:48 +00:00
Ivan Semenov
859cd38aa6 [collab/github/gitlab] code review reaction UI improvements
* implement a separate component for emoji buttons - PillButton
* implement an icon to paint unicode emojis (this is required to paint emoji with a font separate from counter)
* rework some sized closer to mockups

GitOrigin-RevId: b2ef53bd57fd39dffeca972457151283bb10e385
2024-02-19 18:06:48 +00:00
Ivan Semenov
138cf5f4dc [collab] restore compatibility
GitOrigin-RevId: b55cd9976d0594887ea35c5a7e8ed75394c0801a
2024-02-19 15:36:43 +00:00
Pavel Gromov
682f24b836 [gitlab/github] Show reaction tooltip with reacted users
* #IDEA-345674 Fixed

GitOrigin-RevId: 172b290162f11facf81920acce52782361073cf1
2024-02-18 22:29:09 +00:00
Pavel Gromov
035f8143e1 [gitlab] Add reaction button to note
GitOrigin-RevId: 530b801ae91f4298ae25931216f92ed6473d6345
2024-02-18 22:29:09 +00:00
Pavel Gromov
a5743bee97 [gitlab] Do not show add reaction button for system notes
GitOrigin-RevId: 2823c3c3bf797f6e5a3a623e8803f2103cae350f
2024-02-18 22:29:09 +00:00