Commit Graph

575 Commits

Author SHA1 Message Date
Roman Shevchenko
ac742921c5 Cleanup (typos; formatting)
GitOrigin-RevId: 9733aeebbae11f645b17261f25692b92557ccd3a
2024-05-12 20:30:07 +00:00
Roman Shevchenko
fb5023db6b [project] fixing simple "zero-tolerance inspection" problems
GitOrigin-RevId: a2ed3b1983adba46cd998d7bd1f7f3e7a165d8c5
2024-05-12 20:30:07 +00:00
Nikolay Chashnikov
b966d0247f [xml dom] cleanup: mark 'ConvertContext' parameters in Converter interface and its implementations as @NotNull
Actually, 'null' value is never passed, but explicit annotation simplifies writing code in its implementations, especially in Kotlin code.

GitOrigin-RevId: 8059717d7259eb50a3ef68f2334b5f08c7e81b06
2024-04-24 11:44:31 +00:00
Vladimir Krivosheev
81d76b2102 cleanup
GitOrigin-RevId: 53f17d6aa9ac0e61b01ac7303d70ecbeb1c799fc
2024-04-10 18:11:50 +00:00
Yann Cébron
5b6f3344e1 [xml-dom] NameValue: javadoc cleanup
GitOrigin-RevId: f8a3a2660ba4a4c5c303accea99741f5c8210ccf
2024-04-04 12:29:31 +00:00
Vladimir Krivosheev
c2a197a079 cleanup - sort modifiers
GitOrigin-RevId: 1a7b90e5811669f73d8a4afa4729bf4b202cb1ce
2024-03-23 21:54:26 +00:00
Pavel Porvatov
6455f68265 IDEA-347622 DarculaComboBoxBorder break border composability, e.g. with TitledBorder (Plugin Dev)
GitOrigin-RevId: 0fd5cf127802df99a506b3a5f6d51458b538343a
2024-03-08 23:01:46 +00:00
Nikolay Chashnikov
8856dd6264 API: mark for removal unused deprecated API (IJPL-275)
GitOrigin-RevId: d4f67b9700b60c8eb278ed79baaba4fa01d71fd9
2024-02-16 15:45:57 +00:00
Andrey Cherkasov
1a5d419d00 [xml] Extract method
GitOrigin-RevId: 6f691eaa3d0d67769f7f88e9790db3ce2e87f458
2023-12-13 20:03:23 +00:00
Tagir Valeev
51854f80b3 "Method can be static" fix massive application
GitOrigin-RevId: ed296b85922a6814d5c6057b5cbc720f0c546e41
2023-10-20 19:12:56 +00:00
Alexey Kudravtsev
68bbb35628 cleanup
GitOrigin-RevId: 8d08694a575db2ddac4839630e7874fccfbdbee3
2023-05-10 11:52:06 +00:00
Vladimir Krivosheev
227d75a1fc don't extend DynamicBundle
GitOrigin-RevId: 49cbebd629a92877dbeeffba8d97b0631fb9407e
2023-05-05 09:46:42 +00:00
Alexey Kudravtsev
970ae99e6d use ContainerUtil.createMaybeSingularList() to simplify code
GitOrigin-RevId: 3474c183588944fa16fef901302492bf714aa815
2023-05-04 14:09:30 +00:00
Alexey Kudravtsev
cce3935791 remove/deprecate unnecessary/duplicate methods from ContainerUtil
GitOrigin-RevId: 24aaa90f7abd6d6d035fd5216fc2c35eb09a5f76
2023-02-25 01:30:39 +00:00
Alexey Kudravtsev
fc61259925 notnull
GitOrigin-RevId: d8b536dea17f2a2c435a04822ad95b220b8397b1
2023-02-22 01:13:04 +00:00
Alexey Kudravtsev
9f5b60b0f0 replace some usages of ContainerUtil.set() with immutable sets to get rid of unclear-semantic methods
GitOrigin-RevId: 3ba1266af01d64a228c10df59b18c4ac797c2a9b
2023-02-20 19:11:19 +00:00
Alexey Kudravtsev
91cd121707 assert no null LocalQuickFixes are passed to CommonProblemDescriptorImpl inside the "quickFixes" array (IDEA-312632), fix usages
null arrays still can be passed, but arrays with null elements are rejected because:
- consistency: it was very complicated (for both clients and implementation code) to understand if this particular fix could be null or not, and
- performance: filtering out null elements from the array and reallocating them back were noticeably expensive.
Currently, this assertion works inside tests only, to avoid irrecoverable failures in third-party plugins

GitOrigin-RevId: b71bc59eb811a807a0e6aae9609c368806f54869
2023-02-13 18:09:58 +00:00
Tagir Valeev
f456ed0604 Pattern variable can be used mass cleanup
GitOrigin-RevId: 55839bf0deca5f81d0f7eb5b1c190145a5ea0037
2023-02-07 13:58:20 +00:00
Nikolay Chashnikov
3db1e0326b [xml] get rid of identity-based comparisons of Strings (IDEA-312368)
Such a code is often written by mistake, and 'equals' method should be used instead. If rare cases where identity-based comparison is really needed, the code is changed to use a special Strings.areSameInstance method to make the intention explicit and avoid warnings.

GitOrigin-RevId: 829bedd32ff775a1716f2c58665438fad17848b4
2023-02-06 19:58:49 +00:00
Alexey Kudravtsev
a8b8cf75db remove deprecated
GitOrigin-RevId: d5510a6fbde485b14d4c45a5f7a6082bb499ccfd
2023-01-23 13:50:54 +00:00
Vladimir Krivosheev
57764d700b mark classes final
GitOrigin-RevId: 6414b6f2119c82c7567987dd30b35cab5491d9e2
2022-12-30 06:58:01 +00:00
Vladimir Krivosheev
ea12438629 cleanup
GitOrigin-RevId: 2a6e63b4f7da28dcc19622559059d75c508796b3
2022-12-29 11:24:56 +00:00
Vladimir Krivosheev
a4ae56b1ce deprecate ReflectionUtil.getDeclaredField and getDeclaredMethod in favour of modern Java API (MethodHandles)
Using MethodHandles is not a valid approach to use closed JDK API — should be used via JBR API (see JBRApi)

GitOrigin-RevId: 3f72e2ab29c79199365c0e693cf0ab3161dcb9d8
2022-12-23 08:08:10 +00:00
Vladimir Krivosheev
f6292280e4 cleanup
GitOrigin-RevId: 909129c547ff359c9a6acf9edc5f3f62cee81048
2022-12-23 08:08:09 +00:00
Aleksey Pivovarov
9677b47bb4 ui: remove empty implementations of FileEditor methods
GitOrigin-RevId: 920d974818b756c89fb82d7557cfc7f49c34d293
2022-12-05 13:45:46 +00:00
Dmitry Avdeev
31637fbe4f inline field
GitOrigin-RevId: 5c7fa7daee98ff41a84e88c4ecbded2e1ecd388f
2022-11-23 15:47:58 +00:00
Alexey Kudravtsev
c6940d4a2c remove usages of deprecated Annotation mutating methods
GitOrigin-RevId: df83b2a3abb9737fa9e5f357b5f475e00d9c15aa
2022-11-23 13:38:58 +00:00
Alexey Kudravtsev
1b9babe5b4 get rid of manual Annotation instantiations
GitOrigin-RevId: 03038126e8296790337b300f5b3abf384e289b58
2022-11-23 13:38:57 +00:00
Alexey Kudravtsev
b83ac1cf4f create UIController in background thread to fix EA-658559 T: DirectoryIndexImpl.getInfoForFile
GitOrigin-RevId: 38c490e85140a1478b7a51e0581e5b7d2895ec53
2022-11-18 14:16:17 +00:00
Alexey Kudravtsev
6c04f7b3b4 notnull
GitOrigin-RevId: 3db7a7cec02c3a30aab279b58b5ce292429b69fa
2022-11-01 14:17:41 +00:00
Nikolay Chashnikov
e7195f6214 cleanup: remove '@author peter' tags from javadoc comments
Now we have Code Vision hints which determine the author via Git history and show it in the editor automatically, and this information is more accurate than the tags which were automatically added when files were created.

GitOrigin-RevId: 99ea11604b3d5dfdf838d7f3685477814e642ceb
2022-10-13 14:39:10 +00:00
Tagir Valeev
6f8e403fcf Enhanced switch used (last!)
GitOrigin-RevId: 5ad7f44cb68d05d320391db2187d0e9635812f68
2022-09-23 20:46:32 +00:00
Dmitry Avdeev
fc9d5785d9 DomModelTreeView dropped
GitOrigin-RevId: cf0619e96246051f5e33acafc6b97922e1e4c118
2022-09-22 14:47:50 +00:00
Tagir Valeev
bddacd6ba6 Enhanced switch used
GitOrigin-RevId: b9a7d5074c4eb10c87bae5c7703b9671eb0f1aff
2022-09-21 10:52:22 +00:00
Nikolay Chashnikov
2af22b5ec6 [xml] cleanup: remove unused deprecated API (IDEA-295370)
GitOrigin-RevId: 24450807a44f23ec325ced276e46e21d7d340493
2022-09-16 12:41:40 +00:00
Nikolay Chashnikov
9d75dd6284 API: remove 'for removal' flag from deprecated API which aren't going to be removed soon (IDEA-301912)
GitOrigin-RevId: 520463a07fe7707d67d6a96190e9cc5ea6d31cd9
2022-09-16 12:41:30 +00:00
Vladimir Krivosheev
7a8d37f396 Icon class should be not used directly and should be located in ui but not generic modules (part 2)
GitOrigin-RevId: e384c1191db993a22286f1c7f2f6f83e410a4a5e
2022-08-25 12:30:11 +00:00
Tagir Valeev
9038e3f77b Remove empty and irrelevant javadoc tags
GitOrigin-RevId: dcbbb8cff7ef267525129c464769f761d92c2120
2022-08-09 09:41:49 +00:00
Dmitry Avdeev
d7b0f44fa8 preview for AddDomElementQuickFix
GitOrigin-RevId: 7ec3741a7e5ef40ef7c59198eeda8cc7330e3334
2022-07-28 17:19:33 +00:00
Anna Kozlova
9d50130bbf remove unused return value (was always null)
GitOrigin-RevId: 5e593775263b96e3113ea4cfb3df8e541ea82700
2022-07-20 09:24:49 +00:00
Dmitry Avdeev
d7cf8b2a15 action-update-thread: dom action fixed
GitOrigin-RevId: aca0dc05b88ff79d87a3c2224d84cc70852b289c
2022-07-08 20:21:46 +00:00
Andrew Kozlov
4826e8983d [actions] action-update-thread: xml dom action fixed
GitOrigin-RevId: cd6316f577cb3600636e2f8da069d8c2f35fc9fe
2022-07-08 19:17:01 +00:00
Dmitry Avdeev
b371836a0a action-update-thread: xml dom actions
GitOrigin-RevId: 6c43c0e2891eefffcc03ebd32800d46ea44cf942
2022-07-06 19:49:18 +00:00
Tagir Valeev
11595f3956 Fix most of JavaDoc <-> code mismatch warnings
GitOrigin-RevId: 9a87a8b90993b56cd045722734c5c5f466601ae3
2022-06-20 12:02:27 +00:00
Alexey Kudravtsev
dac69e3f41 restore compatibility with plugins (IDEA-293938 Revert API visibility changes in com.intellij.util.xml.ui.UndoHelper)
GitOrigin-RevId: 8d342f14199d4cab1cf35ffd420364c3ed31de0d
2022-05-27 12:48:08 +00:00
Daniil Ovchinnikov
93857a7a74 remove dummy overrides of FileEditor#getBackgroundHighlighter
GitOrigin-RevId: fecf8a852a9303e109fd0ec4521c5c081006815c
2022-05-09 11:26:58 +00:00
Tagir Valeev
d4d1bb7d4e Fix raw type, etc. warnings
GitOrigin-RevId: 5a206f208077d226cbd79367648a3723edb9d9a3
2022-04-29 12:50:11 +00:00
Nikolay Chashnikov
3de1d05eec [API] mark for removal API which was deprecated in 2021.2 or earlier and has few usages only (IDEA-281036)
GitOrigin-RevId: 6f1cdecf02dae3ab19351a4fa4e895f98265ea0a
2022-02-17 22:44:08 +00:00
Alexey Kudravtsev
5f39455063 notnull and add notnull assertion for diagnostics of EA-254505 - IAE: UndoManagerImpl.$$$reportNull$$$0
GitOrigin-RevId: f20ca3e0c40b88fac63b1a6a54d571dff2cd8b2d
2022-02-14 18:59:10 +00:00
Nikolay Chashnikov
abc373560d [API] replace ApiStatus.ScheduledForRemoval annotation by 'forRemoval' attribute (IDEA-288466)
Since we don't want to specify planned removal date anymore, there is no need to use a separate annotation.

GitOrigin-RevId: a047c55475e0f4752a2842577e094fb041c6c05b
2022-02-11 15:12:14 +00:00