Commit Graph

631 Commits

Author SHA1 Message Date
Yann Cébron
abb4be365b [devkit] inspection "Listener implementation implements 'Disposable'" enabled by default (IDEA-323204)
GitOrigin-RevId: bd0a2367bcf47df10e4be8df6ad09055c336b5a4
2023-10-16 16:57:02 +00:00
Andrey Cherkasov
9e9ed6eb11 [devkit] The "Mismatch between light service level and its constructor" inspection: false negative
IDEA-334607

GitOrigin-RevId: b3fcda025cba7de82939b985c0447f2e4f80f862
2023-10-11 13:19:11 +00:00
Karol Lewandowski
dbb74a9c98 IDEA-334137: Delete UseCoupleInspection
GitOrigin-RevId: d32b83ebf9cef84ea724d239ca2d783fa327d21b
2023-10-11 09:51:59 +00:00
Andrey Cherkasov
2e21416fee [kotlin uast] Make the findDefaultValueForAnnotationAttribute method work for usages of Java annotations from Kotlin
^KTIJ-27300

GitOrigin-RevId: b363764c07ee11f634b70e150440d80b74022689
2023-10-06 07:18:09 +00:00
Andrey Cherkasov
c7e0b8adeb [devkit] The "Simplifiable service retrieving" inspection: fix false positive
IDEA-333347

GitOrigin-RevId: 585bd8e37e60c2da24f553a250dd2ba87374ef6a
2023-10-03 16:15:46 +00:00
Andrew Kozlov
d6e577c808 [devKit] IDEA-326862 GoodCodeRedVisitor moved to intellij.dev.codeInsight
all the implementations moved accordingly

GitOrigin-RevId: d8f87fc59df6ba322f1bfed864bd756dd226b530
2023-10-03 13:25:09 +00:00
Andrey Cherkasov
073114cdb2 [devkit] Split the "Incorrect or simplifiable retrieving service" inspection into two
IDEA-327590

GitOrigin-RevId: 721b34c773e16b93cc593080ba2dbc130606ed40
2023-10-03 04:01:17 +00:00
Andrey Cherkasov
6e10f5d13f [devkit] Remove "Eager service initialization during classloading" from SSR as it now a part of DevKit inspections
IDEA-330732
IDEA-326964

GitOrigin-RevId: 3b3b6ed72f36d62598f25a1d2f50904ade453cf2
2023-09-28 12:37:57 +00:00
Karol Lewandowski
9c75884cdf Clarify disabled/WIP inspection lists
GitOrigin-RevId: 1c414261219db85820c6648946b060129df7678b
2023-09-27 20:13:48 +00:00
Karol Lewandowski
a7f206e6fa IDEA-311444: Add UsePlatformProcessAwaitExit to the WIP inspection list
GitOrigin-RevId: fda555bcebe5379c977a24cfd749b8a9f2ebc295
2023-09-27 20:13:45 +00:00
Andrey Cherkasov
9264913ca1 [devkit] Fix the ServiceUtil.kt methods according to the fact that the default service level is application-level
IDEA-330430

GitOrigin-RevId: 5ba4b258d2c18c9c014397c1dd1280375acc9020
2023-09-27 19:27:13 +00:00
alexey.afanasiev
29a2e43d66 QD-6980 Update testKnownDisabledByDefaultInspections
GitOrigin-RevId: d39533f4063bba6fc8136ae14b96ec19023e0604
2023-09-26 23:55:10 +00:00
alexey.afanasiev
1b1e3f6df0 IJ-CR-114480 QD-6980 Addressing review. Rewrite checking if id is known.
GitOrigin-RevId: 6485588f554c30a5fe692a1a2e489bf5d67ddba7
2023-09-26 23:54:54 +00:00
alexey.afanasiev
a6fdafbbd3 IJ-CR-114480 QD-6980 Addressing review
GitOrigin-RevId: a36f346e8973d2a2cd3b0d9bac986f2081d4d18f
2023-09-26 23:54:50 +00:00
alexey.afanasiev
bb51d711a8 QD-6980 Move UnknownIdInMetaInformationInspection to separate package
GitOrigin-RevId: aadb2f0d67f6ff5e907b961021962ae658653912
2023-09-26 23:54:44 +00:00
alexey.afanasiev
c4d106f610 QD-6980 Create UnknownIdInMetaInformationInspection for validating ids in metaInformation.json
GitOrigin-RevId: fa79c1138250d4a3d3a05e2d009513fb3b7ba353
2023-09-26 23:54:40 +00:00
Daniil Ovchinnikov
c973850ddc IJPL-255 replace Application.assertIsDispatchThread -> ThreadingAssertions.assertEventDispatchThread
GitOrigin-RevId: da80a0648ffce76e93f35f72afc93334b21fe9a2
2023-09-22 00:08:26 +00:00
Yann Cébron
6a50833d3c IDEA-317306 plugin.xml: code insight for EP com.intellij.codeInsight.declarativeInlayProvider
support group attribute code insight

GitOrigin-RevId: 3968ede2b0eac5844a9e39b8e4df26fb43b209c3
2023-09-21 09:12:58 +00:00
Yann Cébron
893c3c8a1f IDEA-317306 plugin.xml: code insight for EP com.intellij.codeInsight.declarativeInlayProvider
I18n attributes

GitOrigin-RevId: 4f1c426163e51a0abe95cf119b55b49f3d49e875
2023-09-20 10:19:13 +00:00
Vladimir Krivosheev
115cb16387 IJPL-238 remove the unnecessary usage of commons-lang library (part 2)
GitOrigin-RevId: 6f035e1784e93fb677c1d2ea4ab374b202548782
2023-09-15 20:50:00 +00:00
Karol Lewandowski
8b1c16daa5 IDEA-313346: FileEqualsUsageInspection improvements - support Kotlin operator functions (==, !=, <, <=, >, >=)
GitOrigin-RevId: d91c234be971088afcc57a6af8390cdcfbc662b7
2023-09-14 20:53:11 +00:00
Karol Lewandowski
18288a9f6d IDEA-313346: Convert FileEqualsUsageInspection tests to Kotlin
GitOrigin-RevId: 2cc3cd831350aa51ee753ba0466f7d82bc5dde4b
2023-09-14 20:53:09 +00:00
Yuriy Artamonov
bd438106bc [devkit] New projects with IDEA 2023.1
GitOrigin-RevId: 70e65ab4fbb1995ef900b98c3cdcb451fada812d
2023-09-13 21:44:36 +00:00
Karol Lewandowski
7e4d1d6e44 IDEA-313346: FileEqualsUsageInspection improvements - Add tests for Kotlin
GitOrigin-RevId: 1cbb962d87bea94fd69e7b047b329674a7ebbe61
2023-09-06 12:43:37 +00:00
Eugene Zhuravlev
c40a9350bf adjust test project language level to meet JPS runtime minimal SDK version requirements
GitOrigin-RevId: af243f9fb62960e1c512a90adfb75683a49ae420
2023-09-05 13:35:36 +00:00
Karol Lewandowski
ab8201d58c IDEA-323204: Add tests for deep inheritance
GitOrigin-RevId: d26892d35104dbef2c64266050551010b209f27a
2023-08-30 15:29:22 +00:00
Elena Lyulina
9db39a03d2 [devkit] IDEA-323201 simplify test data, improve wording, make class internal
GitOrigin-RevId: efb1f88a92264c43790383ca695874cc7424f3ea
2023-08-25 00:27:40 +00:00
Elena Lyulina
4a112d1970 [devkit] IDEA-323204 implement new inspection
GitOrigin-RevId: 379d6e0776d132ee356ba62db23660ca388ea137
2023-08-24 14:49:51 +00:00
Elena Lyulina
7b2a2bd293 [devkit] IDEA-323201 add inspection implementation, ensure no intersection with Companion object in extensions
GitOrigin-RevId: 38d092a7d9a7a43e5c7a1032a93dd5c8db9d65e6
2023-08-23 11:03:13 +00:00
Elena Lyulina
4701e0fd21 [devkit] IDEA-298703 improve naming, add a check for backing fields in kotlin
GitOrigin-RevId: 5e74319e790c4246b64e6d5f57c51c6930dbf19f
2023-08-22 10:52:55 +00:00
Tagir Valeev
c37d3a2931 Warnings fixed
GitOrigin-RevId: 8a3bfbe6e9a14c6ef958ee978e120fb678001456
2023-08-17 11:16:39 +00:00
Yann Cébron
747ff771ba IDEA-327715 Plugins: Improve handling of "No display name is specified for configurable"
GitOrigin-RevId: bda811d0e3e38fd9bc054bc43804e841fadcef01
2023-08-08 19:11:35 +00:00
Yann Cébron
cbaab2106b IDEA-327236 Devkit: verify EP com.intellij.statusBarWidgetFactory has defined id attribute in plugin.xml
refine message

GitOrigin-RevId: acea3e8ac6292e07589ec219787aeb5cba752495
2023-08-07 09:13:43 +00:00
Yann Cébron
092f935ee6 DevKit: enable "Plugin.xml dynamic plugin verification" inspection by default
GitOrigin-RevId: 1dd0b8d513e58e23812075025472e1bc18fad541
2023-08-03 09:25:44 +00:00
Leonid Shalupov
347a2fe4df devkit: convert tests from groovy to java
GitOrigin-RevId: 4ccc258805caefdb8ffd483f139b53de9bd41a99
2023-08-03 00:44:20 +00:00
Yann Cébron
4db4c2dece IDEA-327236 Devkit: verify EP com.intellij.statusBarWidgetFactory has defined id attribute in plugin.xml
GitOrigin-RevId: 242d9f39f97254e61a64f8222d480ab1595b5f72
2023-08-02 10:39:34 +00:00
Daniil Ovchinnikov
d1eff6c1bd move threading model helper tests to proper packages
GitOrigin-RevId: f746f0e30b41d17226e6c519eb045714c48973b8
2023-07-21 22:29:19 +00:00
Daniil Ovchinnikov
ffe28b670b move threading assertions from ApplicationImpl to a separate class
GitOrigin-RevId: c2b5daa3c4d54ba20f3404dbf59d3ef50f61f255
2023-07-21 22:29:16 +00:00
Yann Cébron
333c676b68 [devkit] check known disabled inspections vs expected
GitOrigin-RevId: e77c1e39d2404385911f835d42f14476d6998eac
2023-07-20 16:24:14 +00:00
Karol Lewandowski
37c6cc9fd0 Cleanup UElementAsPsiInspection tests
GitOrigin-RevId: 65941e11097b6b7085934438dc43abecc890c48f
2023-07-05 17:55:54 +00:00
Karol Lewandowski
fddcfa52f3 IDEA-307665: Fix duplicate UElement used as PsiElement warnings
The checkMethod() is called for top and all nested methods, which results in reporting issues multiple times. Solution skips checking inspection in nested methods.

GitOrigin-RevId: 904152db09fdb23a9354b34833ab95e85054f087
2023-07-05 17:55:52 +00:00
Andrey Cherkasov
cc230391c5 [devkit] Rename the inspection and its error message and fix the description
IJ-CR-102810

GitOrigin-RevId: 49d74d790ee90f75a248413f5ae16b504c9d8afb
2023-06-23 17:07:50 +00:00
Sergey Pak
09cbd061e0 fix test (increase number of available completion variants)
GitOrigin-RevId: 20814ed7f370b054a9ed3c5018f5736fd2a08559
2023-06-21 19:49:27 +00:00
Andrey Cherkasov
719b7cdae1 [devkit] RetrievingServiceInspection: refactoring
IJ-CR-102194

GitOrigin-RevId: e993138435dff02876d6611248f52cce90823eb1
2023-06-18 18:33:38 +00:00
Andrey Cherkasov
d9cba03c9d [devkit] RetrievingServiceInspection: report retrieving unregistered service
IJ-CR-102194

GitOrigin-RevId: 965ce37f0981058ade7cb425974d8ddfa8e6065e
2023-06-18 18:33:34 +00:00
Andrey Cherkasov
f96d25fe8d [devkit] Do not report service classes that contain a check on the unit test or UI-less mode
IJ-CR-105402

GitOrigin-RevId: cc3e83f7e6e6f93f663c43aea66a3680e8c264b4
2023-06-18 18:33:31 +00:00
Andrey Cherkasov
1d45043879 [devkit] "A service can be converted to a light one" inspections: fix the error messages
GitOrigin-RevId: 3f6b50f4a1f9481da3ada69a82932f237c154bc2
2023-06-17 23:00:36 +00:00
Yann Cébron
77435029e9 IDEA-322654 Devkit: Inspection description checker inspection - support IntentionAction with skipBeforeAfter=true
GitOrigin-RevId: 36ca4e229fa8a789969f300aa77921e2c6f1341a
2023-06-15 18:42:35 +00:00
Karol Lewandowski
543599b81c IDEA-284442: Fix issues:
- catch clauses from outer try expressions where reported, even if nested catch block handled PCE/inheritor
- all generic exception catch clauses where reported when PCE thrown implicitly

GitOrigin-RevId: f036ac5b37297a61e2999eeca1e3bb89eb026839
2023-06-01 23:01:37 +00:00
Karol Lewandowski
c8c1a876a2 IDEA-284442: Change level to ERROR
GitOrigin-RevId: 7a8593bf83e513004ebe5e74498ba715f63aa719
2023-06-01 23:01:31 +00:00