Commit Graph
8510 Commits
Author SHA1 Message Date
Tagir Valeev dafe2e8918 StandardInstructionVisitor: kill instruction state on ArrayIndexOutOfBounds 2019-02-20 16:36:39 +07:00
Tagir Valeev 5c0748b0bc StreamApiMigrationInspection: BufferedReaderLines: support parentheses around readLine in while scenario 2019-02-18 12:37:12 +07:00
Pavel Dolgov cec0e049ea Java: Improve the inspection "Multiple occurrences of the same expression" (IDEA-207247) 2019-02-15 17:23:08 +03:00
Tagir Valeev b8c6d1f4fe DfaMemoryStateImpl: Avoid SOE when canonicalizing rewritten temp variable
Fixes EA-136794 - NA: DfaMemoryStateImpl.replaceQualifier
2019-02-15 17:02:32 +07:00
Tagir Valeev a8259d29d2 OptionalRefactoringUtil: do not suggest opt.map().stream() -> opt.stream().flatMap() if operation may have side-effect
Side-effect is allowed for Optional.map, but not allowed for Stream.flatMap, and actually may cause a semantics change
Fixes IDEA-207178 Incorrect simplification of optional suggested by inspection
2019-02-15 12:27:18 +07:00
Pavel Dolgov 7ccc4710eb Java: Improve the inspection "Multiple occurrences of the same expression" (IDEA-207247) 2019-02-14 17:00:49 +03:00
Rustam Vishnyakov d76d6e1844 Export visual guides to Json (IDEA-206789) 2019-02-14 14:28:17 +03:00
Pavel Dolgov 86bc525ead Java: Improve the inspection "Multiple occurrences of the same expression" (IDEA-207247) 2019-02-14 11:20:06 +03:00
Dmitry Batkovich 020aed2188 Merge remote-tracking branch 'origin/master' 2019-02-13 16:36:49 +03:00
Dmitry Batkovich 87937bc45c unused return value inspection should ignore methods used in unknonwn files IDEA-207191 2019-02-13 16:36:24 +03:00
Pavel Dolgov 0d8a4fd924 Java: Slightly increased the limit for size of subexpression that can be an extracted method's parameter (IDEA-181195) 2019-02-12 14:26:37 +03:00
Anna.Kozlova bb01072eb6 fix code to compile under java 11 as well 2019-02-11 18:43:21 +01:00
Rustam Vishnyakov 02455a3118 Code style property names fixes (e.g. IDEA-206769) 2019-02-11 20:11:00 +03:00
Roman.Ivanov ba93dfaee9 EnhancedSwitchBackwardMigration: do not generate break if cannot may complete normally: IDEA-205607 2019-02-11 10:26:46 +07:00
Roman.Ivanov edb5e0f4ba EnhancedSwitchBackwardMigration: generate multiple case labels: IDEA-205529 2019-02-11 10:26:46 +07:00
Tagir Valeev 7a897157f1 MergeFilterChainAction: support parentheses 2019-02-08 15:24:53 +07:00
Tagir Valeev e6ca195feb DuplicatesFinder: deparenthesize qualifiers 2019-02-08 15:20:08 +07:00
Anna.Kozlova b6f6bae31a invert if: ensure outer if becomes braces when nested if has no else brunch (IDEA-206882) 2019-02-07 16:49:03 +01:00
Pavel Dolgov 729f8b1328 Java: Support more variants with switch expressions in '.switch' template (IDEA-204010) 2019-02-07 18:20:56 +03:00
Anna.Kozlova a98a18ce8a calc expected type on the left of assignment based on standalone expression type from the right side (IDEA-199273) 2019-02-07 15:59:00 +01:00
nik 27b10c30d3 javaee: rewrite JSP validation to run inside external build process and download required JARs (IDEA-206443)
This fixes several issues when validation wasn't performed correctly because required files weren't copied to the artifact; also the validator don't process PSI inside the IDE process to analyze dependencies (it processes class-files inside the build process), this will help to avoid performance issues.

The validator's JARs are removed from Git repository and don't bundled with the product anymore; they are attached as Maven libraries with 'provided' scope to the sources, and downloaded automatically when validation is invoked for the first time. This also helps to avoid issues with updating libraries on which they depend (e.g. Ant).

Tests are rewritten to use a simple mock implementation of Jasper validator; this way they run faster, don't depend on external libraries and don't require specific JDK version (previously it was needed to use Java 6 to run them).
2019-02-07 17:45:05 +03:00
Rustam Vishnyakov d3973a1add Rename "replace_int_sum..." to "replace_sum" (IDEA-CR-42964) 2019-02-07 13:45:46 +03:00
Anna.Kozlova 596fdda3e7 java resolve: prefer package for single-type-import only with default package exception (IDEA-206295) 2019-02-07 11:44:54 +01:00
Dmitry Batkovich 64d845810b Merge remote-tracking branch 'origin/master' 2019-02-07 13:35:38 +03:00
Andrey Turbanov aff927946a IDEA-171758 Support Guava collections in 'Suspicious collections method calls' inspection 2019-02-07 13:35:16 +03:00
Artemiy Sartakov 043c2d563e Field can be local: added support for nested and local classes (IDEA-206647) 2019-02-07 17:27:00 +07:00
Tagir Valeev 5de8f58f34 Replace with trivial lambda default fixed after 2cfd1ece23 2019-02-07 10:58:44 +07:00
Rustam Vishnyakov c40d30a6eb Fixed IDEA-206778 Export codestyle settings to JSON: export fails when non-default values are provided
Namely "Next line if wrapped"
2019-02-06 21:26:04 +03:00
Rustam Vishnyakov df649251d2 A better external name for REPLACE_SUM code style option 2019-02-06 18:54:58 +03:00
Pavel Dolgov d9412eba69 Java: Fixed typos in test data file names (IDEA-203895) 2019-02-06 18:40:08 +03:00
Dmitry Batkovich 9101bcc93a Merge remote-tracking branch 'origin/master' 2019-02-06 18:18:17 +03:00
Dmitry Batkovich 67c23e9a2f fix testdata quotes 2019-02-06 18:18:03 +03:00
Bas Leijdekkers 4e7a841173 qualify field access in initializer when shadowed by new declaration (IDEA-173780) 2019-02-06 16:09:30 +01:00
Pavel Dolgov ddfaf087ee Java: Support switch expressions in '.switch' template (IDEA-204010) 2019-02-06 15:43:29 +03:00
Rustam Vishnyakov 76ebb5a63b Extract generic code style property accessor not limited with fields
with example implementation for Java repeat_annotations property
2019-02-06 14:11:15 +03:00
Tagir Valeev 1930c6736b CreateSwitchIntention: disable in assignment (while valid, rarely makes sense -- see IDEA-206725) 2019-02-06 11:52:59 +07:00
Anna.Kozlova dac182b6d9 var -> explicit type: fix for foreach parameter (IDEA-206640) 2019-02-05 16:36:29 +01:00
Anna.Kozlova c3b7a9b1c6 optionally introduce local as var type since java 10 (IDEA-179176) 2019-02-05 15:23:14 +01:00
Dmitry Batkovich e5b214d2e8 Merge remote-tracking branch 'origin/master' 2019-02-05 13:50:42 +03:00
Tagir Valeev e825df9b5c DFA: report imprecise methods in tests 2019-02-05 16:11:04 +07:00
Artemiy Sartakov 1b87c1a508 ConvertToLocalInspection: changed quick-fix to explicitly show type of code block where field is used (IDEA-CR-42222) 2019-02-05 13:26:10 +07:00
Anna.Kozlova 1ace9ab2c3 lambda -> method ref: reuse comment tracker (IDEA-189934) 2019-02-04 15:21:43 +01:00
Pavel Dolgov e00ecc9156 Java: Shortened text messages for highlighting of duplicate values and branches in enhanced 'switch' (IDEA-202629) 2019-02-04 17:05:48 +03:00
Dmitry Batkovich 9c0e8e9d01 unused declaration: report enum consts as used if enum class object is used (IDEA-206125) 2019-02-04 15:39:27 +03:00
Anna.Kozlova 4a114d92f6 introduce variable from yet standalone switch expression (IDEA-206523) 2019-02-04 10:59:17 +01:00
Pavel Dolgov cf34272833 Java: More tests for intention to split switch branch with multiple values into separate branches (IDEA-203895) 2019-02-04 12:33:41 +03:00
Tagir Valeev 15e0df11f9 IDEA-206497 Replace with stream: support intermediate map operations in counting loops 2019-02-04 14:20:39 +07:00
peter 0112b8aaa8 IDEA-206386 Stream.toUnmodifiableList autocompletion (and mockJDK-11 to test it) 2019-02-01 11:42:45 +01:00
Pavel Dolgov 4c260c88bc Java: Improvements in intention to split switch branch with multiple values into separate branches (IDEA-203895) 2019-02-01 13:11:28 +03:00
Tagir Valeev 35990562bf IDEA-195293 Strange behavior when join lines with "builder.append('...')" 2019-02-01 15:45:26 +07:00