Commit Graph

1006 Commits

Author SHA1 Message Date
Chris Lemaire
5c813fffb1 [collab] Remove and replace classAsCoroutineName
It's basically unused and deprecated since CoroutineName is no longer used.
We practically always make a child scope with the class name.
Better to just use the class name in this case.

(cherry picked from commit 4827600b509f0ca804f5be1d05b35b11f8df470f)


(cherry picked from commit eb889a9e6dd0733a86664125feba158234b5267a)

IJ-CR-148445

GitOrigin-RevId: 5cf31226299b6ddad30f919b4ddeb36c8ae947aa
2024-11-06 18:33:20 +00:00
Nikita Katkov
e020e4a58b [yaml] IJ-CR-147338 Moved gitlab-yaml test to the corresponding module
(cherry picked from commit 01522449f631d7720055dfb080ed849d769559fe)

GitOrigin-RevId: 4daf61723842890013ecf4d507531611899acffe
2024-10-30 15:19:48 +00:00
Nikita Katkov
ede9289788 [gitlab] IJPL-64341 IJ-CR-147338 Add non-translatable configurable id to the plugin descriptor
With this fix, we'll be able to add the gitlab classes to the ultimate tests classpath which will help to detect bugs caused by interfering extensions from all the plugins

(cherry picked from commit 485f87a181d8f93dc569c443fff2e7cfd70f53a5)

GitOrigin-RevId: 239dc9581d0263bca6fab4920ce5f5c1039a08cb
2024-10-30 15:19:48 +00:00
Nikita Katkov
3599326f12 [yaml] IJPL-64341 IJ-CR-147338 Specify content module in plugin layout snapshot
(cherry picked from commit e53c4ee15a9c40a6f4a35e8a0d6f40818cfeaa7b)

GitOrigin-RevId: 7dc7aebc9e5a7859f21ce3bf2d24a1f6cc5c0c4f
2024-10-30 15:19:48 +00:00
Nikita Katkov
a2c722672d [yaml] IJPL-64341 IJ-CR-147338 Added test for custom gitlab yaml tags & added gitlab to the ultimate.tests.main classpath
(cherry picked from commit 4fc2a07e99f3ed9b728e56a586ddaa7e0072c85b)

GitOrigin-RevId: 817bf437399be37ef484ad88b64001a88631edf4
2024-10-30 15:19:48 +00:00
Nikita Katkov
a4512869b5 [yaml] IJPL-64341 IJ-CR-147338 Implement gitlab YAML tags support on the gitlab plugin side
A dedicated optional content module was created because gitlab plugin does not have a YAML dependency

(cherry picked from commit d4cd67d49c6ac38319b17118f0c8bd44ebaeff1d)

GitOrigin-RevId: 604125375d2c3aae22ccbda74251d5468c7ad863
2024-10-30 15:19:48 +00:00
Ilia.Shulgin
83fc84993c [git] IJPL-84816 Delete git.clone.shallow registry key
(cherry picked from commit 256392f36282aca50551dc92614b554c8f52f98b)

IJ-CR-147381

GitOrigin-RevId: 6572d5656d8682e426d58c70b7f998085c3a9c30
2024-10-22 14:12:15 +00:00
Ilia.Shulgin
00760b25cf [gh/gl] IJPL-84816 Support shallow clone in GitLab and GitHub clone dialogs
GitOrigin-RevId: 15d1b26659829721be8340651f2c45895deac6d1
2024-10-14 22:26:50 +00:00
Ivan Semenov
e19aa8d2d7 [gitlab] remove Disposable interface from account manager
GitOrigin-RevId: 8c40f0e066365c3045ecd5f2764362800c3fd902
2024-10-04 13:00:17 +00:00
Chris Lemaire
a28c8ee586 [gitlab/github] Resolve warnings about early updating toolbar
Toolbar was deterministically updated before adding it to the component tree.
`launch` is more likely to delay that update, though I guess it may not be 100%.

GitOrigin-RevId: 912684ffff5ade602b3b0448bdbd25a304426b23
2024-09-30 20:00:50 +00:00
Dmitrii Petukhov
d3aa968b44 [collab/space] IDEA-353795 Starting screen in the Space tool window
Merge-request: IJ-MR-142996
Merged-by: Dmitrii Petukhov <dmitrii.petukhov@jetbrains.com>

GitOrigin-RevId: 06bbd3499f083e54475b8c6fa5f1e4a7d65f32d2
2024-09-19 11:11:36 +00:00
Dmitrii Petukhov
5ca3b3705e [collab/space] IDEA-356986 Set default project for project filter
Merge-request: IJ-MR-143762
Merged-by: Dmitrii Petukhov <dmitrii.petukhov@jetbrains.com>

GitOrigin-RevId: a3bf4c249f31eced4688d0a1566d0bf25bc591f7
2024-09-17 20:18:11 +00:00
Chris Lemaire
aa2c2605c5 [gitlab] Add a button to MR creation to generate a title
GitOrigin-RevId: 53a9cb6bc2e0827d80d434d47482a2584d4ccb4c
2024-09-11 09:19:46 +00:00
Chris Lemaire
e768016c4e [gitlab] Automatically fill in title if there's only 1 commit
GitOrigin-RevId: d87ea6cfe5c0fdf04c0ceb8e6ce05e87acd38f8b
2024-09-11 09:19:46 +00:00
Aleksey Pivovarov
b83a6715ba diff: use DiffEditorTabFilesManager over VcsEditorTabFilesManager
GitOrigin-RevId: af2bc69b324aacf8f2ca7393275f1cf8d58d74a4
2024-09-09 16:29:11 +00:00
Roman Shevchenko
a5666abead [project] pruning FileChooserDescriptor overrides (IJPL-150176 prerequisite)
`BrowseFolderRunnable` and `*WithBrowseButton` family: getting rid of separate "title" and "description" parameters in favor of the chooser descriptor object, to avoid cloning the latter down the road.

GitOrigin-RevId: 33ec5968a1db953c60848974135055c288accf85
2024-09-06 11:41:43 +00:00
Mikhail Filippov
f13d92e82f IJPL-150165 switch to invoke dynamic lambdas in Kotlin
GitOrigin-RevId: 63ba45a21874cc723917982996fce1a510b2a182
2024-09-05 11:19:31 +00:00
Chris Lemaire
308229f8a1 [gitlab] Fix token generation link
#IJPL-161647 Fixed

The old link was previously redirected until a recent update to GitLab.
This happened sometime between 17.0 and 17.4.

The fix cannot consider versions sadly, because GitLab does not
make a version visible without authentication.

As of this moment, we will break the generate functionality for
25% of users and fix it for 75%.

GitOrigin-RevId: d55f0270098a7c7a0cd8a4d152bd007b0be3eaba
2024-09-04 19:25:56 +00:00
Mikhail Filippov
bf43f2fc01 IJPL-150165 bump Kotlin language and API version
GitOrigin-RevId: a59dc8ca214a5047773fccf1cf28a1e1b07acf68
2024-08-30 22:15:55 +00:00
Gregory.Shrago
038c336ddc migrate ActionPlaces.isPopupPlace usages
GitOrigin-RevId: 6caf1344423c8142a549d507c19e4ea40a721284
2024-08-28 05:13:52 +00:00
Ivan Semenov
81f170fcd3 [collab/gitlab] implement and migrate gitlab code review to a new diff API
Selection change and scroll is now handled purely on the VM layer which allows for better control over the state
New API is more flexible and does not depend on RefComparisonChange
Changes sorting now happens on background

GitOrigin-RevId: d6de23870105fe75087ea2967b8ef9597e65fefd
2024-08-26 20:27:21 +00:00
Ilia.Shulgin
a805a51ce8 [diff] IJPL-101084 Show path relative to project root in diff window
All diff requests created via `ChangeDiffRequestProducer#createRequest` will contain `DiffUserDataKeysEx.VCS_DIFF_RIGHT_CONTENT_TITLE` allowing to show short revision and file path relative to a project root

The same applies to diffs created via `MergedChangeDiffRequestProvider`

GitOrigin-RevId: 60ecb120e8751a6a211d2917838d6403a6003dfd
2024-08-17 09:50:36 +00:00
Ilia Bogdanovich
f3301ddf70 [mockito.kotlin → mockk] Migrated intellij.vcs.gitlab tests from mockito.kotlin to mockk
GitOrigin-RevId: 8203f9e39211d1c6941885a73eb9f37eab0f68ca
2024-08-16 12:03:55 +00:00
Chris Lemaire
420e617d4a [gitlab] Prevent perpetual loading of the MR list
#IJPL-148406 Fixed

GitOrigin-RevId: 9eac39c52b1043a41d45b54d7602ed74d2e3e99a
2024-08-15 13:59:01 +00:00
Chris Lemaire
7db739e221 [gitlab] Add a 'listener' to close the current connection if the account is removed
#IJPL-148242 Fixed

GitOrigin-RevId: a5a9a1a1ff668e73dcba1f65c61d549ec587a745
2024-08-15 13:59:01 +00:00
Chris Lemaire
0d4a5f2c92 [gitlab] Fix the Deleted event being ignored for draft notes
#IJPL-82744 Fixed

GitOrigin-RevId: 3009eeca3f73c0d4c60f1fe1e1b8e7e0e094b16a
2024-08-15 13:59:01 +00:00
Chris Lemaire
02c68773e5 [gitlab] Pass the default value for shouldRemoveSourceBranch to merge
#IJPL-81278 Fixed

GitOrigin-RevId: 92f410ee18e050fe6b06fdf824385a0c01af8f66
2024-08-15 13:59:01 +00:00
Chris Lemaire
6973541acc [gitlab] Fix the merge button (IJPL-158743)
#IJPL-158743 Fixed

The first commit in a reversed list turned out to still be the first commit.
Sadly, the latest commit was needed, not the first.
Using the diffRefs HEAD SHA seems more appropriate than guessing
the ordering of the list in this case.

GitOrigin-RevId: a39e5c5da7065c01ce4c0721abf5cd38b67b3e6f
2024-07-30 14:12:16 +00:00
Vladimir Krivosheev
398ebce1d5 split content report
GitOrigin-RevId: ef449bdf4c5480a6ee3ce43b4af118c2c6e31219
2024-07-25 19:20:06 +00:00
Alexander Lobas
932f2d438e Swap icon path parameters: move expUI path to the first place
GitOrigin-RevId: 74cf09fb454c89b676be259cdd7437a81ac4c067
2024-07-25 15:12:07 +00:00
Ivan Semenov
dd5d76a359 [github] signal details reload when corresponding remote branches hashes are changed
#IJPL-157530 Fixed

GitOrigin-RevId: 81eea57d5fa3e6bdb1388362f3771187d4715e87
2024-07-08 12:40:55 +00:00
Ivan Semenov
4594cb907a [collab/gitlab/github/space] make a global action for adding a review comment in the editor
#IJPL-82567 Fixed

GitOrigin-RevId: 2e37c01ec7295e6a680514df58cf9f67793eb344
2024-07-06 00:18:25 +00:00
Ivan Semenov
d23df10ad7 [gitlab] rework the project data model class to contain suspending loading methods instead of flows
GitOrigin-RevId: 9ddd15f86bfbcc277fbb256436689dca704d040a
2024-07-06 00:18:25 +00:00
Ivan Semenov
97e97cb015 [gitlab] fix scope naming and nesting
GitOrigin-RevId: 4abed3663d2e621dd99133a8c716a510a11e4dfe
2024-07-06 00:18:25 +00:00
Ivan Semenov
f284232c19 [gitlab] only search for open MRs when checking existing before creating a new MR
#IJPL-81309 Fixed

GitOrigin-RevId: 7edd5b9c440ad069917a00a68d813baa65a7058c
2024-07-06 00:18:25 +00:00
Chris Lemaire
cb6292475d [github/gitlab] Add a check and a status for when conflicts are already resolved locally (IJPL-157615)
#IJPL-157615 Fixed

GitOrigin-RevId: 823a3ab7911b5c1a80a77e419d43d17a9cb4cbe2
2024-07-04 15:54:03 +00:00
Chris Lemaire
b92bb73d91 [collab/gh/gl] Camelcase bundle property names
GitOrigin-RevId: a635014eef2a3d8a6df2101d05dbe1b68df5a478
2024-07-04 15:54:03 +00:00
Ivan Semenov
79ed1f2693 [gitlab] rework push notification customizer checks
Don't suggest PR creating for default branch

GitOrigin-RevId: 2e37c43e9fee6bb56b17d6db076f6fda8baa9bd0
2024-07-03 21:44:39 +00:00
Ivan Semenov
38b567defc [git/github/gitlab] rework push notification repo/account selectors
Simplify selector code
Check the current connection first
Show actions if there is no saved selection (#IJPL-73072 Fixed)

GitOrigin-RevId: 7a5fa5c2a5ee23be135ebc7b1ed98be6e0f41c1d
2024-07-03 21:44:39 +00:00
Chris Lemaire
9cbf03fbe4 [gitlab] Split genericConfig into a mapper building function and configurer
GitOrigin-RevId: 630f0cb185a1362f370cc81e0fa1d8152abafb20
2024-07-02 22:09:46 +00:00
Chris Lemaire
4077ffa0c9 [gitlab] Disable auto-closing JSON parsers to avoid premature closure (IJPL-157434)
#IJPL-157434 Fixed

This should prevent READING_LENGTH exceptions caused by
JsonParsers closing the reader before reading all tokens.

Also, don't check for readiness. `ready` depends on `java.io.InputStream.available`.
But, `available` does not block to check a correct count of available bytes, so
it might return 0 even if more bytes are available still.
Probably best to read to completion regardless of readiness to avoid these errors...

Interesting note: if we use `.factory` instead of the method on `mapper`
the configurations from `genericConfig` will not be applied to the parser created.

GitOrigin-RevId: 99ff0728d1c33f59e04cf33c5c34e452b8c41d97
2024-07-02 22:09:46 +00:00
Chris Lemaire
b8b1a9f412 [gitlab] Fix slow and wrong discussion list loading (IJPL-157270)
#IJPL-157270 Fixed

The list was loaded from back-to-front, which
the list loader did not account for.

GitOrigin-RevId: e51e1f0384c31c522f2420ca6904e0cb9f5f5816
2024-07-02 22:09:46 +00:00
Chris Lemaire
21a47d76db [gitlab] Rename GraphQL loader: it does nothing with ETags
GitOrigin-RevId: 0595b1c415dd5198df510a7b049c1b88b3b12846
2024-07-02 22:09:46 +00:00
Chris Lemaire
a7c0d66b09 [gitlab] Fix re-emittance of reply VMs because of re-emittance of canAddNotes
Every time a draft note was added, all reply VMs would be re-published...
This would cause (in my case) 25-ish editors to - one after another - close and re-open.
Not great for performance in a large MR...

GitOrigin-RevId: c0d02182f1c0a1f0bcaffe8b1f829397c0bdc889
2024-07-02 22:09:46 +00:00
Chris Lemaire
a53518affe [collab] Always push out new pages states from ListLoaders (IJPL-157270)
#IJPL-157270 Fixed

If these are not pushed out, a sequence like this will have incorrect results:
1. Refresh the list, 0 pages loaded, list = []
2. Update manually by adding an entry, list = [some_entry]
3. Perform some action on-server that removes the entity, but does not notify IDE.
4. Refresh the list, 0 pages loaded, list = [some_entry]

In the final step, the pagesFlow would not push out the freshly loaded list.
From the perspective of pages that's fine, but the final list is inconsistent and
should always be overridden by refreshes.

GitOrigin-RevId: 631041c137bde50e2fd8ede0d3f1dc2d3a83b564
2024-07-02 22:09:46 +00:00
Ivan Semenov
0d8492341d [gitlab] fix changes selection loop
The crux of the issue was that the data was incorrect.
UI events should be handled synchronously until the "single source of truth" is set and then that state can be propagated asynchronously.
That was not the case for tree/diff selection handlers. Selection updates were handled asynchronously which sometimes caused an updated loop while trying to synchronize two states.

#IJPL-77514 Fixed

GitOrigin-RevId: fa0e860bd893f10e09e11af49547b3844c31fd35
2024-07-01 11:25:22 +00:00
Ivan Semenov
3949e487a6 [gitlab] match account with git url by host in interactive auth data provider
GitOrigin-RevId: 08b117d2dec90370bac15ee9d854bd81788e764e
2024-06-27 11:45:52 +00:00
Ivan Semenov
3de8125754 [gitlab] fix the order of git auth providers
GitOrigin-RevId: 6b5f856d304b017fea15c436972e8d6f0a954a16
2024-06-27 11:45:52 +00:00
Chris Lemaire
96b96a6992 [gitlab] Remove contraction from bundle
Follow-up: 33099b68d3c295b97db1228d774a1a8ad18ec4c2

GitOrigin-RevId: 43d77bd2157be4c5e584896110448339bfdd3607
2024-06-25 17:33:46 +00:00
Chris Lemaire
ee64c72314 [gitlab] Add an action to resolve conflicts in an MR
GitOrigin-RevId: 33099b68d3c295b97db1228d774a1a8ad18ec4c2
2024-06-25 10:57:15 +00:00