Commit Graph

1226 Commits

Author SHA1 Message Date
Tagir Valeev c483ae9cd0 ControlFlowUtils#getInitializerUsageStatus fixed for do-while loops where var is declared just before the loop 2018-02-21 12:24:01 +07:00
Tagir Valeev 3b96a595b9 DeleteSideEffectsAwareFix: handle comments 2018-02-20 17:06:53 +07:00
Tagir Valeev 413aca292b WrapWithAdapterMethodCallFix: correctly handle disjunction type
Fixes EA-116570 Cannot create expression for type class com.intellij.psi.PsiDisjunctionType
2018-02-18 07:54:47 +07:00
Anna.Kozlova 8703c07861 disable add on demand static import for method reference qualifiers
IDEA-186826
2018-02-16 16:01:55 +01:00
Daniil Ovchinnikov 872ddb5d0e [jvm-lang] rename create getter/setter actions
- _Create Getter_ -> _Create read-only property 'foo' in 'Bar'_
- _Create Setter_ -> _Create write-only property 'foo' in 'Bar'_

Action names are now consistent with _Create property 'foo' in 'Bar'_.
2018-02-15 16:00:36 +03:00
Daniil Ovchinnikov 544ee7980f [jvm-lang] java: port _Create getter/setter from usage_ actions
- extract PropertyRenderer for reusing;
- make them work with type parameter guesser.
2018-02-13 01:15:09 +03:00
Daniil Ovchinnikov 3151924a52 [jvm-lang] java: don't create private abstract methods (IDEA-186499) 2018-02-12 19:25:20 +03:00
Daniil Ovchinnikov fbe959bf47 [jvm-lang] java: port _Create property from usage_ action
- make it create template for both getter and setter;
- make it work with type parameter guesser;
- add tests!
2018-02-12 17:45:12 +03:00
Tagir Valeev 7e915181dc RedundantCollectionOperationInspection: fix redundant asList type 2018-02-07 11:10:20 +07:00
Tagir Valeev 8d8dce807a RedundantCollectionOperationInspection: simplify Collections.sort(asList(arr)) to Arrays.sort(arr)
Fixes IDEA-93038 Inspection: Replace Collections.sort() with Arrays.sort()
2018-02-06 13:05:29 +07:00
Tagir Valeev d5f9284f2e ExpressionUtils#isSimpleExpression: disable for non-final fields 2018-02-05 15:53:39 +07:00
Tagir Valeev 818b20eff3 RedundantComparatorComparing: cosmetic changes, internationalization
Review ID: IDEA-CR-28770
2018-02-05 12:33:55 +07:00
Tagir Valeev 4be91bbc65 Fixed imports in testdata. 2018-02-04 17:21:33 +07:00
Tagir Valeev 5bfb15ec8c CommentTracker: do not add comments at the beginning of reference qualifier: add it to the parent element instead 2018-02-04 16:34:23 +07:00
Daniil Ovchinnikov 6e0f6897c9 [jvm-lang] group 'Create method' and 'Create field' actions 2018-02-02 17:07:57 +03:00
Tagir Valeev b477b32395 IDEA-186034 Lambda can be method call inspection should not generate code with inference failures 2018-02-02 12:09:53 +07:00
Anna Kozlova 30464d6b08 disable fixes when target types depend on unresolved type params (IDEA-185967) 2018-02-01 13:40:04 +03:00
Tagir Valeev f06e8ca2f0 IDEA-185812 Allow to force explicit toCollection(ArrayList::new) instead of toList() in "Subsequent steps can be fused into Stream API" 2018-02-01 17:16:04 +07:00
Tagir Valeev dde611b8f4 IDEA-185819 Operator ! cannot be applied to void: add a quick-fix 2018-02-01 10:37:29 +07:00
Roman Ivanov 465f4124a2 SortContentAction: support generic types in vararg: IDEA-185852 2018-01-31 16:23:10 +07:00
Roman Ivanov 798fea215a SortContentAction: fix warping in the middle of initializer: IDEA-185786 2018-01-30 13:58:05 +07:00
Roman Ivanov c71ae7e4f1 SortContentAction: consistent count of expr to be available: IDEA-185785 2018-01-30 13:58:05 +07:00
Tagir Valeev 3210510c96 CollectionUtils#isCollectionOrMapSize
Used in ToArrayCallWithZeroLengthArrayArgumentInspection and StreamApiMigrationInspection
2018-01-30 11:01:38 +07:00
Roman Ivanov abd1458307 SortContentAction: fix IOOBE, check if expr is literal: IDEA-185784 2018-01-30 10:39:30 +07:00
Roman Ivanov d5d06483fe RedundantExplicitCloseInspection created: IDEA-176630 2018-01-30 10:39:29 +07:00
Tagir Valeev 2f547ca38f RedundantStringOperationInspection: warn about append(s.substring(x, y))
Replaceable with append(s, x, y)
Fixes IDEA-185652 Improve StringBulder.append(s.substring(1,2)) intention
Also optimization of new expression resolution
2018-01-29 13:34:55 +07:00
Tagir Valeev 97300d73f1 IDEA-185548 Inspection to remove excessive Comparator.comparing call 2018-01-26 12:27:12 +07:00
Tagir Valeev b3a46c4960 AddOnDemandStaticImport: test-case with nested calls and comments
Review ID: IDEA-CR-28752
2018-01-25 16:33:34 +07:00
Roman Ivanov 6b81e567cc MoveConditionToLoopInspection: change name : IDEA-185134 2018-01-25 16:02:05 +07:00
Tagir Valeev 6cc8936598 Compute constant expression as an inspection; minor improvements
Works for unary operation
Do not suggested if replacement is the same as the original code
Replacement is displayed in the quick-fix name
2018-01-25 15:43:48 +07:00
Tagir Valeev eeb1483ed0 AddOnDemandStaticImportAction: handle comments 2018-01-25 12:05:05 +07:00
Tagir Valeev e2d5de3528 ExpressionUtils#isEvaluatedAtCompileTime: fixed for casts to String (operand was not checked) 2018-01-24 14:36:20 +07:00
Tagir Valeev d828baf6e3 LambdaAndExplicitMethodPair: Arrays.setAll -> Arrays.fill pair added
Allows to make IDEA-185394 in two steps
2018-01-24 13:37:55 +07:00
Alexey Kudravtsev 5f67dd2d84 quick fix to convert empty anonymous class to the plain new expression 2018-01-22 15:10:16 +03:00
Roman Ivanov 6dda38da0f SortContentAction: trying to save layout with multiple items on line 2018-01-22 15:57:22 +07:00
Tagir Valeev 1a40a9f877 RedundantCollectionOperation: warn on if(map.containsKey(x)) map.remove(x)
Review ID: IDEA-CR-28150
2018-01-22 13:39:09 +07:00
Tagir Valeev c841cb3b44 IDEA-185167 Allow to convert automatically Optional.orElse(...) to Optional.orElseGet(() -> ...) 2018-01-19 15:07:21 +07:00
Tagir Valeev b3b019e5b7 ExpressionUtils#isSimpleExpression: consider Collections.emptyXyz as simple (they are just static field getters) 2018-01-19 15:07:20 +07:00
Bas Leijdekkers f2e6fca603 use CommentTracker.text() with precedence argument 2018-01-18 15:19:20 +01:00
Dmitry Batkovich cc8d990786 redundant throws fix should remove javadoc tag too (IDEA-185105) 2018-01-18 15:05:24 +03:00
Tagir Valeev 44585d34d9 CommentTracker: support removal of reference qualifier; used in AddSingleMemberStaticImportAction 2018-01-18 12:00:24 +07:00
Anna.Kozlova 8ce7fac354 hide fixes which expose unresolved type parameters; add fixes for boxing
IDEA-150081
2018-01-12 18:53:17 +01:00
Tagir Valeev 30b3d4a558 IDEA-184825 "Redundant String operation" inspection - rename 'Delete element' to 'Delete argument' 2018-01-12 11:44:40 +07:00
Anna.Kozlova d74021cd16 highlight enum with abstract methods until enum initializer is added
IDEA-184704
2018-01-11 19:31:43 +01:00
Anna Kozlova 8758030cf7 don't add make enum abstract fix (IDEA-184788) 2018-01-11 09:36:24 +01:00
Tagir Valeev 83c6c5222e IDEA-184240 Unnecessary array-to-collection wrapping should be detected 2018-01-11 13:51:16 +07:00
Anna.Kozlova ee559693e0 add static import: don't suggest private inner by default (IDEA-158284) 2018-01-09 17:32:57 +01:00
Anna Kozlova bd49d9f065 add static import: check all expected types (IDEA-153378) 2018-01-05 20:05:51 +01:00
peter 41d78cd086 IDEA-182501 Unwrap 'if' generates unreachable code 2018-01-03 21:47:57 +01:00
Anna Kozlova 2dd4d855fb compilation error fix: transform getClass()->.class (IDEA-117106) 2018-01-03 21:10:47 +01:00