Commit Graph

31 Commits

Author SHA1 Message Date
Tagir Valeev
2d3ed0f730 [java-intentions] CreateConstructorParameterFromFieldFix: fill variables before modifying constructors
When chain target constructor is already updated, it affected other constructors from the same chain
Fixes IDEA-345876 Unable to add constructor parameter via quick-fix

GitOrigin-RevId: e13d1d24ad16dbd32281b7f13be6d656871acef2
2024-06-05 15:08:25 +00:00
Bas Leijdekkers
415d6a8b56 Java: respect "Make generated parameters final" setting when creating constructor parameters from field (IDEA-341545)
GitOrigin-RevId: 3f12122ecf79a835e649425f2301b7fbda950afc
2024-01-03 00:24:56 +00:00
Tagir Valeev
eb85741b25 [java-inspections] CreateConstructorParameterFromFieldFix: rewrite to ModCommand, using trackDeclaration()
Also fixes IDEA-329769 'Add constructor parameter' hint and action discrepancy

GitOrigin-RevId: f897347600bfdfd2ebf7a4de0209e5887323f091
2023-09-27 11:27:13 +00:00
Anna Kozlova
0a3d001b76 [java] avoid reformat inside psi operation (IDEA-287332)
GitOrigin-RevId: 387a7fe6e41da1f967b05dfa7da246e70e02b30f
2022-02-11 09:33:24 +00:00
Anna Kozlova
02c569b58d [java] keep existing type annotations when new param is added to the constructor (IDEA-287983)
GitOrigin-RevId: 9a22583cf9333be8855545c87443484bce62a19c
2022-02-04 10:41:45 +00:00
Anna Kozlova
2005c6f14c java: testdata for IDEA-206570
GitOrigin-RevId: a4019ca264e699210cba91d30c47c266949d7563
2021-01-11 12:44:55 +00:00
Tagir Valeev
93479e1f99 [java-intentions] Remove 'Add constructor parameter' fix for record fields (IDEA-248139)
As record instance field declaration is illegal, this action is useless anyway and only adds confusion

GitOrigin-RevId: 4a1862f66c5a175fef675705e6af53ef5bae1f78
2020-08-24 12:08:39 +00:00
Anna.Kozlova
d2bfe3d14b ensure name when retrieving constructors from a class (IDEA-188068) 2018-03-13 10:35:45 +01:00
Anna Kozlova
955a6160cd resolve references by qualified class name when qualifiers can't be resolved
javac ignores problems caused by files located in wrong directories, IDEA reports them: try to search class by FQName when failed to resolve normally (IDEA-178376; IDEA-176179)
2017-09-06 19:42:00 +03:00
Dmitry Batkovich
4ac9d4360e create constructor parameter should consider context (e.g.: type parameter name == some class name from java.lang) 2016-12-07 18:23:14 +03:00
Anna.Kozlova
57bd0325ef copy also nullable annotations when create constructor parameter from field (IDEA-164493) 2016-11-25 12:50:54 +01:00
Anna Kozlova
979dca3880 hide duplicated 'Add constructor parameter' fix (IDEA-137231)
(cherry picked from commit 7c5d5ec6c5141cf7fedf6d55712fb2dffc0d3ace)
2015-03-11 20:29:06 +01:00
Anna Kozlova
2dc893734e force "prefer long names" if multiple fields/parameters of same type are generated (~ IDEA-99564) 2014-12-08 16:19:29 +01:00
Anna Kozlova
71d92723a8 create constructor params from field: do not reject next constructors if current one is chained (IDEA-131746) 2014-10-23 14:46:31 +02:00
Anna Kozlova
d67e9b4f4b IDEA-118279 create constructor params: apply cleanup 2014-05-29 16:17:22 +04:00
Anna Kozlova
7cf4be2861 provide enum constructor package local modifier according to spec examples (IDEA-111785) 2013-08-09 14:21:26 +02:00
anna
24a2d19043 add constructor params: collect new names to prevent conflicts (IDEA-92902) 2012-10-15 18:06:30 +02:00
anna
7e2db60abd create constructor parameter from field: suggest to choose fields to create parameters from (IDEA-76417);
insert parameters in "fields" order (IDEA-81634)
2012-02-21 20:56:16 +01:00
anna
c3ce1ae00f insert same notnull annotation as exist on the existing field (IDEA-79436) 2011-12-29 15:43:49 +01:00
anna
4f513cbd94 EA-31069 - assert: RefactoringUtil.getChainedConstructor 2011-12-28 16:01:34 +01:00
anna
60d4f42363 constructor parameters from fields: sort params in fields order 2011-12-26 18:55:17 +01:00
anna
c2f6991ffd skip fields with initializer when generate constructor parameters; also skip static fields without initializer (IDEA-76621) 2011-11-13 18:58:28 +01:00
anna
f087cd8c25 generate private enum constructor everywhere (IDEA-69128 ) 2011-08-22 17:56:04 +02:00
anna
d008da0ec2 add constructor parameter from field: annotate as @NotNull if necessary (IDEA-59977) 2011-06-15 17:16:12 +04:00
anna
23d1e4adf4 add constructor param from field: filter constructors for all field assignments (IDEA-61889) 2011-05-27 15:43:38 +04:00
anna
419cca8a1a add all fields as parameter when one constructor found (then params can be in the dialog adjusted) 2011-05-27 15:43:38 +04:00
anna
81c958ccfd check if constructor already contains field assignment before add new one (IDEA-69792) 2011-05-23 20:56:20 +04:00
anna
d469a37fb7 skip copyright for tests 2011-05-12 18:02:23 +04:00
anna
865c7b0bcc EA-27650 - IAE: ChangeSignatureProcessor.<init> 2011-05-12 15:48:49 +04:00
anna
f0fcf606f5 create param from field in case of chained calls 2010-07-12 16:46:30 +04:00
Alexey Kudravtsev
2718da9fc7 more java tests moved to community 2010-06-25 12:46:40 +04:00