1. Delete `intellij.python.community.impl.xml` (move content to `PythonCore` plugin). It is necessary to fix incorrect dependencies: `PythonCore`, `Pythonid` include the same module.
2. Fixed dependencies: if some plugin/module needs Python core functionality, then it should depend on `PythonCore`.
Co-authored-by: Vladimir Koshelev <Vladimir.Koshelev@jetbrains.com>
Merge-request: IJ-MR-136158
Merged-by: Egor Eliseev <Egor.Eliseev@jetbrains.com>
GitOrigin-RevId: ce9ed4c17f601ee1ca2b6cf608f4e30fdac1d879
It turned out that the standard ProjectScopeBuilder impl(see PyProjectScopeBuilder) had been overridden for CLion since the python plugin was bundled. This change adds the same behavior to the tests, which causes some OCRootsSynchronizerLibraryRootsTest tests to fail. It should be noted that the runtime behaviour remains identical.
GitOrigin-RevId: 0ce464287c557f35769ecc4455a89c92993dec30
Layout:
JPS modules
`intellij.python.community`
`intellij.python.community.impl`
`intellij.python.parser`
`intellij.python.psi`
`intellij.python.psi.impl`
`intellij.python.ast`
use package `com.jetbrains.python`
and go to `intellij.python.community.impl` v2 module
JPS module
`intellij.python`
uses package `com.intellij.python.pro`
and goes to `intellij.python/pro` v2 module
Both v2 modules (along with lots of others) come with
`PythonId` (prof) or `PythonCore` (community) plugins
DS bundles `intellij.python.community.impl`
Idea and other Mini IDEs get `PythonCore` or `PythonId` plugin that bundle modules for Idea and mini IDEs
GitOrigin-RevId: 98f418c52d90d51b9adf3250c561f2c36c767e2d
Icons removed from SDK package (no need to have a separate class for it), ultimate icons moved out of community module.
There are only 3 icon packages in community:
* `PythonParserIcons`
* `PythonPsiApiIcons`
* `PythonIcons` (aka `intellij.python.community.impl`)
Latter two have `.json` mapper to replace old icons with new one for New UI which is included into corresponding `.xml` file.
GitOrigin-RevId: 0438ad4485b5a82a89c81ec63ae6e575d5bb52de
Instead of type, since DSModulesSdkConfigurable does not inherit PyActiveSdkModuleConfigurable.
GitOrigin-RevId: c8d546883afdc7958cc980a335a3981d9f05faf3
The non-impl modules for these plugins now contain more or less just their plugin.xml files
that declare corresponding dependencies.
GitOrigin-RevId: 84fc4761a595912d676cff1e2ab58fba03a8cd22
Module intellij.python.configure used to be included into both PyCharm Customization and Python plugins leading to
duplicate classes in these plugins. Even after removing it from intellij.pycharm.community.customization it was
unclear what should go into intellij.python.configure, since its *.xml was used only in
intellij.pycharm.community.customization while its source code was used either in PyCharm Customization or in
intellij.python.community.impl + PyCharm Customization.
GitOrigin-RevId: 008601cd993cebd22bbfe69f963e53a690691608
During the recent refactoring a Python plugin only file python-community-plugin-core.xml got included
into the Python plugin which is now bundled with PyCharm. It resulted in using Python plugin specific
components that were designed for the UI of IntelliJ, not PyCharm. This change restores the
registration of PyIdeCommonOptionsFormFactory and moves all includes of python-community-plugin-core.xml
to Python plugin specific files.
GitOrigin-RevId: cd8b6d9b68266ca99f206c005ba73a2e77657950