Commit Graph

4907 Commits

Author SHA1 Message Date
Egor Ushakov
14f97e2a1f [debugger] made DebuggerCommandImpl.action not abstract
GitOrigin-RevId: 7ba289df8f72fa586cc0916021e1ce98167f9bed
2024-06-28 16:57:34 +00:00
Egor Ushakov
aa2343c112 [debugger] restored async stack traces
GitOrigin-RevId: 379113ab94e0c16e70441caa3d56a0485cf0e465
2024-06-28 16:57:34 +00:00
Egor Ushakov
b103326863 IDEA-354542 Slow frame location resolve blocks the debugger
Rename methods

Fix debugger process await

Force stop debug process in tests

Do not create additional thread

fixing tests: wait for the debug process to stop

Test hotfix: await debugger thread complete

Introduce DebuggerCompletableFuture

fixing tests: do not rely that much on invokeRatherLater

fixing tests: command cancel may happen off debugger manager thread

added experimental annotations

Add DebuggerDispatcherTest

removed debugProcess param

reduce methods visibility

Call continuation in case of command cancellation

Fix test: call continuation in any case

Clean up

Unify invokeWithChecks

introduced onSuspend

Invoke resume in tests only after all commands complete

[debugger] IDEA-354542 Remove unused constructor parameter

Close test debugger manager thread on dispose

Close debugger manager thread in tests

Add extra check to the continuation set

Fix project leak in test, set up test disposable for DebuggerManagerThread

Launch single command once

Fix API test

Fix test: request source position from debugger manager thread

Clean up code

Clean up command scope creation

SuspendContextCommand logic should be skipped on coroutine resume

cancel coroutine scope in finally block

handle command cancellation

Rename .java to .kt

Fix read action

Start as completable future

Run with commands

Use coroutines in FileApplicabilityChecker

handle exceptions like before

Launch with dispatch

make internal

allow the dispatcher to work without a command in context

renamed debugger thread dispatcher

Add coroutines util functions

Wrap into readAction-s

Extract caching code in CompoundPositionManager

Small code clean up

minimize changes

IDEA-354542 Slow frame location resolve blocks the debugger - introduced PositionManagerAsync


Co-authored-by: Maksim Zuev <Maksim.Zuev@jetbrains.com>

Merge-request: IJ-MR-136324
Merged-by: Maksim Zuev <Maksim.Zuev@jetbrains.com>

GitOrigin-RevId: d78e8514b89afdde6bc710bb322d67ddea6449e8
2024-06-27 20:27:29 +00:00
Tagir Valeev
9b8d299c1e Warnings fixed (i18n+others)
GitOrigin-RevId: 404f67f93b6c8d0df6ed13774791fc2d12b613cc
2024-06-27 11:21:13 +00:00
Tagir Valeev
19fb624028 [java] Use PsiUtil.getContainingClass instead of ClassUtils.getContainingClass
GitOrigin-RevId: f8a6abc7358a2c39dc4c50deaabe14c676f0977c
2024-06-26 11:52:02 +00:00
Maksim Zuev
7a22187670 [debugger] Fix statistics event name
GitOrigin-RevId: 46cf584a04429cf52667c45e024aa3bf70716bb4
2024-06-26 09:43:07 +00:00
Alexey Merkulov
5c0f8ae463 [debugger] Add registry to enable full JDI logging in unit tests
GitOrigin-RevId: 81b33b35bbd8e9f3e2c31e8bbee7c85e0b3462fd
2024-06-25 14:34:58 +00:00
Dmitry Pogrebnoy
93e715683e [Feedback] EA-1296862 Add kotlin serialization plugin
GitOrigin-RevId: c785715d4cbed7a04ac2f42150a72cab0b1bb8b8
2024-06-24 14:35:56 +00:00
Alexey Merkulov
d418e03406 [debugger] Add more debug logging about suspend-context processing
GitOrigin-RevId: c7a2617c8e3976460f99365aeb4e64f6582a9ed7
2024-06-24 10:53:04 +00:00
Alexey Merkulov
07b577552d [debugger] Disable logging because of suspect for more flaky behaviour
GitOrigin-RevId: b2ae72c0da5b03115fed84c258df79f920ca4893
2024-06-24 10:09:19 +00:00
Alexey Merkulov
4da3186093 Revert "[debugger] Fix a possible problem when the debugger never stops because of infinite conditional breakpoint checks"
This reverts commit 29d353907c73e1125b39a18c0c3f852979c6717e.

GitOrigin-RevId: 03ea3af79472a704a948644f2bee52ed8500debd
2024-06-24 10:09:19 +00:00
Alexey Merkulov
da6f5c77a0 [debugger] Report debugger state after 3 minutes of debugger process running in unit tests
GitOrigin-RevId: a0655bfcbf7e3c6f4060fa63cbdf79a66c090f58
2024-06-24 08:34:49 +00:00
Alexey Merkulov
7614feafcf [debugger] Return debug JDI logging to investigate flaky tests
GitOrigin-RevId: 7a79363ea0d070743390ca3382ce8fb728954c59
2024-06-23 09:30:16 +00:00
Egor Ushakov
f69745925e [coroutine debugger] limit coroutine stepping breakpoint to the exact class to avoid searching for inheritors
GitOrigin-RevId: ca9798d4e6f92453b8769c12e453117251fb0a40
2024-06-21 15:11:59 +00:00
Maksim Zuev
ced3ffa09a [debugger] Report statistics of smart-step-into status
GitOrigin-RevId: 754ccd2942b46e8f525f80ee177212d7ce07624a
2024-06-21 14:24:28 +00:00
Alexander Kuznetsov
5e5d0f6c13 [debugger] IDEA-348853 separate evaluations coming from Kotlin
GitOrigin-RevId: a847240bff18fc21e830f4ed29ee3729f2fc264e
2024-06-20 17:48:42 +00:00
Alexander Kuznetsov
948d66738b [debugger] IDEA-348853 implement Java evaluator statistics
GitOrigin-RevId: d06e86bdcf53ab2190c055d82f39241559f8cfd6
2024-06-20 17:48:42 +00:00
Egor Ushakov
98a593703b [debugger] rethrow CancellationException exception
GitOrigin-RevId: ffdaa3f12ce520531b4accd6b7f8d5ed6495c67f
2024-06-19 17:05:14 +00:00
Vladimir Parfinenko
8d6375c6c2 [debugger] API to visualize text values, IDEA-135082
GitOrigin-RevId: 1da6fc297d89596852cafd9112c48d26e9f55fec
2024-06-19 14:07:03 +00:00
Tagir Valeev
440654c48f Pattern variable can be used fixes; other warning fixes
GitOrigin-RevId: 49f37e7f5d748be50ee66fdf66a5c9b98b1b7432
2024-06-18 19:55:23 +00:00
Tagir Valeev
3fd0f4975d Pattern variable can be used fixes; other warning fixes
GitOrigin-RevId: 4965216d1872b439970db33dbe2864d5aab9606e
2024-06-18 19:55:23 +00:00
Maksim Zuev
b76e7618df [debugger] Report smart step into targets location in internal mode
GitOrigin-RevId: e22ea357a27556f4d7da8ad67b1578f009df5733
2024-06-18 16:44:05 +00:00
Tagir Valeev
522f2ab43e [i18n] Fix internationalization warnings
GitOrigin-RevId: 7b4a959cf215d79d86d6d9a7727f0fc054097517
2024-06-18 13:46:50 +00:00
Lev Serebryakov
1f01aac790 IJPL-149317 Disable Write Intent Lock for runnables executed on EDT
Wrap runnable in DebuggerInvocationUtil.swingInvokeLater into ReadAction.

GitOrigin-RevId: cbf9b409baa10a0c037a8cb5da11427f1774245a
2024-06-16 06:51:19 +00:00
Maksim Zuev
0f8a44d3a7 [debugger] Fix flaky Kotlin tests: reschedule processing back to DebuggerManagerThread
GitOrigin-RevId: 8c11006aa1f5699babb81b5c76c357903cb749da
2024-06-13 16:57:32 +00:00
Maksim Zuev
568f1c61bf [debugger] Disable jdi log in unit tests by default
GitOrigin-RevId: d51dad6ab943585efb29e9cc67b31b1b30b1dc09
2024-06-13 16:57:32 +00:00
Alexey Merkulov
a8a005f7f1 IDEBIS-32 Inline registry to be able to cherry-pick changes
GitOrigin-RevId: a4b41fe23d8f58e52e17899ef34a13e3bad0d6da
2024-06-12 16:36:22 +00:00
Alexey Merkulov
1d1c6f0f38 [debugger] Switch to the freezing thead if there is suspend-all context available
GitOrigin-RevId: 29f4650a9d488f6e96342c53c71a2037279cfa54
2024-06-12 15:49:33 +00:00
Alexey Merkulov
35dfeafbe3 [debugger] IJ-CR-135542 Minor fixes
GitOrigin-RevId: e4c8790a57285881c636f4d0c67d46a2ca38d4dc
2024-06-12 15:49:33 +00:00
Alexey Merkulov
a900b8c725 IDEBIS-32 Fix Kotlin Debugger survey duration
GitOrigin-RevId: 4809585f3ae9e7ca182f8c7b7637a4ee4eaec15e
2024-06-10 17:19:28 +00:00
Alexey Merkulov
e8d9492112 [debugger] Fix a possible problem when the debugger never stops because of infinite conditional breakpoint checks
It is not required now to wait all evaluations would complete. The listener in the DebugProcessImpl will resume the suspended evaluations on pause.

GitOrigin-RevId: 29d353907c73e1125b39a18c0c3f852979c6717e
2024-06-07 18:11:10 +00:00
Alexey Merkulov
185f86079e [debugger] Fix use-case when suspend-thread and suspend-all breakpoints trigger together
Now the correct suspend context will be used when thead from suspend-thread context is chosen. Also, it fixes several exceptions.

GitOrigin-RevId: 25ba84416477e0e4ef5d743e8f592237ca51a08a
2024-06-05 17:47:00 +00:00
Alexey Merkulov
32839898c3 [debugger] Fix notification disposing problems
GitOrigin-RevId: 2ea5a8a6ec0998bb435994fca97faff06d89ffd5
2024-06-05 15:50:51 +00:00
Alexey Merkulov
9e5909a854 [debugger] Hide thread model counter handling from public API
GitOrigin-RevId: 56eee01ed400e242f431b7dcd004d7622ca5063f
2024-06-04 19:08:21 +00:00
Alexey Merkulov
2ea7b25fb9 [debugger] Bound threads consistency check to the pause command
So it will be dropped if the context becomes released

GitOrigin-RevId: e2443b140d462a10a6eff15d25254c5d6e12a4a2
2024-06-04 19:08:16 +00:00
Alexey Merkulov
27bd668c67 [debugger] Anonymize error reports for non-internal users
GitOrigin-RevId: 30d3b8d15c0fa73d56b4e404ef62c875aa7da222
2024-06-04 18:22:03 +00:00
Egor Ushakov
03a14524da [debugger] extra logging for flaky tests
GitOrigin-RevId: dbeeb2684c53dc74bd2b35a6dfb49bedebcf4f75
2024-05-31 19:10:06 +00:00
Alexey Merkulov
cb43e4a923 [debugger] Simplify and cleanup debugger error logging
GitOrigin-RevId: b8761b41a28123834466c15b5801e0f1fd48ba8d
2024-05-31 18:53:38 +00:00
Alexey Merkulov
4d84472f90 [debugger] Workaround for EA-1240564
GitOrigin-RevId: 913a70a1f122e2aea709f7815d92c4e5e4e0f308
2024-05-31 18:45:59 +00:00
Alexey Merkulov
dae1eab5f3 [debugger] Add some logging for event processing
GitOrigin-RevId: 9a68e1354af567107e68f27c5e129c54f029f545
2024-05-31 18:45:54 +00:00
Alexey Merkulov
58a2b77421 [debugger] Improve debug-log diagnostics
GitOrigin-RevId: a111765fc74800dd852e56239c6e4048e0691185
2024-05-30 17:22:52 +00:00
Egor Ushakov
d817c984a5 IDEA-353979 Flaky test DebuggerSessionTest.testPauseSession
GitOrigin-RevId: e018035d56cd483730bbc062a2515cdd70bce384
2024-05-30 16:20:53 +00:00
Egor Ushakov
8bcf1891b1 EA-1018043 - NPE: PositionManagerImpl.findNested
GitOrigin-RevId: fdefc502941e7db36608a7f1754b320de72e2d68
2024-05-30 12:11:43 +00:00
Alexey Merkulov
2dd7b7a9c5 [debugger] Add JDI debug trace logging for unit tests
GitOrigin-RevId: 04ecaca42ca7d120f70227385b4dea463e9452b8
2024-05-30 00:34:35 +00:00
Egor Ushakov
3121686e49 EA-1075781 - INRE: LineBreakpoint.findClassCandidatesInSourceContent
smartMode is not needed any more after we started using DumbModeAccessType.RELIABLE_DATA_ONLY.ignoreDumbMode in InvokeThread

GitOrigin-RevId: 558a279b570cccd00d8e5790e4f9a5ead7ad8a06
2024-05-29 20:24:08 +00:00
Alexey Merkulov
32407eb519 [debugger] Fix incorrect debugger command management in suspend-all invocation watcher
GitOrigin-RevId: 9fc18aaf98917278f71fb83a374807d4bdcb93b0
2024-05-29 19:27:33 +00:00
Egor Ushakov
c97481e23e EA-1235246 - ADE: StubIndexImpl.getAsyncState
GitOrigin-RevId: a26548c5b4af4e51caefa69e28ecd5c4f559d263
2024-05-29 16:38:46 +00:00
Alexey Merkulov
79a9ffd7b8 [debugger] Add additional consistency diagnostic
GitOrigin-RevId: aa20b976a7913b2e89b6f5f9d6bcc21047d66688
2024-05-29 15:30:56 +00:00
Alexey Merkulov
cc17be8830 [debugger] Add proper processing of explicitly resumed threads
GitOrigin-RevId: 85cfa795069482bb32c50f3d35b99238f2f9eb98
2024-05-29 15:30:55 +00:00
Alexey Merkulov
886c4f6bc0 [debugger] Fix handling suspending/freezing threads in suspend-all mode
GitOrigin-RevId: f89b68ff5f9c36e2bf704098b797661f5d5f9d89
2024-05-29 15:30:53 +00:00